GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2021
[STORM-2427] Fix event logger enable disable UI buttons
Applying relevant commits from 1.x and some minor fix.
You can merge this pull request into a Git repository by running:
$ git
Github user satishd commented on the issue:
https://github.com/apache/storm/pull/1999
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2019
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/2019
@satishd
I have fixed the UTs. The MockCollector.emit used in the UT needed to be
updated to correspond with the emit method used by the JoinBolt. Have
squashed the commits.
---
If your
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2018
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2018
@ptgoetz
OK either applying or not applying this to 1.0.x is fine for me.
Given that you're planning to apply this to master branch as well, I think
this is mergeable now.
+1
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1924
Sorry to keep changing this. I hope these are the last few changes. The
spout should now seek to the lowest retriable offset for each partition when
retrying tuples, instead of seeking back to the last
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1999
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2009
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/2020
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2019
+1 for the concept, would like to understand the test failures though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2018
@HeartSaVioR Yes, that's my plan. I prioritized the 1.1.x branch since it's
needed for the 1.1.0 release.
I'm not sure we want to apply it to the 1.0.x branch since we have a number
of
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2018#discussion_r106933223
--- Diff: examples/storm-perf/pom.xml ---
@@ -22,8 +22,8 @@
storm
org.apache.storm
-1.1.1-SNAPSHOT
-
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2002
Hello,@HeartSaVioR
It's not easy to clean up the commits.And there is only one file changed in
the end.Is it necessary to clean up the commits?
---
If your project is set up for it, you
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2018
@ptgoetz
Could you make the change for master branch? Maybe 1.0.x branch too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2000
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2002
+1
Please clean up your commits. I think only a commit is sufficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2000
+1 This makes consistent with 1.x branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user satishd closed the pull request at:
https://github.com/apache/storm/pull/2012
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2007
@hmcl Thanks for the great work. I merged into master, 1.x, 1.0.x branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2007
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user satishd commented on the issue:
https://github.com/apache/storm/pull/2020
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2016
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2016
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2020
STORM-2425: Storm Hive Bolt not closing open transactions
Invoking `retireIdleWriters` when the hive bolt receives a tick tuple will
periodically close the idle connections.
You can merge
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2018
Looks great otherwise. I'd be +1 once build issue is fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2018#discussion_r106855963
--- Diff: examples/storm-perf/pom.xml ---
@@ -22,8 +22,8 @@
storm
org.apache.storm
-1.1.1-SNAPSHOT
-
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2005
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2014
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1974
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2015
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user satishd commented on the issue:
https://github.com/apache/storm/pull/2005
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2005#discussion_r106837872
--- Diff:
storm-core/src/jvm/org/apache/storm/blobstore/LocalFsBlobStore.java ---
@@ -219,17 +219,37 @@ public void setBlobMeta(String key,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2005#discussion_r106837874
--- Diff:
storm-core/src/jvm/org/apache/storm/blobstore/LocalFsBlobStore.java ---
@@ -219,17 +219,37 @@ public void setBlobMeta(String key,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2005#discussion_r106837869
--- Diff:
storm-core/src/jvm/org/apache/storm/blobstore/LocalFsBlobStore.java ---
@@ -219,17 +219,37 @@ public void setBlobMeta(String key,
35 matches
Mail list logo
