[GitHub] storm issue #2152: STORM-2639: Kafka Spout incorrectly computes numCommitted...

Github user askprasanna commented on the issue: https://github.com/apache/storm/pull/2152 Created a new JIRA and updated PR title as recommended. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #2220: STORM-2638: Add in maximum object size for Pacemaker Thri...

Github user vesense commented on the issue: https://github.com/apache/storm/pull/2220 Looks good to me. It would be better if we can apply new code style to the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @HeartSaVioR I have modified this PR according to your opinion,and it has passed all the test.Could you help me merge it?Thank you very much. --- If your project is set up for it, you can

Re: Connection refused

Make sure the nimbus is running properly. Sent from my iPhone > On 18 Jul 2017, at 09:16, sam mohel wrote: > > i'm facing problem with submitting topology in distributed mode > storm-0.10.2 zookeeper-3.4.6 > > Exception in thread "main" java.lang.RuntimeException: >

Connection refused

i'm facing problem with submitting topology in distributed mode storm-0.10.2 zookeeper-3.4.6 Exception in thread "main" java.lang.RuntimeException: org.apache.thrift7.transport.TTransportException: java.net.ConnectException: Connection refused (Connection refused) at

[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @HeartSaVioR Thanks for your reply.I will remove it from Config.java. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2208 I think the best way to avoid misleading is just removing the configuration and set the value as constant. We don't need to provide an option to user while the value is actually fixed. --- If

[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @harshach Thanks for your reply.You can see StormSubmitter.java,line 91.STORM_ZOOKEEPER_TOPOLOGY_AUTH_SCHEME is should always be set to digest.It can't be and won't be other value.So,I

[GitHub] storm issue #2219: [STORM-2637] fix ClassCastException in logviewer get-log-...

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2219 Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] storm pull request #2219: [STORM-2637] fix ClassCastException in logviewer g...

Github user Ethanlm closed the pull request at: https://github.com/apache/storm/pull/2219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2152: [STORM-2505] OffsetManager should account for offset void...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2152 @askprasanna let's just create a new JIRA and associate it with the STORM-2505 JIRA - it's a quick thing and will take care of this clean. Another minor detail we have a script to find orphan

[GitHub] storm issue #2152: [STORM-2505] OffsetManager should account for offset void...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2152 @askprasanna Maybe we would need to associate this to a new issue to track your effort (given that assignee for STORM-2505 is not you and it can't be overwritten), or remove the issue at

[GitHub] storm issue #2219: [STORM-2637] fix ClassCastException in logviewer get-log-...

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2219 Thanks. I will submit a patch against 1.x branch. I am not very familiar with logviewer clojure implementation yet. But I will try and see what I can do. --- If your project is set up for it,

[GitHub] storm issue #2219: [STORM-2637] fix ClassCastException in logviewer get-log-...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2219 Thanks for the patch. I just would like to see this patch against 1.x branch rather than master, given that we should review and apply #2204 to remove Clojure implementation. Btw, if you

[GitHub] storm pull request #2219: [STORM-2637] fix ClassCastException in logviewer g...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2219#discussion_r127842992 --- Diff: storm-core/src/clj/org/apache/storm/daemon/logviewer.clj --- @@ -311,7 +311,7 @@ (defn get-log-user-group-whitelist [fname]

[GitHub] storm pull request #2147: STORM-2538: New kafka spout emits duplicate tuples

Github user hmcl closed the pull request at: https://github.com/apache/storm/pull/2147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2147: STORM-2538: New kafka spout emits duplicate tuples

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2147 Closed in favor of #2151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm issue #2147: STORM-2538: New kafka spout emits duplicate tuples

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2147 @hmcl @srdo I don't think we need this given this PR https://github.com/apache/storm/pull/2151 makes manual assignment as default. --- If your project is set up for it, you can reply to this

[GitHub] storm issue #2151: STORM-2542: Remove KafkaConsumer.subscribe API option, ma...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2151 +1. Thanks @srdo this looks great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #2155: STORM-2548: Simplify KafkaSpoutConfig to avoid duplicatin...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2155 still +1 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] storm issue #2217: [1.x-branch] [STORM-2505] OffsetManager should account fo...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2217 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #2215: STORM-2548: Simplify KafkaSpoutConfig (1.x)

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2215 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #2215: STORM-2548: Simplify KafkaSpoutConfig (1.x)

Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/2215#discussion_r127821694 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/SerializableDeserializer.java --- @@ -16,10 +16,14 @@ package

[GitHub] storm issue #2147: STORM-2538: New kafka spout emits duplicate tuples

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2147 @hmcl I am strongly in favor of option 1, since no one has provided a use case for/argued in favor of the subscribe API based partition assignment code. Ideally we'll deprecate (1.x) and remove (2.x)

[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2208 @liu-zhaokun I think the comment there meant to say by default it will be "No Authentication". I.e Its users responsibility to set to digest in a secure clusters. But since the default settings for

[GitHub] storm issue #2218: STORM-2614: Enhance stateful windowing to persist the win...

Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2218 Sounds like a checkpoint mechanism limited to windowed bolts. Could you provide a design document for this ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request #2220: STORM-2638: Add in maximum object size for Pacemak...

GitHub user knusbaum opened a pull request: https://github.com/apache/storm/pull/2220 STORM-2638: Add in maximum object size for Pacemaker Thrift objects You can merge this pull request into a Git repository by running: $ git pull https://github.com/knusbaum/incubator-storm

[GitHub] storm issue #2209: [STORM-2622] Add owner resource summary on storm UI

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2209 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #2219: [STORM-2637] fix ClassCastException in logviewer g...

GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2219 [STORM-2637] fix ClassCastException in logviewer get-log-user-group-whitelist func… In get-log-user-group-whitelist function, the getLogMetaDataFile function returns a File while the

[GitHub] storm issue #2147: STORM-2538: New kafka spout emits duplicate tuples

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2147 @srdo @harshach @arunmahadevan in face of the Manual Partition assignment related [fixes](https://github.com/apache/storm/pull/2151/commits), there are two options. I believe in the email list we

[GitHub] storm pull request #2151: STORM-2542: Remove KafkaConsumer.subscribe API opt...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2151#discussion_r127773597 --- Diff: docs/storm-kafka-client.md --- @@ -240,12 +240,9 @@ streams. If you are doing this for Trident a value must be in the List returned otherwise

[GitHub] storm pull request #2150: STORM-2541: Fix storm-kafka-client manual subscrip...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2150#discussion_r127769417 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/TopicFilter.java --- @@ -0,0 +1,38 @@ +/* + * Copyright 2017 The

[GitHub] storm issue #2150: STORM-2541: Fix storm-kafka-client manual subscription no...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2150 +1. @harshach @priyank5485 can you please take one final look. If you don't have any objection, I suggest that we merge this patch in the next day or so. --- If your project is set up for it, you can

[GitHub] storm issue #2155: STORM-2548: Simplify KafkaSpoutConfig to avoid duplicatin...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2155 +1. @harshach @priyank5485 can you please take one final look. If you don't have any objection, I suggest that we merge this patch in the next day or so. --- If your project is set up for it, you can

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

GitHub user arunmahadevan opened a pull request: https://github.com/apache/storm/pull/2218 STORM-2614: Enhance stateful windowing to persist the window state Right now the tuples in window are stored in memory. This limits the usage to windows that fit in memory. Also the

[GitHub] storm issue #2199: [STORM-2201] Add dynamic scheduler configuration loading

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2199 Hi @HeartSaVioR @revans2, could you please review this when you get a chance? Thanks very much! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #2209: [STORM-2622] Add owner resource summary on storm UI

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2209 Added some unit tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm issue #2152: [STORM-2505] OffsetManager should account for offset void...

Github user askprasanna commented on the issue: https://github.com/apache/storm/pull/2152 Squashed the commits. Also opened https://github.com/apache/storm/pull/2217 for 1.x branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request #2217: [1.x-branch] [STORM-2505] OffsetManager should acc...

GitHub user askprasanna opened a pull request: https://github.com/apache/storm/pull/2217 [1.x-branch] [STORM-2505] OffsetManager should account for offset voids when retur… …ning the count of committed offsets You can merge this pull request into a Git repository by running:

[GitHub] storm pull request #2152: [STORM-2505] OffsetManager should account for offs...

Github user askprasanna commented on a diff in the pull request: https://github.com/apache/storm/pull/2152#discussion_r127695589 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutCommitTest.java --- @@ -0,0 +1,146 @@ +/* + *

Release Planning for 1.1.1 and others?

Hi devs, We released Storm 1.1.0 at the late March, and we didn't have short plan for next release. (We discussed Storm 2.0.0, and I think we're getting closer, a bit slowly but steady.) While we still have some issues and pull requests for storm-kafka-client which I think should be included to

[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 @haitaoyao I am so sorry to bother you.Do you have time to help me review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @harshach I am so sorry to bother you.Do you have time to help me review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.