Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2247
@cluo512 Done. Please rebase against master. Thanks in advance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2261
Build failure is missing removing CHANGELOG.md to binary distribution pom.
I'll address and rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2247
@cluo512
Sorry we decided to get rid of CHANGELOG.md, but I forgot to remove it from
distribution pom as well. I'll do the update and let you know. You can rebase
after then.
---
If your p
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2261
STORM-2678 Improve performance of LoadAwareShuffleGrouping
* construct ring which represents distribution of tasks based on load
* chooseTasks() just accesses the ring sequentially
* port
Github user cluo512 commented on the issue:
https://github.com/apache/storm/pull/2247
Oh..check failed.
I looked the details. It seems that @HeartSaVioR changed the CHANGELOG.md
to DEVELOPER.md, so maven can't found this file.
Should I update the binary.xml to DEVELOPER.md?
Github user cluo512 commented on the issue:
https://github.com/apache/storm/pull/2247
@srdo The issue number have added.
Thanks for your advice again. I'm new about how to contribute.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2260
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2259
@revans2
OK,thanks for your reply.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2248#discussion_r131263697
--- Diff:
external/storm-jdbc/src/test/java/org/apache/storm/jdbc/common/JdbcClientTest.java
---
@@ -80,6 +85,24 @@ public void testInsertAndSelect() {
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2248
To me it looks good, just one question about the test (and this is mostly
for my own knowledge).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2249
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2249
Conceptually the changes look good to me. I have not dug into it in great
detail yet, but I do like the direction of the change.
I would also like to see the documentation and examples updat
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2251
@vinodkc Thanks for changing the PR title. Could you change commit title as
well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2255
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2253
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2259
@liu-zhaokun we have a policy that we need to wait 24 hours before merging
a change, even a trivial one like this to give all devs time to review and
comment.
---
If your project is set up for it,
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2259
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2260
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2218
@srdo , thanks for taking time to do an in-depth review. Have addressed
your latest comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131220681
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2363,7 +2363,7 @@ private CommonTopoInfo getCommonTopoInfo(Stri
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131219950
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/SimpleWindowPartitionCacheTest.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the A
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131219624
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/persistence/WindowState.java ---
@@ -0,0 +1,422 @@
+/**
+ * Licensed to the Apache So
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131219546
--- Diff:
storm-client/test/jvm/org/apache/storm/windowing/persistence/WindowStateTest.java
---
@@ -0,0 +1,247 @@
+/**
+ * Licensed to the Apa
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131219599
--- Diff:
storm-client/test/jvm/org/apache/storm/windowing/persistence/WindowStateTest.java
---
@@ -0,0 +1,247 @@
+/**
+ * Licensed to the Apa
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131219494
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/SimpleWindowPartitionCacheTest.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the A
Github user tterstep closed the pull request at:
https://github.com/apache/storm/pull/2258
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
GitHub user tterstep opened a pull request:
https://github.com/apache/storm/pull/2260
parametrizing the debug log messages to improve the performance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tterstep/storm PARAMETRIZED_DE
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2202
@HeartSaVioR Sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2250
Thanks, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2250
Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2250
Added the missing html tags and a title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2250
+1
Minor nit: It generates html, but not an html *document* (i.e. missing
head, body, etc. tags), but that's just a few print statements that can be
added at merge time.
---
If your projec
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2250#discussion_r131191016
--- Diff: dev-tools/release_notes.py ---
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+
+# Licensed to the Apache Software Foundation (ASF) under one
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2250
+1. Let's squash the commits and it's good to go as far as I am concerned.
Thanks @srdo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2250
Addressed comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2250#discussion_r131183531
--- Diff: dev-tools/release_notes.py ---
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+
+# Licensed to the Apache Software Foundation (ASF) under one or
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2250#discussion_r131180727
--- Diff: dev-tools/release_notes.py ---
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+
+# Licensed to the Apache Software Foundation (ASF) under one
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2250#discussion_r131180462
--- Diff: dev-tools/release_notes.py ---
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+
+# Licensed to the Apache Software Foundation (ASF) under one
It should, especially for the ackers.
The ackers receive lots and lots of small messages, and those messages come
from all over your topology. What is more if you have max.spout.pending set
how quickly the messages can get to them and back to the spouts determines the
throughput of your topolog
I am not completely sure why that was a requirement. I know internally we have
removed it, not sure if we pushed that change back or not yet. On newer
versions of storm 1.0.3+ that have the rewritten supervisor that check is
invalid and you should be able to remove the check and just update th
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/2258
-1
Why not simply use parameterized messages instead? See
https://www.slf4j.org/faq.html#logging_performance
---
If your project is set up for it, you can reply to this email and have your
repl
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131119473
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/SimpleWindowPartitionCacheTest.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Sof
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131123972
--- Diff:
storm-client/test/jvm/org/apache/storm/windowing/persistence/WindowStateTest.java
---
@@ -0,0 +1,247 @@
+/**
+ * Licensed to the Apache Softw
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131126237
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/persistence/WindowState.java ---
@@ -0,0 +1,422 @@
+/**
+ * Licensed to the Apache Software Fo
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131125567
--- Diff:
storm-client/test/jvm/org/apache/storm/windowing/persistence/WindowStateTest.java
---
@@ -0,0 +1,247 @@
+/**
+ * Licensed to the Apache Softw
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131120403
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/SimpleWindowPartitionCacheTest.java
---
@@ -0,0 +1,232 @@
+/**
+ * Licensed to the Apache Sof
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131127445
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2363,7 +2363,7 @@ private CommonTopoInfo getCommonTopoInfo(String
topoI
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131123215
--- Diff:
storm-client/test/jvm/org/apache/storm/windowing/persistence/WindowStateTest.java
---
@@ -0,0 +1,247 @@
+/**
+ * Licensed to the Apache Softw
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r131121321
--- Diff:
storm-client/test/jvm/org/apache/storm/windowing/persistence/WindowStateTest.java
---
@@ -0,0 +1,247 @@
+/**
+ * Licensed to the Apache Softw
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2247
@cluo512 Could you add the issue number to the commit message? Then I think
we're good to merge :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
54 matches
Mail list logo
