[GitHub] storm pull request #2251: [STORM-2677] consider all sampled tuples which too...

2017-08-04 Thread vinodkc
Github user vinodkc closed the pull request at: https://github.com/apache/storm/pull/2251 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2247: STORM-2664: Fix for the distribution packaged on Windows ...

2017-08-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2247 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #2247: STORM-2664: Fix for the distribution packaged on W...

2017-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2251: [STORM-2677] consider all sampled tuples which took great...

2017-08-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2251 @vinodkc I merged this with some modification (commit title) but auto-close didn't work because it is pointing to non master branch. Could you close this? Thanks again for contribution! --- If

Regarding Issue with Multi-Lang in Storm

2017-08-04 Thread Sitakant Mishra
Hi, I am trying to run the WordCountTopology in storm local mode before running my own application and I am unable to run it. I am continuously getting the following error. I have verified that the "splitsentence.py" file is kept at the "multilang/resources" directory. 5729

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

2017-08-04 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2241 Have updated the PR with these 2 major changes in addition to addressing many of the smaller TODOs I had. 1) **Introduced Wait Strategy** - For these two cases: Bolt having no incoming

[GitHub] storm issue #2202: STORM-2623: Add in a whitelist for scheduler strategies

2017-08-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2202 @knusbaum I guess it's messed up while squashing. Could you sort it out? If commit eabfa7d is clean one please let me know that I can just cherry pick it. --- If your project is set up for it,

[GitHub] storm issue #2249: WIP: STORM-2648/STORM-2357: Add storm-kafka-client suppor...

2017-08-04 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2249 @srdo reviewing it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] storm pull request #2259: [STORM-2676] Error class name for log in JsonRecor...

2017-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2259 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2260: parametrizing the debug log messages to improve the perfo...

2017-08-04 Thread tterstep
Github user tterstep commented on the issue: https://github.com/apache/storm/pull/2260 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #2260: parametrizing the debug log messages to improve th...

2017-08-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2260 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2260: parametrizing the debug log messages to improve the perfo...

2017-08-04 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2260 Thanks @tterstep I merged this into master. Keep up the good work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #2261: STORM-2678 Improve performance of LoadAwareShuffleGroupin...

2017-08-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2261 Now I introduce 'skip checking update count' to avoid calling System.currentTimeMillis() every time, but it has clear trade-off, we should call AtomicInteger.incrementAndGet() every time. I

[GitHub] storm issue #2251: [STORM-2677] consider all sampled tuples which took great...

2017-08-04 Thread vinodkc
Github user vinodkc commented on the issue: https://github.com/apache/storm/pull/2251 @HeartSaVioR , Thanks for the review comments. I've changed commit title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #2247: STORM-2664: Fix for the distribution packaged on Windows ...

2017-08-04 Thread cluo512
Github user cluo512 commented on the issue: https://github.com/apache/storm/pull/2247 Ok..Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] storm issue #2247: STORM-2664: Fix for the distribution packaged on Windows ...

2017-08-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2247 @cluo512 No worries. I'll handle it on merge phase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #2247: STORM-2664: Fix for the distribution packaged on Windows ...

2017-08-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2247 @cluo512 Done. Please rebase against master. Thanks in advance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project