[GitHub] storm issue #2270: [STORM-2686] Add Locality Aware Shuffle Grouping

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2270 I did some experiments on ThroughputVsLatency (modified to add some Configs) and the initial results seem similar among `shuffle`, `localOrShuffle` and `localityAwareShuffle (LocalityASG)`.

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2241 @revans2 for STORM-2306, Somehow the latest commits out there are not reflecting here in this PR. While i figure out the issue, please checkout the 2306 code directly from

[GitHub] storm issue #2275: STORM-2692: Load only configs specific to the topology in...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2275 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2174: STORM-2554: Trident Kafka Spout Refactoring to Include Ma...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2174 @srdo I am evaluating if we can do the change without breaking the API. If so we can go ahead with it. Otherwise, as you suggested, we can go with this change for 1.x-branch and then refactor for Storm

[GitHub] storm issue #2276: Fix typos in Worker.java

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2276 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2241 @roshannaik yes we can use aaebc3b as the base for tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1

Github user tiodollar commented on the issue: https://github.com/apache/storm/pull/2181 @HeartSaVioR i'll fix this merge today! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2181 We should also remove the +1 here I think