[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

2017-08-21 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2241 @roshannaik I just created a new pull request to master for an updated version of ThroughputVsLatency and I added in the test tools that I created for being able to capture and simulate topologies.

[GitHub] storm pull request #2289: STORM-2702: storm-loadgen

2017-08-21 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2289 STORM-2702: storm-loadgen Some tools to be able to generate load on a cluster for testing. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request #2288: [STORM-2700] Should not check Blobstore ACL if the...

2017-08-21 Thread Ethanlm
GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2288 [STORM-2700] Should not check Blobstore ACL if the validation is disabled See: https://issues.apache.org/jira/browse/STORM-2700 `canUserReadBlob ` function should take

[GitHub] storm issue #2282: STORM-2694: Add KafkaTupleListener to storm-kafka-client

2017-08-21 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2282 Thanks for making the changes. +1 once the license issue is fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request #2282: STORM-2694: Add KafkaTupleListener to storm-kafka-...

2017-08-21 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2282#discussion_r134280097 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/EmptyKafkaTupleListener.java --- @@ -0,0 +1,33 @@ +package

[GitHub] storm pull request #2282: STORM-2694: Add KafkaTupleListener to storm-kafka-...

2017-08-21 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2282#discussion_r134280004 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/EmptyKafkaTupleListener.java --- @@ -0,0 +1,35 @@ +package

[GitHub] storm issue #2270: [STORM-2686] Add Locality Aware Shuffle Grouping

2017-08-21 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2270 @roshannaik Thanks for the review. I did some performance testing with ACKing disabled on single Worker case: Performance testing on ConstSpoutNullBoltTopo with ACKing disabled.

[GitHub] storm issue #2287: [STORM-2699] Put all the version information of third par...

2017-08-21 Thread BigOneLiu
Github user BigOneLiu commented on the issue: https://github.com/apache/storm/pull/2287 @HeartSaVioR Could you please review my pr? thx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request #2287: [STORM-2699] Put all the version information of th...

2017-08-21 Thread BigOneLiu
GitHub user BigOneLiu opened a pull request: https://github.com/apache/storm/pull/2287 [STORM-2699] Put all the version information of third party component into the main pom [https://issues.apache.org/jira/browse/STORM-2699](https://issues.apache.org/jira/browse/STORM-2699)

[GitHub] storm issue #2270: [STORM-2686] Add Locality Aware Shuffle Grouping

2017-08-21 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2270 I will try some runs on STORM-2306 in single worker mode and ACK-disabled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #2270: [STORM-2686] Add Locality Aware Shuffle Grouping

2017-08-21 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2270 So the ACKer bolt is usually the bigger bottleneck ...compared to the groupings. So with ACKing enabled it will hide any bottlenecks in the groupings. The only thing slower than ACKer bolt is the

[GitHub] storm issue #2270: [STORM-2686] Add Locality Aware Shuffle Grouping

2017-08-21 Thread roshannaik
Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2270 taking a look... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,