[GitHub] storm issue #2334: STORM-2748: Fix TickTupleTest to actually test something

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2334 Thanks ---

[GitHub] storm issue #2297: [STORM-2713] when the connection to the first zkserver is...

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2297 @srdo I don't think it's related to retry, the key is how storm will do when the first zkserver is down. ---

[GitHub] storm issue #2334: STORM-2748: Fix TickTupleTest to actually test something

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2334 @srdo I turned it into a loop like you requested ---

[GitHub] storm pull request #2334: STORM-2748: Fix TickTupleTest to actually test som...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2334#discussion_r140039574 --- Diff: storm-server/src/test/java/org/apache/storm/TickTupleTest.java --- @@ -18,85 +18,113 @@ package org.apache.storm; +import

[GitHub] storm issue #2334: STORM-2748: Fix TickTupleTest to actually test something

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2334 @srdo I finally have the test passing predictably on travis. I also fixed the issues that you saw. Feel free to take another look. ---

[GitHub] storm issue #2334: STORM-2748: Fix TickTupleTest to actually test something

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2334 @srdo thanks for the review. Trying to get the test to work on the slower VMs is still a work in progress. I'll let you know why I actually have it passing consistently. ---

[GitHub] storm pull request #2334: STORM-2748: Fix TickTupleTest to actually test som...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2334#discussion_r140027547 --- Diff: storm-server/src/test/java/org/apache/storm/TickTupleTest.java --- @@ -18,85 +18,103 @@ package org.apache.storm; +import

[GitHub] storm pull request #2334: STORM-2748: Fix TickTupleTest to actually test som...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2334#discussion_r140026143 --- Diff: storm-server/src/test/java/org/apache/storm/TickTupleTest.java --- @@ -18,85 +18,103 @@ package org.apache.storm; +import

[GitHub] storm pull request #2333: fix HBaseSecurityUtil double_checked,

Github user xiaoyong03 closed the pull request at: https://github.com/apache/storm/pull/2333 ---

[GitHub] storm pull request #2333: fix HBaseSecurityUtil double_checked,

GitHub user xiaoyong03 reopened a pull request: https://github.com/apache/storm/pull/2333 fix HBaseSecurityUtildouble_checked, update HBaseSecurityUtil singleton to fix double_checked, http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html You can merge this

[GitHub] storm issue #2333: fix HBaseSecurityUtil double_checked,

Github user xiaoyong03 commented on the issue: https://github.com/apache/storm/pull/2333 thanks for review ---

[GitHub] storm pull request #2333: fix HBaseSecurityUtil double_checked,

GitHub user xiaoyong03 opened a pull request: https://github.com/apache/storm/pull/2333 fix HBaseSecurityUtildouble_checked, update HBaseSecurityUtil singleton to fix double_checked, http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html You can merge this

[GitHub] storm issue #2314: [STORM-2731] - Simple checks in Storm Windowing

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2314 Also opened an issue for tracking the int -> long change and variable renames so we don't forget https://issues.apache.org/jira/browse/STORM-2747. ---

[GitHub] storm issue #2314: [STORM-2731] - Simple checks in Storm Windowing

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2314 Thanks @jerrypeng, merged to master. The windowing classes have moved since 1.x so please open another PR if you want this to go in those versions too. ---

[GitHub] storm pull request #2314: [STORM-2731] - Simple checks in Storm Windowing

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2314 ---

Re: KafkaSpout v1.1.1 : ManualPartitionNamedSubcription fails to initilialize spout

Hi Stig You are correct. I will start using it once we move to 1.1.2. Thanks. On Tue, Sep 19, 2017 at 9:08 PM, Stig Rohde Døssing wrote: > Hi Chandan, > > This sounds like https://issues.apache.org/jira/browse/STORM-2541 which > should be fixed in 1.1.2. > > 2017-09-19 14:23