GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2384
STORM-2706: Upgrade to Curator 4.0.0 (1.x)
Ran tests locally and they passed. The only change from the master version
is that there was no storm-server pom to modify.
You can merge this pull request i
Github user itaifrenkel closed the pull request at:
https://github.com/apache/storm/pull/685
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2383
+1
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2383
+1
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2382
+1
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2382
@srdo I agree surprising. But I was looking into it. Each tuple that is
leaked is only about 120 bytes in 1.x and about 100 in 0.10 and below, in 2.x
it is 40 bytes. So in order to leak 1 MB in 1.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2382
+1, really nice find. Very surprising that it went unnoticed for that long.
---
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2383
STORM-2786: Enable tick tuples for ackers (1.x)
The patch apply cleanly to 1.1.x and 1.0.x too
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/re
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2378
---
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2382
STORM-2786: Turn ticks back on for ackers (2.x)
This does some minor optimizations for the ackers, but for the most part it
just turns Ticks back on for ackers.
I will be putting up a pull
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146325232
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146328865
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146325123
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146325771
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146326837
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146327070
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutR
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146329393
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -336,22 +335,25 @@ private void emit() {
priva
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146327143
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutR
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146329456
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146327422
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -125,8 +125,8 @@ public void open(Map conf,
TopologyCo
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146326949
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutR
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146327983
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -255,26 +255,25 @@ private void throwKafkaConsumerInter
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146326263
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146329730
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146325303
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146329596
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -438,55 +440,53 @@ private void commitOffsetsForAckedTu
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146324431
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146324267
--- Diff: docs/storm-kafka-client.md ---
@@ -298,25 +298,44 @@ Currently the Kafka spout has has the following
default values, which have been
* max.uncomm
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2381
+1
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1679
@apiwoni Your expectation for 1.1.3 is wrong. seekToEnd doesn't seek to the
last committed offset, it seeks to the last offset. One of the fixes made in
this PR is to make doSeekRetriablePartitions seek
Github user kevpeek commented on the issue:
https://github.com/apache/storm/pull/2379
@revans2 I ran some perf tests, and this refactor did slow things down
considerably. I have made a small change that eliminates the main source of
slowness, but it's still not great.
The cur
Github user BigOneLiu commented on the issue:
https://github.com/apache/storm/pull/2377
@revans2 like you said 99.9% of the time they are the same,and if the tuple
is delayed by 1 second,it's a big problem for storm.maybe you don't need this
data then.
vesense's consideration is g
Github user apiwoni commented on the issue:
https://github.com/apache/storm/pull/1679
@srdo I'm not sure why you expect the poll to return records after
seekToEnd? seekToEnd seeks to the end of the log in Kafka, and it doesn't
actually do the seek until poll or position is called on
33 matches
Mail list logo
