[GitHub] storm issue #2156: STORM-2549: Fix broken enforcement mechanism for maxUncom...

2017-11-10 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2156 @srdo Unfortunately I feel we couldn't bring Storm 1.1.2, and based on the fact, putting less effort to 1.1.x version line and focusing more on 1.2.0 may make sense to me. I guess it is not

[GitHub] storm issue #2389: [STORM-2693] Storm heartbeats promotion

2017-11-10 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2389 @HeartSaVioR hi, i have add support for local cluster and fix the unit tests problems, thx for your nice review work ---

[GitHub] storm pull request #2410: STORM-2808: Fix for NPE in UI

2017-11-10 Thread govind-menon
GitHub user govind-menon opened a pull request: https://github.com/apache/storm/pull/2410 STORM-2808: Fix for NPE in UI You can merge this pull request into a Git repository by running: $ git pull https://github.com/govind-menon/storm STORM-2808 Alternatively you can review a

[GitHub] storm issue #2363: STORM-2759: Let users indicate if a blob should restart a...

2017-11-10 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2363 @srdo 3 mins would correspond to a timeout that we have when the supervisor gets confused. https://github.com/apache/storm/blob/7afd6fbe4603e35114a84e836b02484fe8cda660/storm-serve

[GitHub] storm issue #2409: STORM-2796: Flux: Provide means for invoking static facto...

2017-11-10 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2409 I can squash the commits later, but for now keeping the check style commit separate will make review a lot easier. ---

[GitHub] storm pull request #2408: Fix pom dependency indent

2017-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2408 ---

[GitHub] storm pull request #2409: STORM-2796: Flux: Provide means for invoking stati...

2017-11-10 Thread ptgoetz
GitHub user ptgoetz opened a pull request: https://github.com/apache/storm/pull/2409 STORM-2796: Flux: Provide means for invoking static factory methods Note: The guts of this change are in the first commit. The last commit simply addresses check style violations. You can merge thi

[GitHub] storm issue #2408: Fix pom dependency indent

2017-11-10 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2408 @jacobtolar because this is just a white space change I didn't wait the usual 24 hours. Thanks for the patch and keep up the good work. ---

[GitHub] storm pull request #2408: Fix pom dependency indent

2017-11-10 Thread jacobtolar
GitHub user jacobtolar opened a pull request: https://github.com/apache/storm/pull/2408 Fix pom dependency indent I noticed that the indent of this dependency doesn't match the rest of the pom. You can merge this pull request into a Git repository by running: $ git pull https:

[GitHub] storm pull request #2156: STORM-2549: Fix broken enforcement mechanism for m...

2017-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2156 ---

[GitHub] storm issue #2156: STORM-2549: Fix broken enforcement mechanism for maxUncom...

2017-11-10 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2156 @HeartSaVioR Thanks for the review. The 1.x version is here https://github.com/apache/storm/pull/2407. I tried cherry picking to 1.1.x, but there have been a lot of changes in this module since

[GitHub] storm pull request #2407: STORM-2549 (1.x)

2017-11-10 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2407 STORM-2549 (1.x) 1.x version of https://github.com/apache/storm/pull/2156. The changes are in the last commit. Will squash once reviewed. You can merge this pull request into a Git repository

[GitHub] storm issue #2363: STORM-2759: Let users indicate if a blob should restart a...

2017-11-10 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2363 @revans2 I think something in this PR is causing topology deployment to either fail or be really slow occasionally. The integration test has been failing fairly consistently since cef450064fa20

[GitHub] storm pull request #2406: STORM-2807: Shut down integration test topologies ...

2017-11-10 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2406 STORM-2807: Shut down integration test topologies immediately after t… …ests, retry killing each topology for a minute and throw an error if it can't be done You can merge this pull request into a