[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-11-20 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 OK. While I understand what you're saying, that's not easy for individual to get it, cause we individual don't want to afford completely idle machine and use for only performance test. I have bee

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-11-20 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2203 @HeartSaVioR I know. ;) I'm thinking more in terms of hardware profile and what other processes are running. ---

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-11-20 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 You can scroll the result to see rightmost side which shows CPU, Memory, GC as well. ---

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-11-20 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 Here's my machine spec used for performance test: java version "1.8.0_144" Java(TM) SE Runtime Environment (build 1.8.0_144-b01) Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-11-20 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2203 We really need hardware and environment information. I'd also argue that tests should be run headless. I've seen some benchmarks vary greatly on a MBP depending on what you're doing at the time. Som

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-11-20 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 @ptgoetz @revans2 Here’s my result on performance test: CLI option: org.apache.storm.starter.ThroughputVsLatency 5 -c topology.max.spout.pending=5000 so that

[GitHub] storm pull request #2430: [STORM-2827] fix Logviewer search returning incorr...

2017-11-20 Thread Ethanlm
GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2430 [STORM-2827] fix Logviewer search returning incorrect logviewerUrl problem https://issues.apache.org/jira/browse/STORM-2827 The logviewer search returns "http" url no matter whether logviewe

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-11-20 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2203 @ptgoetz I think I just ran it with default options on my MBP. But I will try and reproduce it again. ---

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-11-20 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2203 @revans2 You may have to jog your memory ;), but do you recall the parameters you used for ThroughputVsLatency? I just ran ThroughputVsLatency (with defaults) on an isolated machine (not a V

[GitHub] storm issue #2427: MINOR: Use booleans instead of strings for 'enable.auto.c...

2017-11-20 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2427 Thanks, applied to master and 1.x ---

[GitHub] storm pull request #2427: MINOR: Use booleans instead of strings for 'enable...

2017-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2427 ---

[GitHub] storm pull request #2429: STORM-2813: Use a class for normalized resources n...

2017-11-20 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2429 STORM-2813: Use a class for normalized resources not a map. The goal here was at a minimum have a clear way to know if the resources were normalized or not, and secondarily to have something a bit b

Re: [Discuss] Release Storm 1.2.0

2017-11-20 Thread Priyank Shah
Regarding getTopicsString, its being used in storm-kafka-monitor https://github.com/apache/storm/blob/1.x-branch/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java#L626 and returning [topic_name] for one topic would not work. If we change it back to original f

Re: [Discuss] Release Storm 1.2.0

2017-11-20 Thread Stig Rohde Døssing
Happy to hear that it's at least running for you now :) Eager to hear your results. Regarding the getTopicsString format, the Subscription interface doesn't specify the string format (and it was never intended to be parsed in this way). In my opinion the format is an implementation detail, so we s

[GitHub] storm pull request #2419: STORM-2805: Clean up confs in TopologyBuilders

2017-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2419 ---

Re: [Discuss] Release Storm 1.2.0

2017-11-20 Thread Alexandre Vermeerbergen
Hello All, Good news today: I found & solved what was preventing my topologies from consuming since I had upgraded from storm-kafka-client 1.1.0 to storm-kafka-client.1.2.0-lastestsnapopfromstig. The reasons from our own BasicKafkaSpout class, which is our homebrewed Kafka spout based on same con