Re: Set executor id

2017-12-19 Thread Jungtaek Lim
Executor ID is assigned internally in Storm, so I don't find a reason to set/modify executor ID. Could you explain your case? Thanks, Jungtaek Lim (HeartSaVioR) 2017년 12월 13일 (수) 오후 9:56, Walid Aljoby 님이 작성: > Hi all, > I was wondering if someone helps on how to set/modify executor id ? thanks >

[GitHub] storm issue #2469: STORM-2861: Explicit reference kafka-schema-registry-clie...

2017-12-19 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/2469 @vesense kafka-avro-serializer module depends on kafka-schema-registry-client. This change does not seem to be really required. What issue are you facing with the existing dependency? I also

[GitHub] storm issue #2466: STORM-2844: KafkaSpout Throws IllegalStateException After...

2017-12-19 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2466 @srdo this is the master version. ---

[GitHub] storm issue #2465: STORM-2844: KafkaSpout Throws IllegalStateException After...

2017-12-19 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2465 @srdo can you please do one last review. Thanks. ---

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157930206 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/OffsetAndMetadataMocks.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the Apa

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157930231 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/MaxUncommittedOffsetTest.java --- @@ -71,6 +75,10 @@ 1, Kafk

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157930210 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/OffsetAndMetadataMocks.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the Apa

[GitHub] storm issue #2473: Update multilang modules

2017-12-19 Thread bitcloud
Github user bitcloud commented on the issue: https://github.com/apache/storm/pull/2473 I stumbled over that while playing around with the 1.1.x branch, so you probably need to merge that to those branches as well. Not quite sure since when the new protocol is in place. ---

[GitHub] storm pull request #2473: Update multilang modules

2017-12-19 Thread bitcloud
GitHub user bitcloud opened a pull request: https://github.com/apache/storm/pull/2473 Update multilang modules As it is now required to answer to the activation and deactivation, I added those to the javascript files because the examples stopped working. I updated ruby and

[GitHub] storm issue #2469: STORM-2861: Explicit reference kafka-schema-registry-clie...

2017-12-19 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2469 @vesense I tried to reproduce this by deleting Kafka-avro-serializer from my local maven repository, but the build succeeded. Can you elaborate a bit? ---

[GitHub] storm issue #2470: [STORM-2690] resurrect invocation of ISupervisor.assigned...

2017-12-19 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2470 +1 ---

[GitHub] storm issue #2472: [STORM-2690] resurrect invocation of ISupervisor.assigned...

2017-12-19 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2472 +1 ---

[GitHub] storm issue #2471: [STORM-2690] resurrect invocation of ISupervisor.assigned...

2017-12-19 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2471 +1 ---

[GitHub] storm pull request #2456: STORM-2725: Fix for wouldFit and rebalance as part...

2017-12-19 Thread govind-menon
GitHub user govind-menon reopened a pull request: https://github.com/apache/storm/pull/2456 STORM-2725: Fix for wouldFit and rebalance as part of GenericResourceAwareScheduling changes You can merge this pull request into a Git repository by running: $ git pull https://github

[GitHub] storm pull request #2456: STORM-2725: Fix for wouldFit and rebalance as part...

2017-12-19 Thread govind-menon
Github user govind-menon closed the pull request at: https://github.com/apache/storm/pull/2456 ---

[GitHub] storm issue #2468: [STORM-2690] resurrect invocation of ISupervisor.assigned...

2017-12-19 Thread erikdw
Github user erikdw commented on the issue: https://github.com/apache/storm/pull/2468 @ptgoetz : I've created PRs for the branches: * [`1.0.x-branch`](https://github.com/apache/storm/pull/2470) * [`1.1.x-branch`](https://github.com/apache/storm/pull/2471) * [`1.x-branch`](htt

[GitHub] storm pull request #2471: [STORM-2690] resurrect invocation of ISupervisor.a...

2017-12-19 Thread erikdw
GitHub user erikdw opened a pull request: https://github.com/apache/storm/pull/2471 [STORM-2690] resurrect invocation of ISupervisor.assigned() & make Supervisor.launchDaemon() accessible This commit fixes the storm-mesos integration for the interaction between the Storm core's Sup

[GitHub] storm pull request #2472: [STORM-2690] resurrect invocation of ISupervisor.a...

2017-12-19 Thread erikdw
GitHub user erikdw opened a pull request: https://github.com/apache/storm/pull/2472 [STORM-2690] resurrect invocation of ISupervisor.assigned() & make Supervisor.launchDaemon() accessible This commit fixes the storm-mesos integration for the interaction between the Storm core's Sup

[GitHub] storm pull request #2470: [STORM-2690] resurrect invocation of ISupervisor.a...

2017-12-19 Thread erikdw
GitHub user erikdw opened a pull request: https://github.com/apache/storm/pull/2470 [STORM-2690] resurrect invocation of ISupervisor.assigned() & make Supervisor.launchDaemon() accessible This commit fixes the storm-mesos integration for the interaction between the Storm core's Sup

[GitHub] storm issue #2442: STORM-2837: ConstraintSolverStrategy

2017-12-19 Thread jerrypeng
Github user jerrypeng commented on the issue: https://github.com/apache/storm/pull/2442 @revans2 thanks for the explanantion ---

[GitHub] storm issue #2442: STORM-2837: ConstraintSolverStrategy

2017-12-19 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2442 @jerrypeng TOPOLOGY_RAS_CONSTRAINT_MAX_STATE_SEARCH is not an effective limit on the max stack depth. The max stack depth is the number of bolt and spout instances in a topology. If we want to limi

[GitHub] storm issue #2468: [STORM-2690] resurrect invocation of ISupervisor.assigned...

2017-12-19 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2468 @erikdw Excellent! Thanks bringing this up and helping solve the issue. ---

[GitHub] storm issue #2442: STORM-2837: ConstraintSolverStrategy

2017-12-19 Thread jerrypeng
Github user jerrypeng commented on the issue: https://github.com/apache/storm/pull/2442 LGTM +1. @revans2 up to you if you want to do something more about whether those warnings should dealt with in a more serious manner ---

[GitHub] storm issue #2442: STORM-2837: ConstraintSolverStrategy

2017-12-19 Thread jerrypeng
Github user jerrypeng commented on the issue: https://github.com/apache/storm/pull/2442 @revans2 Sorry for not being more clear about what I meant in regards to using the heap instead of stack space. Currently, the algorithm uses recursion to backtrack which means it is going to use

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157842966 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/internal/OffsetManagerTest.java --- @@ -55,12 +58,12 @@ public void testSkipM

[GitHub] storm issue #2468: [STORM-2690] resurrect invocation of ISupervisor.assigned...

2017-12-19 Thread erikdw
Github user erikdw commented on the issue: https://github.com/apache/storm/pull/2468 @ptgoetz : yep! I've been testing on `1.0.x-branch`. I can send PRs for all the active main branches (`1.0.x-branch`, `1.1.x-branch`, `1.x-branch`). ---

[GitHub] storm issue #2468: [STORM-2690] resurrect invocation of ISupervisor.assigned...

2017-12-19 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2468 +1 @erikdw Are you planning to port to earlier branches? ---

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157831266 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -204,33 +226,70 @@ private void initialize(Collection

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157831079 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -115,26 +115,30 @@ public KafkaSpoutConfig(Builde

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157831049 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -115,26 +115,30 @@ public KafkaSpoutConfig(Builde

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157816130 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -115,26 +115,30 @@ public KafkaSpoutConfig(Builde

[GitHub] storm issue #2442: STORM-2837: ConstraintSolverStrategy

2017-12-19 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2442 @jerrypeng I reverted the one rename you asked about and rebased to fix a merge conflict. I also squashed because I thought we were really close on this. I don't understand your comment abou

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157809222 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -115,26 +115,30 @@ public KafkaSpoutConfig(Builde

[GitHub] storm pull request #2442: STORM-2837: ConstraintSolverStrategy

2017-12-19 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2442#discussion_r157803142 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/multitenant/NodePool.java --- @@ -98,7 +98,7 @@ public RoundRobinSlotScheduler(TopologyDetai

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157726005 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -204,33 +226,70 @@ private void initialize(Collection

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157734918 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/MaxUncommittedOffsetTest.java --- @@ -71,6 +75,10 @@ 1, Kafk

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157737965 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/OffsetAndMetadataMocks.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the Apa

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157735621 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/OffsetAndMetadataMocks.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the Apa

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157728758 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -115,26 +115,30 @@ public KafkaSpoutConfig(Builde

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157728822 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -115,26 +115,30 @@ public KafkaSpoutConfig(Builde

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157728469 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -115,26 +115,30 @@ public KafkaSpoutConfig(Builde

[GitHub] storm pull request #2465: STORM-2844: KafkaSpout Throws IllegalStateExceptio...

2017-12-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2465#discussion_r157735221 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/internal/OffsetManagerTest.java --- @@ -55,12 +58,12 @@ public void testSkipM

[GitHub] storm pull request #2469: STORM-2861: Explicit reference kafka-schema-regist...

2017-12-19 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/2469 STORM-2861: Explicit reference kafka-schema-registry-client https://issues.apache.org/jira/browse/STORM-2861 You can merge this pull request into a Git repository by running: $ git pull https:/

[GitHub] storm pull request #2445: STORM-2843: [Flux] properties file not found when ...

2017-12-19 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/2445#discussion_r157729717 --- Diff: flux/flux-core/src/main/java/org/apache/storm/flux/parser/FluxParser.java --- @@ -39,51 +39,57 @@ private FluxParser(){} -