[GitHub] storm pull request #2493: [STORM-2879] Supervisor collapse continuously when...

2018-01-02 Thread danny0405
GitHub user danny0405 opened a pull request: https://github.com/apache/storm/pull/2493 [STORM-2879] Supervisor collapse continuously when there is a expired assignment for overdue storm We do not make a transaction when supervisor clean up local files for a overdue storm, if an

[GitHub] storm pull request #2492: Update TridentKafkaEmitter.java

2018-01-02 Thread dujiashu
GitHub user dujiashu opened a pull request: https://github.com/apache/storm/pull/2492 Update TridentKafkaEmitter.java fix fetchmessages offsetoutofrange bug. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dujiashu/storm master

[GitHub] storm issue #2491: STORM-2872: TestRebalance can be flaky - fixing

2018-01-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2491 Storm project has by-laws which we disallow merging patch in 1 day from initial patch. (unless the patch is non-code change) http://storm.apache.org/contribute/BYLAWS.html ---

Re: Ask for review on Storm 2.0.0 items

2018-01-02 Thread Jungtaek Lim
Yes, with one correction: windowed processing has been already existed on Storm 1.0.0, so that's not a new feature. http://storm.apache.org/releases/1.1.1/Windowing.html - Jungtaek Lim (HeartSaVioR) 2018년 1월 2일 (화) 오후 8:27, Alexandre Vermeerbergen 님이 작성: > Hello All, >

[GitHub] storm pull request #2467: STORM-2860: Add Kerberos support to Solr bolt

2018-01-02 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2467#discussion_r159340988 --- Diff: external/storm-solr/README.md --- @@ -97,6 +97,29 @@ field separates each value with the token % instead of the default | . To use th

[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...

2018-01-02 Thread kishorvpatil
Github user kishorvpatil commented on the issue: https://github.com/apache/storm/pull/2487 Ok. I will create the PR for 1.x-branch. ---

[GitHub] storm issue #2491: STORM-2872: TestRebalance can be flaky - fixing

2018-01-02 Thread govind-menon
Github user govind-menon commented on the issue: https://github.com/apache/storm/pull/2491 @HeartSaVioR May this be merged? ---

[GitHub] storm issue #2490: STORM-2840: Getting resource availability from pre-GRAS s...

2018-01-02 Thread govind-menon
Github user govind-menon commented on the issue: https://github.com/apache/storm/pull/2490 @HeartSaVioR May this be merged? ---

[GitHub] storm pull request #2491: STORM-2872: TestRebalance can be flaky - fixing

2018-01-02 Thread govind-menon
GitHub user govind-menon opened a pull request: https://github.com/apache/storm/pull/2491 STORM-2872: TestRebalance can be flaky - fixing You can merge this pull request into a Git repository by running: $ git pull https://github.com/govind-menon/storm YSTORM-4457-II

[GitHub] storm issue #2487: [STORM-2873] Do not delete backpressure ephemeral node fr...

2018-01-02 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2487 @kishorvpatil could you put up a pull request to 1.x for this? ---

[GitHub] storm pull request #2486: STORM-2856: Make Storm build work on post-2017Q4 T...

2018-01-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2486 ---

[GitHub] storm pull request #2456: STORM-2872: Fix for wouldFit and rebalance as part...

2018-01-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2456 ---

[GitHub] storm issue #2480: STORM-2867: Add consumer lag metrics to KafkaSpout

2018-01-02 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2480 @omkreddy This LGTM. Could you open a PR against master as well, we usually put features on that branch before merging to the other versions? ---

[GitHub] storm pull request #2490: STORM-2840: Getting resource availability from pre...

2018-01-02 Thread govind-menon
GitHub user govind-menon opened a pull request: https://github.com/apache/storm/pull/2490 STORM-2840: Getting resource availability from pre-GRAS supervisors You can merge this pull request into a Git repository by running: $ git pull https://github.com/govind-menon/storm

Re: Ask for review on Storm 2.0.0 items

2018-01-02 Thread Alexandre Vermeerbergen
Hello All, Thank you very much for your answers. To sum up, here's my understanding of Storm 2.0.0 upcoming features related to my questions: * Even if Storm 2.0.0 won't be the same as JStorm, we're going to have at least: - a rewrite of existing Closure source in Java - not exactly a

[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...

2018-01-02 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2365 Hi,@revans2,I'm not sure whether the ci's failure related to me.And I have add a retry to DRPCInvaction,could you help me to review it? ---