Re: [VOTE] Release Apache Storm 1.2.0 (rc4)

2018-02-10 Thread Alexandre Vermeerbergen
Hello, +1 (non binding) Details: I almost got nuts when applying storm-kafka-client-1.2.0 RC4 to our preproduction Storm cluster whose performances dropped quite a lot (at least x2 less throughput) ... but then I realized that I made the classic mistake of mixing two changes : I had also upgrade

[GitHub] storm pull request #2502: new PR for STORM-2306 : Messaging subsystem redesi...

2018-02-10 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2502#discussion_r167402753 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/BackPressureStatus.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

Re: [VOTE] Release Apache Storm 1.2.0 (rc4)

2018-02-10 Thread Stig Rohde Døssing
Alexandre, The warning you noted is just saying that enable.auto.commit is not supported and you should use ProcessingGuarantee.NO_GUARANTEE instead. The method logging that warning also sets the guarantee to NO_GUARANTEE, so I don't expect you to see any difference between enable.auto.commit=true