Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2433
@danny0405 the changes look good, the conflicts are minimal and I think the
test failures are spurious. I am +1 for merging this in. Please rebase/squash
the commits, resolve the minor conflicts
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2433
@danny0405 Sorry about how long this has taken. I am back from vacation
now. I will take a look at the patch again, and if the conflicts are small
hopefully we can merge it in today or tomorrow.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2608
@agresch This change makes sure that the responses won't contain any
`null` HBMessage. So I think this should be fine.
---
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2608
Seems ok to me. I might also add handling null to
PaceMakerStateStorage.java#L195.
---
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2608
[STORM-3012] Fix the issue that nimbus will crash if pacemaker is restarted
by returning results from resending HBMessage
Detailed explanation at
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/2607
STORM-3011 Use default bin path in flight.bash if $JAVA_HOME is undefined
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jnioche/storm
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2433
@danny0405
I assume @revans2 is on vacation, so you may want to take your time to
handle other tasks for now, and back to this issue when @revans2 is back. Looks
like he would like to
