[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2433 FYI: The test failure looks like unrelated to this change. https://travis-ci.org/apache/storm/jobs/359434070 This build has same failure but the build is triggered before this patch is

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2433 Late +1. FYI: The test looks like failing intermittently, not consistently. I've seen succeed build in my fork. https://travis-ci.org/HeartSaVioR/storm/builds/359567639 We

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2433 ---

[GitHub] storm issue #2609: STORM-3011 Use default bin path in flight.bash if JAVA_HO...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2609 +1 ---

[GitHub] storm issue #2596: [STORM-3004] storm-elasticsearch-examples: fixed all chec...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2596 @krichter722 Thanks, merged to master. I also added you to the contributors list in JIRA, so you should be able to assign tasks to yourself now. ---

[GitHub] storm pull request #2596: [STORM-3004] storm-elasticsearch-examples: fixed a...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2596 ---

[GitHub] storm issue #2596: [STORM-3004] storm-elasticsearch-examples: fixed all chec...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2596 +1, thanks for being patient. @krichter722 could you add the issue number to the commit message, I'll merge after that. I'd add it myself, but then the PR won't show as merged. ---

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2433 I am +1, but a little nervous that the tests are failing consistently on travis in exactly the same way, but never on my laptop, but I think we can work that out later if it is a real issue. ---

[GitHub] storm issue #2603: [STORM-3003] Adding Assignment caching to Nimbus

Github user kishorvpatil commented on the issue: https://github.com/apache/storm/pull/2603 @HeartSaVioR Sure. Let me review #2433. In the meantime, I will create patch for 1.x-branch. ---

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2433 @HeartSaVioR I have applied you suggestions and it worked as desired, thx very much. ---

[GitHub] storm issue #2592: STORM-2993: Storm HDFS bolt throws ClosedChannelException...

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2592 @HeartSaVioR , thanks for reviewing. Raised https://github.com/apache/storm/pull/2610 for master. ---

[GitHub] storm pull request #2610: STORM-2993: Storm HDFS bolt throws ClosedChannelEx...

GitHub user arunmahadevan opened a pull request: https://github.com/apache/storm/pull/2610 STORM-2993: Storm HDFS bolt throws ClosedChannelException when Time rotation policy is used The TimedRotation should synchronize so that the bolt does not attempt to write to a stale writer.

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2433 @danny0405 You may also want to make sure the squashed commit contains full diff via comparing contents of commit with PR diff. Once line count goes similar and UTs / manual tests work it

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2433 @danny0405 There's a tip regarding supported features on Github: you can get a patch file which contains commits or a full diff file. Just add ".patch" for former, or add ".diff" for

[GitHub] storm issue #2433: [STORM-2693] Heartbeats and assignments promotion for sto...

Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2433 @revans2 @HeartSaVioR I have merged master in and fixed the conflicts. I tried to rebase based on master but there are too much conflicts and it's even harder to pick out which code

[GitHub] storm issue #2597: [STORM-3007] storm-mqtt-examples: fixed all checkstyle wa...

Github user krichter722 commented on the issue: https://github.com/apache/storm/pull/2597 Requested changes incorporated. Thanks for the review. ---

[GitHub] storm pull request #2597: [STORM-3007] storm-mqtt-examples: fixed all checks...

Github user krichter722 commented on a diff in the pull request: https://github.com/apache/storm/pull/2597#discussion_r177723827 --- Diff: examples/storm-mqtt-examples/src/main/java/org/apache/storm/mqtt/examples/CustomMessageMapper.java --- @@ -15,35 +15,77 @@ * See the

[GitHub] storm issue #2596: [STORM-3004] storm-elasticsearch-examples: fixed all chec...

Github user krichter722 commented on the issue: https://github.com/apache/storm/pull/2596 Last comments incorporated. ---

[GitHub] storm issue #2593: STORM-2994 KafkaSpout commit offsets for null tuples

Github user reiabreu commented on the issue: https://github.com/apache/storm/pull/2593 Hi folks! I won't have access to a computer until next weekend. I'll pick it up then. Thank you for understanding On Wed, 28 Mar 2018, 08:15 Jungtaek Lim,

[GitHub] storm issue #2603: [STORM-3003] Adding Assignment caching to Nimbus

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2603 @kishorvpatil Could we hold on this for #2433 since #2433 is making huge change on relevant part? It would be really great if you have time to take a look at #2433 and check the conflict

[GitHub] storm pull request #2597: [STORM-3007] storm-mqtt-examples: fixed all checks...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2597#discussion_r177716685 --- Diff: examples/storm-mqtt-examples/src/main/java/org/apache/storm/mqtt/examples/MqttBrokerPublisher.java --- @@ -15,35 +15,62 @@ * See the

[GitHub] storm pull request #2597: [STORM-3007] storm-mqtt-examples: fixed all checks...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2597#discussion_r177715753 --- Diff: examples/storm-mqtt-examples/src/main/java/org/apache/storm/mqtt/examples/CustomMessageMapper.java --- @@ -15,35 +15,77 @@ * See the

[GitHub] storm pull request #2597: [STORM-3007] storm-mqtt-examples: fixed all checks...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2597#discussion_r177716911 --- Diff: examples/storm-mqtt-examples/src/main/java/org/apache/storm/mqtt/examples/MqttBrokerPublisher.java --- @@ -15,35 +15,62 @@ * See the

[GitHub] storm issue #2596: [STORM-3004] storm-elasticsearch-examples: fixed all chec...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2596 @krichter722 kindly reminder. ---

[GitHub] storm issue #2594: storm-kafka: encapsulated Broker.host and port

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2594 I second @srdo, and we'd better to handle removal of storm-kafka sooner to avoid such case. ---

[GitHub] storm issue #2593: STORM-2994 KafkaSpout commit offsets for null tuples

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2593 @reiabreu kindly reminder. ---

[GitHub] storm issue #2592: STORM-2993: Storm HDFS bolt throws ClosedChannelException...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2592 @arunmahadevan Could we have a patch for master branch as well? ---

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r177594095 --- Diff: storm-client/src/jvm/org/apache/storm/assignments/ILocalAssignmentsBackend.java --- @@ -26,7 +26,7 @@ /** * Interface for storing

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r177711557 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -42,16 +42,44 @@ public interface IStormClusterState {

[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2433#discussion_r177712003 --- Diff: storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java --- @@ -299,6 +299,8 @@ private Scope calculateScope(Map

[GitHub] storm issue #2583: STORM-2649 More detailed check of config serialization

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2583 @ghajos kindly reminder. ---

[GitHub] storm issue #2607: STORM-3011 Use default bin path in flight.bash if $JAVA_H...

Github user jnioche commented on the issue: https://github.com/apache/storm/pull/2607 thanks, see #2609 ---

[GitHub] storm pull request #2609: STORM-3011 Use default bin path in flight.bash if ...

GitHub user jnioche opened a pull request: https://github.com/apache/storm/pull/2609 STORM-3011 Use default bin path in flight.bash if JAVA_HOME is undefined port of #2607 to master branch You can merge this pull request into a Git repository by running: $ git pull