[GitHub] storm pull request #2518: STORM-2902: Some improvements for storm-rocketmq m...

Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/2518#discussion_r178704108 --- Diff: external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/RocketMqConfig.java --- @@ -23,28 +23,20 @@ import java.util.Properties;

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user vesense commented on the issue: https://github.com/apache/storm/pull/2518 @vongosling Added unit tests and rebased PR. ---

[GitHub] storm pull request #2618: [STORM-2905] Fix KeyNotFoundException when kill a ...

Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2618#discussion_r178693115 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/LocalizedResourceRetentionSet.java --- @@ -94,17 +93,17 @@ public void

[GitHub] storm issue #2618: [STORM-2905] Fix KeyNotFoundException when kill a storm a...

Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2618 @revans2 I did this path for the concurrent race condition on `AsyncLocalize#topologyBlobs` of func: `updateBlobs` and `releaseSlotFor`, `AsyncLocalize#topologyBlobs` overdue keys will be

[GitHub] storm pull request #2618: [STORM-2905] Fix KeyNotFoundException when kill a ...

Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2618#discussion_r178692521 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java --- @@ -497,7 +497,6 @@ static DynamicState

[GitHub] storm issue #2613: .NET Core 2.0 multi-lang adapter

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2613 @oizu @MaurGi Hello Azure team, please follow up the Storm developer mailing list since such discussion is taking place. If you're not subscribing dev mailing list, here's a link for

Re: Storm multilang - .net core

+1 I think that’s a good idea. It would also help to have some wording regarding how one requests a project be added to that page. -Taylor > On Apr 2, 2018, at 10:03 AM, Stig Rohde Døssing > wrote: > > Sorry about necro'ing this thread, but I think this is relevant

[GitHub] storm issue #2593: STORM-2994 KafkaSpout doesn't commit null tuples offsets

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2593 +1, thanks for your patience. Please squash to one commit, and we can merge. ---

[GitHub] storm issue #2583: STORM-2649 More detailed check of config serialization

Github user ghajos commented on the issue: https://github.com/apache/storm/pull/2583 @srdo @HeartSaVioR @revans2 Thank you for the review and the patience! ---

[GitHub] storm issue #2613: .NET Core 2.0 multi-lang adapter

Github user MaurGi commented on the issue: https://github.com/apache/storm/pull/2613 Hello - we are proposing a new multilang adapter for .net core - this is in the storm-multilang/dotnet folder - In the folder we have a dotnet project for the adapter and then a dotnet project

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

Github user reiabreu commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178586564 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutNullTupleTest.java --- @@ -0,0 +1,76 @@ +/* + *

[GitHub] storm issue #2618: [STORM-2905] Fix KeyNotFoundException when kill a storm a...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2618 I am trying to understand the reasons behind this change. Is this jira just to remove an exception that shows up in the logs? Or is that exception actually causing a problem? The reason I

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178571304 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutNullTupleTest.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178571949 --- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutNullTupleTest.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to

[GitHub] storm issue #2593: STORM-2994 KafkaSpout commit offsets for null tuples

Github user reiabreu commented on the issue: https://github.com/apache/storm/pull/2593 KafkaSpoutAbstractTest is tightly coupled to KafkaSpoutConfig through createSpoutConfig, meaning that to test a single configuration change, we need to create a new test class. This is something

[GitHub] storm pull request #2618: [STORM-2905] Fix KeyNotFoundException when kill a ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2618#discussion_r178568732 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/LocalizedResourceRetentionSet.java --- @@ -94,17 +93,17 @@ public void

[GitHub] storm pull request #2618: [STORM-2905] Fix KeyNotFoundException when kill a ...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2618#discussion_r178567096 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Slot.java --- @@ -497,7 +497,6 @@ static DynamicState

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178562679 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -570,20 +572,25 @@ public void ack(Object messageId) {

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

Github user reiabreu commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178559146 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -570,20 +572,25 @@ public void ack(Object

[GitHub] storm pull request #2583: STORM-2649 More detailed check of config serializa...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2583 ---

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178551488 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -570,20 +572,25 @@ public void ack(Object messageId) {

Re: Storm multilang - .net core

Sorry about necro'ing this thread, but I think this is relevant again, due to https://github.com/apache/storm/pull/2613. I think it makes more sense to have adapters like this in separate repositories from Storm, as they can then release fixes when they need to, without being coupled to the Storm

[GitHub] storm pull request #2612: STORM-3015: Remove kafka_2.10 dependency from stor...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2612 ---

[GitHub] storm pull request #2619: [STORM-3018] Fix integration test DemoTest#testExc...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2619 ---

[GitHub] storm pull request #2583: STORM-2649 More detailed check of config serializa...

Github user ghajos commented on a diff in the pull request: https://github.com/apache/storm/pull/2583#discussion_r178527233 --- Diff: storm-client/test/jvm/org/apache/storm/utils/UtilsTest.java --- @@ -173,4 +176,49 @@ public void

[GitHub] storm issue #2583: STORM-2649 More detailed check of config serialization

Github user ghajos commented on the issue: https://github.com/apache/storm/pull/2583 Sorry for the late reply! ---

[GitHub] storm pull request #2593: STORM-2994 KafkaSpout commit offsets for null tupl...

Github user reiabreu commented on a diff in the pull request: https://github.com/apache/storm/pull/2593#discussion_r178510737 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -484,8 +484,11 @@ private boolean

[GitHub] storm issue #2591: STORM-2979: WorkerHooks EOFException during run_worker_sh...

Github user hummelm commented on the issue: https://github.com/apache/storm/pull/2591 Yes i Will add a list of deserialized hook into the worker and use it to start.stop. ---