[GitHub] storm issue #2647: STORM-3040: Improve scheduler performance

2018-04-26 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2647 @revans2 In total, this is a good promotion direction. So this promotion mainly focus on repetitive computation and some eagerly computed data structure, right? What is the

[GitHub] storm issue #2646: [YSTORM-4915] AutoTGT should check if a TGT is address-le...

2018-04-26 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2646 The failures should be unrelated. The build succeeded on my repo https://travis-ci.org/Ethanlm/storm/builds/371698263 ---

[GitHub] storm pull request #2641: [STORM-3037] Lowering CheckStyle Violations across...

2018-04-26 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2641#discussion_r184525490 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/BlobStoreAPIWordCountTopology.java --- @@ -38,176 +47,66 @@ import

[GitHub] storm pull request #2641: [STORM-3037] Lowering CheckStyle Violations across...

2018-04-26 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2641#discussion_r184525138 --- Diff: examples/storm-perf/src/main/java/org/apache/storm/perf/utils/MetricsSample.java --- @@ -160,7 +159,7 @@ private static MetricsSample

[GitHub] storm pull request #2641: [STORM-3037] Lowering CheckStyle Violations across...

2018-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2641 ---

[GitHub] storm issue #2641: [STORM-3037] Lowering CheckStyle Violations across all mo...

2018-04-26 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2641 Still +1 ---

[GitHub] storm pull request #2647: STORM-3040: Improve scheduler performance

2018-04-26 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2647 STORM-3040: Improve scheduler performance There are a lot of different scheduler improvements. Mostly these are either caching, storing data in multiple ways so we can look it up quickly, and

[GitHub] storm pull request #2646: [YSTORM-4915] AutoTGT should check if a TGT is add...

2018-04-26 Thread Ethanlm
GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2646 [YSTORM-4915] AutoTGT should check if a TGT is address-less and reject if it's not https://issues.apache.org/jira/browse/STORM-3044 You can merge this pull request into a Git repository

[GitHub] storm pull request #2645: STORM-3042 fix acker and metric component resource...

2018-04-26 Thread agresch
GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2645 STORM-3042 fix acker and metric component resource requests You can merge this pull request into a Git repository by running: $ git pull https://github.com/agresch/storm agresch_storm3042

[GitHub] storm issue #2636: 1.1.x branch - Add SSL functionality

2018-04-26 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2636 @cfriaszapater The failure is because the integration test POM is pointing at Storm 1.2.0-SNAPSHOT, but this branch has Storm at version 1.1.3-SNAPSHOT. You should be able to just replace the version

[GitHub] storm issue #2642: Fix NullPointerException when apply() returns null

2018-04-26 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2642 @cleroux Thanks for the fix. The change looks good to me. Please raise an issue at https://issues.apache.org/jira/secure/Dashboard.jspa, and include the issue number in the PR title and the commit

[GitHub] storm issue #2640: [STORM-3036] Add isRemoteBlobExists RPC interface for dec...

2018-04-26 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2640 @revans2 Can you help me to reivew this patch? ---

[GitHub] storm pull request #2636: 1.1.x branch - Add SSL functionality

2018-04-26 Thread cfriaszapater
Github user cfriaszapater commented on a diff in the pull request: https://github.com/apache/storm/pull/2636#discussion_r184284475 --- Diff: external/storm-cassandra/src/main/java/org/apache/storm/cassandra/client/ClusterFactory.java --- @@ -67,7 +83,57 @@ protected Cluster