Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2647
@revans2
Thx for your work, the storm-core travis check still fails, we should fix
that.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2667#discussion_r186888587
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
true
+
+
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2667
+1
---
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2667#discussion_r186887493
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
true
+
+
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2667
STORM-3063: Fix minor pom issues
https://issues.apache.org/jira/browse/STORM-3063
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2665
@ptgoetz @dbist
I'm OK to go ahead assuming it is normal to run JmxReporter without
additional options. But please sort out options as I commented earlier. It
makes no sense to mix up
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2664
I think if we can shade all the storm-druid dependencies we could probably
leave it there.
At-least a few of the other storm connectors have not been updated in a
while but we still keep
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2664
Got a response
https://lists.apache.org/thread.html/22fa072edfdcb5a2fdb06e8c99daf8b2635da78e87c28e72b332ac0e@%3Cdev.druid.apache.org%3E.
Sounds like Kafka is the recommended way to ingest into Druid,
Github user dbist commented on the issue:
https://github.com/apache/storm/pull/2665
doc update jira is https://issues.apache.org/jira/browse/STORM-3062
please review this PR and 2666 for branch 2 fix.
---
Github user dbist commented on the issue:
https://github.com/apache/storm/pull/2665
@ptgoetz you've read my mind, this fix is holding up a release and I can
work on the separate jira to address the doc, not a problem. We can target that
for next release.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2664
Lets wait for a response. I think we can add some notes saying that
storm-druid is deprecated and shade its dependencies than completely removing
it since there are some users using it. This
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2664
I sent them an email here
https://lists.apache.org/thread.html/4114eb25ff1e570927aa283c4127f8c83fb3bbee631ddebeee729f4c@%3Cdev.druid.apache.org%3E.
I think if it turns out that Tranquility is
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2664
@revans2 thanks for understanding the concerns and agree that we should do
something about the long term support for tranquility. We can probably poke
them like @srdo suggested to get out a
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2665
@HeartSaVioR Agreed, but those issues can be addressed outside the scope of
this bug (i.e. separate JIRA). For now we should focus on getting this fix in
since it is currently holding up the
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2665
We should add docs and an example usage in the storm.yaml.example (which
has graphite and console). @dbist will be great if you address this for
JMXStormReporter as a part of this PR.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2637
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2637
+1
@srishtyagrawal thank you for your nice and helpful contribution. It will
benefit a lot of users.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2664
@arunmahadevan and @srdo
https://issues.apache.org/jira/browse/STORM-2882 is for adding back in
shading to the storm client. I am happy to take that up next. My real concern
is the long
Github user revans2 closed the pull request at:
https://github.com/apache/storm/pull/2664
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2664
I think shading Curator in storm-druid seems like the best option, and
maybe poking a bit at the Druid guys to get a release of Tranquility out. If it
turns out that they are dropping Tranquility
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2647
@danny0405 I added in the comments about thread safety like you suggested.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2647#discussion_r186756808
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -763,6 +773,7 @@ public void setAssignments(
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2647#discussion_r186754134
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -48,6 +49,9 @@
public class Cluster implements
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2647#discussion_r186665919
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -763,6 +773,7 @@ public void setAssignments(
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2647#discussion_r186665266
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java ---
@@ -48,6 +49,9 @@
public class Cluster implements
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2647
@revans2
I approve with you promotion totally.
The only concern are all kinds of cache we use here, now storm has many
caches not just for scheduling. I just think if we can make a
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2665
@arunmahadevan @ptgoetz
Let's "reuse all" or "duplicate all", not reuse some of them partially. And
let's leave explanation on JmxStormReporter, since there's no explanation on
27 matches
Mail list logo
