Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2703
Sorry i don't think put the validation at Client side is a good idea, cause
many kind of clients may interact with Master through thrift RPC, we must keep
all the clients sync on this validation
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2704
@srdo
Great work, i will take my time to review this patch as soon as possible.
---
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193270523
--- Diff: pom.xml ---
@@ -109,7 +109,7 @@
Committer
-
+
Github user danny0405 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2704#discussion_r193270487
--- Diff: pom.xml ---
@@ -82,7 +82,7 @@
Committer
-
+
GitHub user agresch opened a pull request:
https://github.com/apache/storm/pull/2705
STORM-3096 prevent race condition during topology submission
My previous attempt at fixing this addressed the race in
store.storedTopoIds(). But state.idsOfTopologiesWithPrivateWorkerKeys() will
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2704
STORM-1038: Upgrade to Netty 4
This is a continuation of the work done at
https://github.com/apache/storm/pull/728.
### Important changes:
* Split MessageEncoder into multiple encoders
GitHub user ManoharVanam opened a pull request:
https://github.com/apache/storm/pull/2703
[STORM-3094] : Added topology name validation at client side
Current Behavior : Execute topology with invalid topology name is throwing
exception after uploading the jar.
Improvement
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2702
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2701
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2698
All I did was build/run the unit tests and this time I was able to get
everything to pass. Oddly I was able to compile all of the code without
jaxb-api but I could not run the tests...
I
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2698
Just so you don't spend too much time on it, neither HBase nor Cassandra
work with Java 9 right now. I skipped those modules when testing it last year.
Also I didn't get farther than building and
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2698
I addressed everything except for jaxb. Because it is for java9 I will
download a java9 JDK and work on that to make sure it works there too, so it
might be a little longer.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193104685
--- Diff: storm-core/pom.xml ---
@@ -193,10 +193,6 @@
curator-framework
compile
-
--- End diff
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193103356
--- Diff:
storm-server/src/main/java/org/apache/storm/testing/InProcessZookeeper.java ---
@@ -12,15 +12,16 @@
package org.apache.storm.testing;
CVE-2018-8008: Apache Storm arbitrary file write vulnerability
Severity: Important
Vendor:
The Apache Software Foundation
Versions Affected:
Apache Storm 1.2.1
Apache Storm 1.1.2
Description:
Apache Storm version 1.0.6 and earlier, 1.2.1 and earlier, and version 1.1.2
and earlier expose an
CVE-2018-1332: Apache Storm user impersonation vulnerability
Severity: Important
Vendor:
The Apache Software Foundation
Versions Affected:
Apache Storm 1.2.1
Apache Storm 1.1.2
Description:
Apache Storm version 1.0.6 and earlier, 1.2.1 and earlier, and version 1.1.2
and earlier expose a
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193090616
--- Diff:
storm-server/src/main/java/org/apache/storm/testing/InProcessZookeeper.java ---
@@ -12,15 +12,16 @@
package org.apache.storm.testing;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193089630
--- Diff: storm-core/pom.xml ---
@@ -193,10 +193,6 @@
curator-framework
compile
-
--- End
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193084777
--- Diff:
storm-client/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java ---
@@ -54,8 +55,8 @@ public static String exec(String cmd) throws
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193081199
--- Diff:
storm-client/test/jvm/org/apache/storm/security/auth/ClientAuthUtilsTest.java
---
@@ -172,59 +178,47 @@ public void makeDigestPayloadTest()
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193080442
--- Diff: shaded-deps/pom.xml ---
@@ -0,0 +1,272 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193080453
--- Diff:
storm-client/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java ---
@@ -54,8 +55,8 @@ public static String exec(String cmd) throws
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193078809
--- Diff: shaded-deps/pom.xml ---
@@ -0,0 +1,272 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193077896
--- Diff: shaded-deps/pom.xml ---
@@ -0,0 +1,272 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193077799
--- Diff: shaded-deps/pom.xml ---
@@ -0,0 +1,272 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user agresch commented on the issue:
https://github.com/apache/storm/pull/2701
@revans2 - fixed the javadoc
---
26 matches
Mail list logo
