GitHub user mal opened a pull request:
https://github.com/apache/storm/pull/2782
STORM-3164: Fix usage of traceback.format_exc in multilang (backport)
Backport to 1.x.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mal/storm
GitHub user mal opened a pull request:
https://github.com/apache/storm/pull/2781
STORM-3163: Make ShellBolt logger setup calls occur in-thread to support
MDC (BACKPORT)
Backport to 1.x.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user mal opened a pull request:
https://github.com/apache/storm/pull/2780
STORM-3164: Fix usage of traceback.format_exc in multilang
Misuse of `traceback.format_exc` was causing exceptions thrown in python
bolts to throw `TypeError`s during attempts to handle them. Fixing
GitHub user mal opened a pull request:
https://github.com/apache/storm/pull/2779
STORM-3163: Make ShellBolt logger thread local to support MDC
Prior to this the logger set up and use would occur in separate threads,
so any MDC values would not persist from set up, by using the
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2772
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2775
Thanks @hmcl for providing the patch. Merged into master.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2775
---
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2773#discussion_r205973135
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/LocalFsBlobStore.java ---
@@ -197,7 +198,7 @@ public void run() {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2773#discussion_r205973204
--- Diff:
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
@@ -191,6 +192,8 @@ public static boolean
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2778
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2778
@srdo Thanks for the review. Since this is a patch for backport I'll skip
waiting 24hrs for this.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2714
@zd-project I think the Enum idea sounds nice, but I'm not sure whether it
will be so easy to implement. Some metrics depend on state in the class they're
declared, e.g. the two gauges in Container.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2778
+1, thanks for backporting.
---
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2778#discussion_r205965687
--- Diff: storm-core/test/resources/log4j2-test.xml ---
@@ -25,7 +25,8 @@
-
+
--- End
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2778#discussion_r205965554
--- Diff: storm-core/test/resources/log4j2-test.xml ---
@@ -25,7 +25,8 @@
-
+
--- End diff --
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2778
https://travis-ci.org/HeartSaVioR/storm/jobs/409469987 (passed)
https://travis-ci.org/HeartSaVioR/storm/jobs/409469988 (passed)
https://travis-ci.org/apache/storm/jobs/409470450
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2778#discussion_r205964723
--- Diff: storm-core/test/clj/org/apache/storm/metrics_test.clj ---
@@ -15,16 +15,14 @@
;; limitations under the License.
(ns
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2778
(1.x) STORM-3121: Fix flaky metrics tests in storm-core
This ports back #2735 to 1.x-branch since I can see flaky metrics tests
from 1.x-branch.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2777
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2776
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2711
Looks like the build still fails and relevant to this patch.
---
21 matches
Mail list logo
