[GitHub] storm pull request #2842: STORM-3229: Add in better error reporting

2018-09-18 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2842 STORM-3229: Add in better error reporting You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm STORM-3229 Alternatively

Re: Regarding releasing Apache Storm 2.0.0

2018-09-18 Thread P. Taylor Goetz
I’m ready to release when everything is ready to go. Since we haven’t released from the 2.0-based master branch, I wouldn’t be surprised if I run into release issues, but I’ll slog through it. -Taylor > On Sep 18, 2018, at 10:46 AM, Bobby Evans wrote: > > Great work everyone. We are really

[GitHub] storm issue #2841: STORM-3105: upgrade version of hive

2018-09-18 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2841 The build failures look like issues with downloading the JDK/slowness in travis. https://travis-ci.org/revans2/incubator-storm/builds/430134233 is my version that passed. ---

[GitHub] storm pull request #2839: STORM-3228 allow refernce counting of differing Po...

2018-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2839 ---

[GitHub] storm issue #2839: STORM-3228 allow refernce counting of differing PortAndAs...

2018-09-18 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2839 Actually these are all comments so I'll just take care of it on checkin. ---

[GitHub] storm pull request #2839: STORM-3228 allow refernce counting of differing Po...

2018-09-18 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2839#discussion_r218564458 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/TimePortAndAssignment.java --- @@ -48,4 +48,29 @@ public LocalAssignment getAssignment() {

[GitHub] storm pull request #2839: STORM-3228 allow refernce counting of differing Po...

2018-09-18 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2839#discussion_r218564297 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/PortAndAssignmentImpl.java --- @@ -45,14 +48,17 @@ public String getOwner() {

[GitHub] storm pull request #2839: STORM-3228 allow refernce counting of differing Po...

2018-09-18 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2839#discussion_r218564194 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/PortAndAssignmentImpl.java --- @@ -26,13 +26,16 @@ public PortAndAssignmentImpl(int port,

[GitHub] storm pull request #2839: STORM-3228 allow refernce counting of differing Po...

2018-09-18 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2839#discussion_r218564410 --- Diff: storm-server/src/main/java/org/apache/storm/localizer/TimePortAndAssignment.java --- @@ -48,4 +48,29 @@ public LocalAssignment getAssignment() {

[GitHub] storm issue #2839: STORM-3228 allow refernce counting of differing PortAndAs...

2018-09-18 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2839 There are some new checkstyle violations that we missed before. ---

[GitHub] storm pull request #2838: STORM-3227: Only push credentials if going to expe...

2018-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2838 ---

[GitHub] storm issue #2840: STORM-3147: Add metrics based on ClusterSummary

2018-09-18 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2840 I'm hoping @zd-project will help review this, since this is a rebase of his PR. I don't really have the context to know whether these added metrics are useful. ---

[GitHub] storm issue #2841: STORM-3105: upgrade version of hive

2018-09-18 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2841 The build is failing do not merge yet... ---

[GitHub] storm pull request #2840: STORM-3147: Add metrics based on ClusterSummary

2018-09-18 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2840#discussion_r218485913 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4767,4 +4797,205 @@ public IScheduler getForcedScheduler() {

[GitHub] storm pull request #2840: STORM-3147: Add metrics based on ClusterSummary

2018-09-18 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2840#discussion_r218484299 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -2922,19 +2948,20 @@ public void launchServer() throws Exception {

[GitHub] storm pull request #2841: STORM-3105: upgrade version of hive

2018-09-18 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2841 STORM-3105: upgrade version of hive You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm STORM-3105 Alternatively you can

Re: Regarding releasing Apache Storm 2.0.0

2018-09-18 Thread Bobby Evans
Great work everyone. We are really close on this. We have everything in except for https://github.com/apache/storm/pull/2719, but there has been no movement there, so I will try and put up an alternative pull request. Also We noticed that a recent merge broke some things fairly badly so we need

[GitHub] storm pull request #1337: STORM-1475: Add storm-elasticsearch2 module

2018-09-18 Thread dossett
Github user dossett closed the pull request at: https://github.com/apache/storm/pull/1337 ---