Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2854
---
GitHub user d2r opened a pull request:
https://github.com/apache/storm/pull/2862
STORM-3238: Reduces scope of wrapper, corrects variable
https://www.w3schools.com/js/js_this.asp
> In a function definition, this refers to the "owner" of the function.
When we wrapped
GitHub user agresch opened a pull request:
https://github.com/apache/storm/pull/2861
STORM-3244 allow logviewer to use independent filter settings from ui
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agresch/storm
Github user d2r commented on the issue:
https://github.com/apache/storm/pull/2858
OK this is done.
Tested using:
```Bash
rm -rf ~/.m2/repository/
mvn clean install -DskipTests=true -U -P '!examples,!externals'
```
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2858
I'd be fine with just moving them to the new profile. It already contains
the integration test, which also isn't in externals.
---
Github user d2r commented on the issue:
https://github.com/apache/storm/pull/2858
Yes, thank you @srdo for pointing this out.
Would it be all right merely to move `flux` and `sql` to the new
`externals` profile, or would we need make source code/layout changes as well
to
Github user d2r commented on the issue:
https://github.com/apache/storm/pull/2860
> could you file a follow on JIRA to clean up the pom.xml now that clojure
is only needed for tests
Created [STORM-3243](https://issues.apache.org/jira/browse/STORM-3243).
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2858
Sorry @srdo is right we need to make sure that we have the dependencies
setup properly.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2860
The code change looks fine, but could you file a follow on JIRA to clean up
the pom.xml now that clojure is only needed for tests, or you could do it here,
I am fine either way.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2857
---
Github user d2r commented on the issue:
https://github.com/apache/storm/pull/2856
Thanks for reviews @kishorvpatil, @revans2, @Ethanlm, I have merged this to
master.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2856
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2855
---
GitHub user d2r opened a pull request:
https://github.com/apache/storm/pull/2860
STORM-1318: Fixes & ports shell submission to Java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/d2r/storm port-shellsubmission-to-java
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2858
This looks good, but I'm wondering if Flux and the sql modules should be
added to externals as well? They depend on storm-kafka-client, so the build
won't work with externals disabled unless you happen
GitHub user esamson opened a pull request:
https://github.com/apache/storm/pull/2859
Replace docs reference to Flume with HiveBolt
Minor doc fix.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/esamson/storm hive-doc-fix
16 matches
Mail list logo
