[GitHub] storm issue #2862: STORM-3238: Reduces scope of wrapper, corrects variable

2018-10-04 Thread d2r
Github user d2r commented on the issue: https://github.com/apache/storm/pull/2862 Thank you @kishorvpatil for the review. I have merged this to master branch. ---

[GitHub] storm pull request #2862: STORM-3238: Reduces scope of wrapper, corrects var...

2018-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2862 ---

[GitHub] storm pull request #2864: [STORM-3246]Use utf-8 charset to write log files

2018-10-04 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/2864 [STORM-3246]Use utf-8 charset to write log files You can merge this pull request into a Git repository by running: $ git pull https://github.com/kishorvpatil/incubator-storm

[GitHub] storm pull request #2863: STORM-3245: Don't blow up if empty log dirs exist

2018-10-04 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2863 STORM-3245: Don't blow up if empty log dirs exist The empty directories are also deleted after they age out. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request #2858: STORM-3242: Adds "examples" and "externals" profil...

2018-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2858 ---

[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles

2018-10-04 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2858 Thanks @d2r, merged to master. ---

[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles

2018-10-04 Thread d2r
Github user d2r commented on the issue: https://github.com/apache/storm/pull/2858 Squashed; old commit was 9aeac5e517d6f5b1a7c1aba0afc0385a99144471. ---

[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles

2018-10-04 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2858 +1, thanks for addressing my comment. Please squash to one commit containing the issue number. ---