Re: [VOTE] Release Apache Storm 2.0.0 (rc2)

2018-10-10 Thread Jungtaek Lim
Thanks all for the quick turnaround! Here's my +1 (binding). > source - verify file (signature, MD5, SHA) -- source, tar.gz : OK -- source, zip : OK - extract file -- source, tar.gz : OK -- source, zip : OK - diff-ing extracted files between tar.gz and zip : OK - build source with JDK 8

Re: Cleaning Up Old Pull Requests STORM-3250

2018-10-10 Thread Stig Rohde Døssing
Thanks for explaining, that makes sense. It's probably easier to go over the issues once the PRs are closed, instead of having to handle them all at the same time. Den ons. 10. okt. 2018 kl. 20.27 skrev Derek Dagit : > > What is the value in keeping the associated Jira issues around though? > >

Re: Cleaning Up Old Pull Requests STORM-3250

2018-10-10 Thread Derek Dagit
> What is the value in keeping the associated Jira issues around though? 1) I had thought Jira issues could be valid even if they are stale, whereas pull requests typically are not valid when they go stale. 2) It is less effort. :) The simplest thing to do would be to run a similar query (not

Re: Cleaning Up Old Pull Requests STORM-3250

2018-10-10 Thread Hugo Louro
Derek, I am OK with closing them all. By phase I meant perhaps leaving some of the most recent one's in case the author wants to resume them... but I guess he can always reopen them. Stig, the JIRAs I think the should be handled on an individual basis. If they are still revenant, leave the JIRA

Re: Cleaning Up Old Pull Requests STORM-3250

2018-10-10 Thread Stig Rohde Døssing
+1 to close old PRs. What is the value in keeping the associated Jira issues around though? Den tir. 9. okt. 2018 kl. 17.18 skrev Derek Dagit : > > Is the idea to remove them all in one batch, or have the removal process > through phases ? > > Yeah, the idea was to close them all in one batch.

Re: [VOTE] Release Apache Storm 2.0.0 (rc2)

2018-10-10 Thread Stig Rohde Døssing
+1 Built and ran unit tests from the tag. Ran ExclamationTopology locally using the Storm tar, verified that UI looks as expected, that logviewer works, and that there were no errors in the logs. Verified the signature and SHA512 for the source and binary tars. We should consider deleting the

Re: [VOTE] Release Apache Storm 2.0.0 (rc2)

2018-10-10 Thread Bobby Evans
+1 built and ran all of the unit tests from the tag. Ran some small perf tests on a single node cluster. Things look really good there. On a side note our CI pipeline has been running and passing builds very close to this release too. (we are following master currently) and it is looking