[GitHub] storm pull request #2909: STORM-3123 - add support for Kafka security config...

2018-11-15 Thread arunmahadevan
GitHub user arunmahadevan opened a pull request: https://github.com/apache/storm/pull/2909 STORM-3123 - add support for Kafka security config in storm-kafka-monitor 1.x version of https://github.com/apache/storm/pull/2906 You can merge this pull request into a Git repository by

[GitHub] storm pull request #2906: STORM-3123 - add support for Kafka security config...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2906 ---

[GitHub] storm pull request #2908: STORM-3276: Updated Flux to deal with storm local ...

2018-11-15 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2908#discussion_r234019467 --- Diff: storm-server/src/main/java/org/apache/storm/LocalCluster.java --- @@ -1197,8 +1238,9 @@ public IBolt makeAckerBoltImpl() { * When

[GitHub] storm pull request #2908: STORM-3276: Updated Flux to deal with storm local ...

2018-11-15 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2908 STORM-3276: Updated Flux to deal with storm local correctly You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm STORM-3276

[GitHub] storm pull request #2906: STORM-3123 - add support for Kafka security config...

2018-11-15 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2906#discussion_r233963942 --- Diff: external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/NewKafkaSpoutOffsetQuery.java --- @@ -27,12 +27,15 @@

[GitHub] storm issue #2906: STORM-3123 - add support for Kafka security config in sto...

2018-11-15 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2906 @HeartSaVioR thanks for reviewing. Addressed comments. ---

[GitHub] storm pull request #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trid...

2018-11-15 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2907#discussion_r233750714 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java --- @@ -218,26 +228,27 @@ private void