[GitHub] storm issue #2918: STORM-3295 allow blacklist scheduling to function properl...

2018-12-06 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2918 @agresch If this strategy only happens when cluster resource is full originally, i'm ok with it. At least it's a better way. ---

[GitHub] storm issue #2915: [STORM-3291]Worker can't run as the user who submitted th...

2018-12-06 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2915 @revans2 could you help me to review this PR? thanks ---

[GitHub] storm issue #2918: STORM-3295 allow blacklist scheduling to function properl...

2018-12-06 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2918 @revans2 @danny0405 - Made changes requested by @revans2. Let me know if we should have a separate JIRA for switching blacklisting to work strictly by supervisor instead of doing this mismatch

[GitHub] storm issue #2918: STORM-3295 allow blacklist scheduling to function properl...

2018-12-06 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2918 @revans2 - I will look at addressing DefaultBlacklistStrategy. ---

[GitHub] storm pull request #2918: STORM-3295 allow blacklist scheduling to function ...

2018-12-06 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2918#discussion_r239522894 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/blacklist/strategies/RasBlacklistStrategy.java --- @@ -79,25 +81,46 @@

[GitHub] storm pull request #2918: STORM-3295 allow blacklist scheduling to function ...

2018-12-06 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2918#discussion_r239517824 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/blacklist/strategies/RasBlacklistStrategy.java --- @@ -79,25 +81,46 @@

[GitHub] storm pull request #2918: STORM-3295 allow blacklist scheduling to function ...

2018-12-06 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2918#discussion_r239519351 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/blacklist/strategies/RasBlacklistStrategy.java --- @@ -79,25 +81,46 @@

[GitHub] storm pull request #2918: STORM-3295 allow blacklist scheduling to function ...

2018-12-06 Thread agresch
Github user agresch commented on a diff in the pull request: https://github.com/apache/storm/pull/2918#discussion_r239461731 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/blacklist/strategies/RasBlacklistStrategy.java --- @@ -79,25 +81,46 @@