[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1220355853 ## storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java: ## @@ -527,13 +538,13 @@ protected

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1220322597 ## storm-client/src/jvm/org/apache/storm/Config.java: ## @@ -859,9 +859,11 @@ public class Config extends HashMap { @IsString public static final String

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1220291317 ## storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java: ## @@ -164,6 +168,7 @@ public

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1220277226 ## storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java: ## @@ -123,6 +123,10 @@ public

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1219931053 ## storm-client/src/jvm/org/apache/storm/Config.java: ## @@ -859,9 +859,11 @@ public class Config extends HashMap { @IsString public static final String

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1219927539 ## storm-client/src/jvm/org/apache/storm/Config.java: ## @@ -859,9 +859,11 @@ public class Config extends HashMap { @IsString public static final String