[GitHub] storm pull request: [STORM-1032] Add generics to component configu...

Github user ddebree commented on a diff in the pull request: https://github.com/apache/storm/pull/723#discussion_r38822073 --- Diff: storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java --- @@ -204,7 +204,7 @@ public StormTopology buildTopology

[GitHub] storm pull request: [STORM-1032] Add generics to component configu...

Github user ddebree commented on a diff in the pull request: https://github.com/apache/storm/pull/723#discussion_r38822071 --- Diff: storm-core/src/jvm/backtype/storm/drpc/LinearDRPCTopologyBuilder.java --- @@ -174,13 +174,12 @@ private static String boltId(int index

[GitHub] storm pull request: [STORM-1032] Add generics to component configu...

GitHub user ddebree opened a pull request: https://github.com/apache/storm/pull/723 [STORM-1032] Add generics to component configuration methods The getComponentConfiguration methods currently return a simple Map object. In fact they should be returning a Map. By changing this

[GitHub] storm pull request: [STORM-990] Refactored TimeCacheMap to extend ...

Github user ddebree commented on the pull request: https://github.com/apache/storm/pull/682#issuecomment-131239318 I have updated the class to rather use the RotatingMap as a member variable. It comes out a lot more similar to the original. --- If your project is set up for it, you

[GitHub] storm pull request: General cleanup of the generics.

Github user ddebree commented on the pull request: https://github.com/apache/storm/pull/683#issuecomment-130852227 Issue raised on Jira: https://issues.apache.org/jira/browse/STORM-991 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request: Refactored TimeCacheMap to extend RotatingMap.

Github user ddebree commented on the pull request: https://github.com/apache/storm/pull/682#issuecomment-130850289 Issue raised: https://issues.apache.org/jira/browse/STORM-990 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm pull request: General cleanup of the generics.

GitHub user ddebree opened a pull request: https://github.com/apache/storm/pull/683 General cleanup of the generics. Generally added generics to classes within the storm.trident.spout package. This generally removes some of the casts that were in place, and simplifies the code

[GitHub] storm pull request: Refactored TimeCacheMap to extend RotatingMap.

GitHub user ddebree opened a pull request: https://github.com/apache/storm/pull/682 Refactored TimeCacheMap to extend RotatingMap. This should allow current users of the TimeCacheMap to progressively migrate off the deprecated TimeCacheMap to the simpler RotatingMap. This also