Github user jnioche commented on a diff in the pull request:
https://github.com/apache/storm/pull/2908#discussion_r237006771
--- Diff: flux/flux-core/src/main/java/org/apache/storm/flux/Flux.java ---
@@ -52,17 +52,22 @@
public class Flux {
private static final Logger
Github user jnioche commented on a diff in the pull request:
https://github.com/apache/storm/pull/2908#discussion_r237004334
--- Diff: flux/flux-core/src/main/java/org/apache/storm/flux/Flux.java ---
@@ -52,17 +52,22 @@
public class Flux {
private static final Logger
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/2908
Tested on a StormCrawler topology, works fine in local and remote mode.
one quick question though: shouldn't --sleep be deprecated? --local-ttl is
used for all the local jobs instead
---
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/2897
bugfix ConfigurableTopology completely overwrites preexisting config
The ConfigurableTopology can take configuration files where the values are
put under a single config element to be compatible
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/2607
thanks @revans2
---
Github user jnioche closed the pull request at:
https://github.com/apache/storm/pull/2607
---
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/2607
thanks, see #2609
---
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/2609
STORM-3011 Use default bin path in flight.bash if JAVA_HOME is undefined
port of #2607 to master branch
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/2607
STORM-3011 Use default bin path in flight.bash if $JAVA_HOME is undefined
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jnioche/storm 1.x
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/2258
-1
Why not simply use parameterized messages instead? See
https://www.slf4j.org/faq.html#logging_performance
---
If your project is set up for it, you can reply to this email and have your
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1969
STORM-2326 Upgrade log4j and slf4j for branch 2.x
See #1946 for 1.0.x equivalent
` mvn clean install -DskipTests=true` ran without problems
You can merge this pull request into a Git
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1947
STORM-2326 Upgrade log4j and slf4j for branch 1.x
See #1946 for 1.0.x equivalent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1946
STORM-2326 Upgrade log4j and slf4j for branch 1.0.x
Compiled and packaged with
```
mvn clean install -DskipTests=true
cd storm-dist/binary && mvn package
```
Wo
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/1900
FYI this is fixed in the following version of log4j, see
https://blogs.apache.org/logging/entry/log4j-2-8-released.
I will test with 2.8 and open a new PR
---
If your project is set up
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/1907
Thanks @HeartSaVioR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/1897
I made a mess with this branch and have pushed a clean, squashed PR as a
replacement -> #1907
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user jnioche closed the pull request at:
https://github.com/apache/storm/pull/1897
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1907
STORM-2327 ConfigurableTopology
Squashed #1897 into a single commit.
@HeartSaVioR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jnioche commented on a diff in the pull request:
https://github.com/apache/storm/pull/1897#discussion_r98649259
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/RollingTopWords.java ---
@@ -17,114 +17,89 @@
*/
package
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/1897
@HeartSaVioR I removed StormRunner and modified some of the topologies so
that they extend ConfigurableTopology. Please let me know your thoughts on this.
---
If your project is set up for it, you
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/1897
Thanks @HeartSaVioR. Good idea, I'll have a look at the topology classes in
storm-starter. Just came across the
(StormRunner)[https://github.com/apache/storm/blob/master/examples/storm-starter/src
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/1896
See issue with #1900 - closing for now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jnioche closed the pull request at:
https://github.com/apache/storm/pull/1896
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/1900
Needs more work. I am getting the following in supervisor.log
```
2017-01-27 11:45:55.788 Thread-12 o.a.s.u.Utils [INFO] Worker Process
9318e633-f5fc-476f-825c-2f68a21163fd:Exception
Github user jnioche closed the pull request at:
https://github.com/apache/storm/pull/1900
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1900
Port STORM-2326 Upgrade log4j and slf4j to branch 1.0.x
See #1896
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jnioche/storm STORM-2326-2
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/1896
As far as I understand, Storm uses SLF4J + LOG4J. I could not find a way to
run a topology where one of the dependencies relies on a more recent version of
log4j (Elasticsearch 5). A similar problem
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1896
STORM-2326 Upgrade log4j and slf4j
Ran ` mvn clean install -DskipTests` without problems
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jnioche
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1222
Fix logging for LoggingMetricsConsumer on branch 0.10.x STORM-584
Port of #1221 to branch 0.10
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jnioche commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-188994648
thanks for having taken the time to do it @revans2, much appreciated
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jnioche commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-188872715
Anything blocking this from being committed (apart from committers'
availability)?
---
If your project is set up for it, you can reply to this email and have your
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1130
Update doc for rebalance command
Trivial update for the rebalance command - now similar to the output of
'storm help rebalance'
You can merge this pull request into a Git repository by running
Github user jnioche commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-186561314
@ptgoetz perfect, thanks. BTW I really like the HDFS module, great work!
Would be good to have compression for HdfsBolt, I might have a go at
implementing
Github user jnioche commented on the pull request:
https://github.com/apache/storm/pull/1122#issuecomment-186435209
@dossett good idea - I have just committed your suggestion
@revans2 and @ptgoetz \: will the content of the master branch become 2.x
and if so could
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1122
storm-hdfs : change visibility of create and closeOutputFile methods to
protected
When extending HdfsBolt it can be useful to be able to override the methods
createOutputFile() or closeOutputFile
Github user jnioche commented on a diff in the pull request:
https://github.com/apache/storm/pull/827#discussion_r45128717
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/Murmur3StreamGrouping.java
---
@@ -0,0 +1,89 @@
+/**
+ * Licensed
Github user jnioche commented on a diff in the pull request:
https://github.com/apache/storm/pull/827#discussion_r45129715
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/bolt/BatchCassandraWriterBolt.java
---
@@ -0,0 +1,192
Github user jnioche commented on a diff in the pull request:
https://github.com/apache/storm/pull/827#discussion_r45130329
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/client/CassandraConf.java
---
@@ -0,0 +1,146 @@
+/**
+ * Licensed
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/828
Fixed incubator URLs
Replaces links to 'storm.incubator.apache.org' with 'storm.apache.org' and
'github.com/apache/incubator-storm' with 'github.com/apache/storm'
This also removes
39 matches
Mail list logo
