[GitHub] storm pull request: STORM-512 KafkaBolt doesn't handle ticks prope...

2015-04-16 Thread nielsbasjes
Github user nielsbasjes commented on the pull request: https://github.com/apache/storm/pull/275#issuecomment-93697965 I had this ack for the tick in there in an earlier version of the change. Then I asked on the mailing list if this ack is needed and I was told

[GitHub] storm pull request: STORM-512 KafkaBolt doesn't handle ticks prope...

2015-02-17 Thread nielsbasjes
Github user nielsbasjes commented on the pull request: https://github.com/apache/storm/pull/275#issuecomment-74696542 @nathanmarz / @revans2 What must I do/change to get this solution committed? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: STORM-512 KafkaBolt doesn't handle ticks prope...

2014-12-15 Thread nielsbasjes
Github user nielsbasjes commented on the pull request: https://github.com/apache/storm/pull/275#issuecomment-66971975 @nathanmarz Thanks I understand your view now. I refactored my patch to meet this requirement and I've tried to make it as small a difference as possible

[GitHub] storm pull request: STORM-512 KafkaBolt doesn't handle ticks prope...

2014-10-29 Thread nielsbasjes
Github user nielsbasjes commented on the pull request: https://github.com/apache/storm/pull/275#issuecomment-60935570 The execute of the KafkaBolt puts the tuple into Kafka as a message. What I ran into is that the Ticks were put into Kafka as messages too. My consumers