Re: [PR] STORM-4084 - Bump org.apache.commons:commons-compress from 1.26.0 to 1.27.1 (storm)

rzo1 merged PR #3686: URL: https://github.com/apache/storm/pull/3686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org F

Re: [PR] STORM-4083 - Bump jetty.version from 11.0.21 to 11.0.23 (storm)

rzo1 merged PR #3688: URL: https://github.com/apache/storm/pull/3688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org F

Re: [PR] STORM-4082 - Bump prometheus.client.version from 1.3.0 to 1.3.1 (storm)

rzo1 merged PR #3687: URL: https://github.com/apache/storm/pull/3687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org F

Re: [PR] STORM-4081 - Bump metrics.version from 4.2.26 to 4.2.27 (storm)

rzo1 merged PR #3689: URL: https://github.com/apache/storm/pull/3689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org F

Re: [PR] STORM-4075 Supprt mTLS between Storm and ZK (storm)

reiabreu commented on code in PR #3692: URL: https://github.com/apache/storm/pull/3692#discussion_r1749420224 ## storm-client/test/jvm/org/apache/storm/utils/CuratorUtilsTest.java: ## @@ -86,4 +110,163 @@ private CuratorFrameworkFactory.Builder setupBuilder(boolean withAuth) {

Re: [PR] STORM-4075 Supprt mTLS between Storm and ZK (storm)

reiabreu commented on code in PR #3692: URL: https://github.com/apache/storm/pull/3692#discussion_r1749420224 ## storm-client/test/jvm/org/apache/storm/utils/CuratorUtilsTest.java: ## @@ -86,4 +110,163 @@ private CuratorFrameworkFactory.Builder setupBuilder(boolean withAuth) {

Re: [PR] STORM-4076 KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

reiabreu commented on PR #3679: URL: https://github.com/apache/storm/pull/3679#issuecomment-2335144787 @anand-h-codes thanks for taking the time to go over the changes with me. And thank you for your PR -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] STORM-4076 KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

reiabreu merged PR #3679: URL: https://github.com/apache/storm/pull/3679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.or

Re: [PR] STORM-4076 KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

anand-h-codes commented on PR #3679: URL: https://github.com/apache/storm/pull/3679#issuecomment-2335016943 @reiabreu You are correct. More than efficiency, the important feature this PR gives is the control over the batch size. > Since the assignment of partitions to the consumer is

Re: [PR] STORM-4076 KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

reiabreu commented on PR #3679: URL: https://github.com/apache/storm/pull/3679#issuecomment-2334813805 ` emitter.refreshPartitions(taskPartitions);` is assigning the task's partitions to the emitter object. Then the emitter will poll all the assigned partitions and just emit forward the

Re: [PR] STORM-4076 KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

anand-h-codes commented on PR #3679: URL: https://github.com/apache/storm/pull/3679#issuecomment-2334574436 @reiabreu I understand your concern. The main problem with the existing method is, even though if we set `max.poll.records`, we can't guarantee that one trident batch will have not mo

Re: [PR] STORM-4076 KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

reiabreu commented on PR #3679: URL: https://github.com/apache/storm/pull/3679#issuecomment-2333799806 @anand-h-codes I don't have experience with Trident, so might review those specific classes is therefore not very consequential. The Kafka related changes seem fine, but I do have a que

Re: [PR] STORM-4076 KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

anand-h-codes commented on code in PR #3679: URL: https://github.com/apache/storm/pull/3679#discussion_r1745930535 ## external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java: ## @@ -163,54 +164,56 @@ && isFirstPollOffsetStrate

Re: [PR] STORM-4076 KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

reiabreu commented on code in PR #3679: URL: https://github.com/apache/storm/pull/3679#discussion_r1745517153 ## external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java: ## @@ -163,54 +164,56 @@ && isFirstPollOffsetStrategyIgn

Re: [PR] STORM-4076 KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

reiabreu commented on PR #3679: URL: https://github.com/apache/storm/pull/3679#issuecomment-2330987171 I don't have experience with Trident, but I do with Kafka. I'm having a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Uplift netty to 4.1.112 (storm)

noslowerdna commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2329352874 @reiabreu @rzo1 We really appreciate your efforts to expedite this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] STORM-4055 Kafka Consumer ConcurrentModificationException fix (storm)

reiabreu commented on PR #3691: URL: https://github.com/apache/storm/pull/3691#issuecomment-2328926731 Had a look and it looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Uplift netty to 4.1.112 (storm)

reiabreu commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2327630209 @noslowerdna 2.6.4 has been formally released. Cheers On Tue, 3 Sept 2024 at 20:34, Richard Zowalla ***@***.***> wrote: > @noslowerdna

Re: [PR] Uplift netty to 4.1.112 (storm)

rzo1 commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2327277011 @noslowerdna Testing is up to the community. Feel free to subscribe to the [dev mailing list ](https://storm.apache.org/getting-help.html), try the release candidate and cast a (non-binding) v

Re: [PR] Uplift netty to 4.1.112 (storm)

noslowerdna commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2327245815 @reiabreu How is the testing going? Would you be able to give us an ETA for 2.6.4's availability? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] STORM-4055 Kafka Consumer ConcurrentModificationException fix (storm)

rzo1 commented on PR #3691: URL: https://github.com/apache/storm/pull/3691#issuecomment-2325161501 Might be something in your area of in interest @avermeer ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Uplift netty to 4.1.112 (storm)

reiabreu commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2322881276 RC1 is out for testing. (We should improve our release notes to include dependabot's changes) On Tue, Aug 27, 2024, 22:49 Andrew Olson ***@***.***> wrote: > Thanks very much

[PR] STORM-4055 Kafka Consumer ConcurrentModificationException fix (storm)

anand-h-codes opened a new pull request, #3691: URL: https://github.com/apache/storm/pull/3691 ## What is the purpose of the change Kafka Consumer object is not thread safe. It must not be passed among threads for the purpose of collecting metrics. Instead Kafka Admin client can be u

Re: [PR] STORM-4070 mTls support - fix LICENSE-binary (storm)

rzo1 commented on PR #3690: URL: https://github.com/apache/storm/pull/3690#issuecomment-2316029770 I picked your changes and updated the missing parts with https://github.com/apache/storm/commit/664142c7820935cc5c78b7c2224c8b711ce541e6 - license checks are passing now. -- This is an auto

Re: [PR] STORM-4070 mTls support - fix LICENSE-binary (storm)

rzo1 closed pull request #3690: STORM-4070 mTls support - fix LICENSE-binary URL: https://github.com/apache/storm/pull/3690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] STORM-4070 mTls support - fix LICENSE-binary (storm)

reiabreu commented on PR #3690: URL: https://github.com/apache/storm/pull/3690#issuecomment-2315962082 Some tests are still failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] STORM-4070 mTls support - fix LICENSE-binary (storm)

purushah opened a new pull request, #3690: URL: https://github.com/apache/storm/pull/3690 ## What is the purpose of the change *(Explain why we should have this change)* ## How was the change tested *(Explain what tests did you do to verify the code change)* -- This is

Re: [PR] Uplift netty to 4.1.112 (storm)

noslowerdna commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2313639415 Thanks very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Uplift netty to 4.1.112 (storm)

reiabreu commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2313128261 Cheers, I will try to initiate the release sometime this week. On Tue, 27 Aug 2024 at 17:49, Richard Zowalla ***@***.***> wrote: > Feel free. I might find some time to test/

Re: [PR] Uplift netty to 4.1.112 (storm)

reiabreu commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2313019645 I don't mind acting as a release manager for 2.6.4. But we need consensus from maintainers to initiate the release. On Tue, 27 Aug 2024 at 15:31, Andrew Olson ***@***.***> wrote:

Re: [PR] STORM-4070 mTls support (storm)

agresch merged PR #3678: URL: https://github.com/apache/storm/pull/3678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] Uplift netty to 4.1.112 (storm)

noslowerdna commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2312737630 @rzo1 @reiabreu Do you know when 2.6.4 could be released? We have a CVE remediation checkpoint in a couple weeks, and it would be nice to be able to include this fix. -- This is an a

Re: [PR] STORM-4076 KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

rzo1 commented on PR #3679: URL: https://github.com/apache/storm/pull/3679#issuecomment-2309998014 @avermeer Can you have a look? I think, that Kafka is in your area of expertise :) (I am not a kafka user) -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] STORM-4070 mTls support (storm)

rzo1 commented on PR #3678: URL: https://github.com/apache/storm/pull/3678#issuecomment-2309995967 Needs a check regarding the licenses: ```bash Dependencies missing from LICENSE-binary: io.netty:netty-tcnative:2.0.61.Final org.bouncycastle:bcpkix-jdk18on:1.78.1 org.bouncy

[PR] Bump metrics.version from 4.2.26 to 4.2.27 (storm)

dependabot[bot] opened a new pull request, #3689: URL: https://github.com/apache/storm/pull/3689 Bumps `metrics.version` from 4.2.26 to 4.2.27. Updates `io.dropwizard.metrics:metrics-core` from 4.2.26 to 4.2.27 Commits https://github.com/dropwizard/metrics/commit/365166b5bc6e

[PR] Bump jetty.version from 11.0.21 to 11.0.23 (storm)

dependabot[bot] opened a new pull request, #3688: URL: https://github.com/apache/storm/pull/3688 Bumps `jetty.version` from 11.0.21 to 11.0.23. Updates `org.eclipse.jetty:jetty-bom` from 11.0.21 to 11.0.23 Release notes Sourced from https://github.com/jetty/jetty.project/releases

[PR] Bump prometheus.client.version from 1.3.0 to 1.3.1 (storm)

dependabot[bot] opened a new pull request, #3687: URL: https://github.com/apache/storm/pull/3687 Bumps `prometheus.client.version` from 1.3.0 to 1.3.1. Updates `io.prometheus:prometheus-metrics-core` from 1.3.0 to 1.3.1 Release notes Sourced from https://github.com/prometheus/cli

[PR] Bump org.apache.commons:commons-compress from 1.26.0 to 1.27.1 (storm)

dependabot[bot] opened a new pull request, #3686: URL: https://github.com/apache/storm/pull/3686 Bumps org.apache.commons:commons-compress from 1.26.0 to 1.27.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=o

Re: [PR] STORM-4076 [WIP] KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

anand-h-codes commented on PR #3679: URL: https://github.com/apache/storm/pull/3679#issuecomment-2308913632 @rzo1 the PR is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Uplift netty to 4.1.112 (storm)

reiabreu commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2307528546 Thank you for that .I took the liberty of editing the issue and assigning it version 2.6.4. I reckon we can mark at as resolved if no one objects -- This is an automated message from th

Re: [PR] Uplift netty to 4.1.112 (storm)

noslowerdna commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2307507224 @reiabreu I've created https://issues.apache.org/jira/browse/STORM-4078 for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] STORM-4076 [WIP] KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

anand-h-codes commented on PR #3679: URL: https://github.com/apache/storm/pull/3679#issuecomment-2307504389 @rzo1 the PR functionally complete. But I will need to modify the test cases accordingly. I shall proceed if you think the change is good enough. -- This is an automated message fr

Re: [PR] Uplift netty to 4.1.112 (storm)

reiabreu commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2307480047 Good call @rzo1 . @Lativado do you have a Jira account to report the issue? I can also do it -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Uplift netty to 4.1.112 (storm)

rzo1 commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2307464997 @reiabreu I guess we need a Jira for the changelog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Uplift netty to 4.1.112 (storm)

reiabreu merged PR #3685: URL: https://github.com/apache/storm/pull/3685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.or

Re: [PR] Uplift netty to 4.1.112 (storm)

noslowerdna commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2307268056 @jnioche I noticed you committed the previous Netty version update. Would it be possible to prioritize getting this Netty uplift merged and released? -- This is an automated message f

Re: [PR] Uplift netty to 4.1.112 (storm)

Lativado commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2307254006 Someone in my org called out a license file that I had missed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Uplift netty to 4.1.112 (storm)

Lativado commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2307242235 Updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Uplift netty to 4.1.112 (storm)

rzo1 commented on PR #3685: URL: https://github.com/apache/storm/pull/3685#issuecomment-2307223094 Needs an update of the license file. Otherwise, Looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[PR] Uplift netty to 4.1.112 (storm)

Lativado opened a new pull request, #3685: URL: https://github.com/apache/storm/pull/3685 ## What is the purpose of the change We have detected a CVE ([CVE-2024-29025](https://nvd.nist.gov/vuln/detail/CVE-2024-29025)) in our code and have tracked it down to the version of netty inclu

Re: [PR] Bump activemq.version from 5.18.3 to 6.1.3 (storm)

dependabot[bot] commented on PR #3682: URL: https://github.com/apache/storm/pull/3682#issuecomment-2306418259 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by a

Re: [PR] Bump slf4j.version from 1.7.36 to 2.0.16 (storm)

rzo1 commented on PR #3680: URL: https://github.com/apache/storm/pull/3680#issuecomment-2306419761 I think we can make the move to SLF4J2 but need to carefully review transient libraries and update exclusions due to the change of provider discovery in SLFJ42. What do you think @agresch ? An

Re: [PR] Bump spring.version from 5.3.27 to 6.1.12 (storm)

dependabot[bot] commented on PR #3681: URL: https://github.com/apache/storm/pull/3681#issuecomment-2306418548 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by a

Re: [PR] Bump spring.version from 5.3.27 to 6.1.12 (storm)

rzo1 commented on PR #3681: URL: https://github.com/apache/storm/pull/3681#issuecomment-2306418510 Same. Jakarta Namespace and Java 17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump spring.version from 5.3.27 to 6.1.12 (storm)

rzo1 closed pull request #3681: Bump spring.version from 5.3.27 to 6.1.12 URL: https://github.com/apache/storm/pull/3681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Bump activemq.version from 5.18.3 to 6.1.3 (storm)

rzo1 commented on PR #3682: URL: https://github.com/apache/storm/pull/3682#issuecomment-2306418216 This requires - (a) Jakarta Namespace - (b) A Minimum Runtime of Java 17+ This is something we need to discuss on the dev@ list. -- This is an automated message from the Apa

Re: [PR] Bump activemq.version from 5.18.3 to 6.1.3 (storm)

rzo1 closed pull request #3682: Bump activemq.version from 5.18.3 to 6.1.3 URL: https://github.com/apache/storm/pull/3682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] STORM-4076 [WIP] KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

rzo1 commented on PR #3679: URL: https://github.com/apache/storm/pull/3679#issuecomment-2306416141 @anand-h-codes Thanks for your PR. Since it is marked **WIP** is it already ready for review or are you planning to update it? -- This is an automated message from the Apache Git Service. To

Re: [PR] Bump org.apache.maven.plugins:maven-surefire-report-plugin from 2.19.1 to 3.4.0 (storm)

rzo1 merged PR #3684: URL: https://github.com/apache/storm/pull/3684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org F

Re: [PR] Bump testcontainers.version from 1.19.6 to 1.20.1 (storm)

rzo1 merged PR #3683: URL: https://github.com/apache/storm/pull/3683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org F

Re: [PR] STORM-4070 mTls support (storm)

purushah commented on PR #3678: URL: https://github.com/apache/storm/pull/3678#issuecomment-2305946573 Pushing the final patch. We have been running this on our cluster for the last two years. I have tested the patch with the following settings. SSL certs are attached. ``` nimbus.

Re: [PR] STORM-4070 mTls support (storm)

purushah commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1722516795 ## pom.xml: ## @@ -1012,6 +1013,11 @@ + +org.bouncycastle +bcpkix-jdk15

Re: [PR] STORM-4070 mTls support (storm)

purushah commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1722515188 ## storm-shaded-deps/pom.xml: ## @@ -137,6 +137,22 @@ netty-all true + +io.netty +netty-handler +

[PR] Bump org.apache.maven.plugins:maven-surefire-report-plugin from 2.19.1 to 3.4.0 (storm)

dependabot[bot] opened a new pull request, #3684: URL: https://github.com/apache/storm/pull/3684 Bumps [org.apache.maven.plugins:maven-surefire-report-plugin](https://github.com/apache/maven-surefire) from 2.19.1 to 3.4.0. Release notes Sourced from https://github.com/apache/maven

[PR] Bump testcontainers.version from 1.19.6 to 1.20.1 (storm)

dependabot[bot] opened a new pull request, #3683: URL: https://github.com/apache/storm/pull/3683 Bumps `testcontainers.version` from 1.19.6 to 1.20.1. Updates `org.testcontainers:testcontainers` from 1.19.6 to 1.20.1 Release notes Sourced from https://github.com/testcontainers/te

[PR] Bump activemq.version from 5.18.3 to 6.1.3 (storm)

dependabot[bot] opened a new pull request, #3682: URL: https://github.com/apache/storm/pull/3682 Bumps `activemq.version` from 5.18.3 to 6.1.3. Updates `org.apache.activemq:activemq-client` from 5.18.3 to 6.1.3 Commits https://github.com/apache/activemq/commit/f1d2cdc1125b412

[PR] Bump spring.version from 5.3.27 to 6.1.12 (storm)

dependabot[bot] opened a new pull request, #3681: URL: https://github.com/apache/storm/pull/3681 Bumps `spring.version` from 5.3.27 to 6.1.12. Updates `org.springframework:spring-beans` from 5.3.27 to 6.1.12 Release notes Sourced from https://github.com/spring-projects/spring-fra

[PR] Bump slf4j.version from 1.7.36 to 2.0.16 (storm)

dependabot[bot] opened a new pull request, #3680: URL: https://github.com/apache/storm/pull/3680 Bumps `slf4j.version` from 1.7.36 to 2.0.16. Updates `org.slf4j:slf4j-api` from 1.7.36 to 2.0.16 Updates `org.slf4j:slf4j-log4j12` from 1.7.36 to 2.0.16 Updates `org.slf4j:log4j-o

[PR] STORM-4076 KafkaTridentSpoutEmitters can poll all partitions at once instead of one at a time (storm)

anand-h-codes opened a new pull request, #3679: URL: https://github.com/apache/storm/pull/3679 ## What is the purpose of the change Currently 'KafkaTridentTransactionalSpoutEmitter' and 'KafkaTridentOpaqueEmitter' polls every partition assigned to the spout one by one while emitting

Re: [PR] STORM-4070 mTls support (storm)

purushah commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1718705502 ## storm-client/test/resources/ssl/README.md: ## @@ -0,0 +1,10 @@ +SSL test data Review Comment: The certificates are valid for 1000 years. ``` ~ % keytool -

Re: [PR] STORM-4070 mTls support (storm)

rzo1 commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1718567961 ## storm-client/src/jvm/org/apache/storm/security/auth/X509CertPrincipalToLocal.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] STORM-4070 mTls support (storm)

rzo1 commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1718567961 ## storm-client/src/jvm/org/apache/storm/security/auth/X509CertPrincipalToLocal.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] STORM-4070 mTls support (storm)

rzo1 commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1718567061 ## storm-client/src/jvm/org/apache/storm/security/auth/X509CertOrKerberosPrincipalToLocal.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] STORM-4070 mTls support (storm)

rzo1 commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1718567061 ## storm-client/src/jvm/org/apache/storm/security/auth/X509CertOrKerberosPrincipalToLocal.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] STORM-4070 mTls support (storm)

rzo1 commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1718563803 ## pom.xml: ## @@ -1012,6 +1013,11 @@ + +org.bouncycastle +bcpkix-jdk15on

Re: [PR] STORM-4070 mTls support (storm)

rzo1 commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1718562092 ## storm-shaded-deps/pom.xml: ## @@ -137,6 +137,22 @@ netty-all true + +io.netty +netty-handler +

Re: [PR] STORM-4070 mTls support (storm)

rzo1 commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1718560572 ## storm-client/test/resources/ssl/README.md: ## @@ -0,0 +1,10 @@ +SSL test data Review Comment: How are the certifcates generated? How long are they valid? (Would be b

Re: [PR] STORM-4070 mTls support (storm)

purushah commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1717534391 ## storm-client/test/resources/ssl/README.md: ## @@ -0,0 +1,10 @@ +SSL test data +=== Review Comment: It is used by TlsTransportPluginTest. It needs

Re: [PR] STORM-4070 mTls support (storm)

purushah commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1717532294 ## storm-client/src/jvm/org/apache/storm/utils/NimbusClient.java: ## @@ -12,11 +12,14 @@ package org.apache.storm.utils; +import static org.apache.storm.Config.NIMB

Re: [PR] STORM-4070 mTls support (storm)

agresch commented on code in PR #3678: URL: https://github.com/apache/storm/pull/3678#discussion_r1717132587 ## storm-client/src/jvm/org/apache/storm/utils/NimbusClient.java: ## @@ -12,11 +12,14 @@ package org.apache.storm.utils; +import static org.apache.storm.Config.NIMBU

Re: [PR] STORM-4070 mTls support (storm)

purushah commented on PR #3678: URL: https://github.com/apache/storm/pull/3678#issuecomment-2287540610 Yes, I had to regenerate it. There was a change in NimbusSummary with the addition of the `tlsPort` field: `6: optional i32 tlsPort;` The Storm Thrift was originally generated

[PR] STORM-4070 mTls support (storm)

purushah opened a new pull request, #3678: URL: https://github.com/apache/storm/pull/3678 ## What is the purpose of the change *(Explain why we should have this change)* ## How was the change tested *(Explain what tests did you do to verify the code change)* -- This is

Re: [PR] STORM-4069 - java.lang.ClassCastException for Trident-based Topology (storm)

rzo1 merged PR #3676: URL: https://github.com/apache/storm/pull/3676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org F

Re: [PR] STORM-4072 - Bump org.jctools:jctools-core from 2.0.1 to 4.0.5 (storm)

rzo1 merged PR #3665: URL: https://github.com/apache/storm/pull/3665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org F

Re: [PR] STORM-4071 - Bump com.zaxxer:HikariCP from 5.0.1 to 5.1.0 (storm)

rzo1 merged PR #3673: URL: https://github.com/apache/storm/pull/3673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org F

Re: [PR] STORM-4074 Bump joda-time:joda-time from 2.12.5 to 2.12.7 (storm)

rzo1 merged PR #3674: URL: https://github.com/apache/storm/pull/3674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org F

Re: [PR] STORM-4073 Bump com.fasterxml.jackson:jackson-bom from 2.16.1 to 2.17.2 (storm)

rzo1 merged PR #3668: URL: https://github.com/apache/storm/pull/3668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org F

Re: [PR] Bump com.puppycrawl.tools:checkstyle from 8.2 to 10.17.0 (storm)

dependabot[bot] commented on PR #3677: URL: https://github.com/apache/storm/pull/3677#issuecomment-2284616375 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let m

Re: [PR] Bump com.puppycrawl.tools:checkstyle from 8.2 to 10.17.0 (storm)

rzo1 closed pull request #3677: Bump com.puppycrawl.tools:checkstyle from 8.2 to 10.17.0 URL: https://github.com/apache/storm/pull/3677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Bump com.puppycrawl.tools:checkstyle from 8.2 to 10.17.0 (storm)

dependabot[bot] opened a new pull request, #3677: URL: https://github.com/apache/storm/pull/3677 Bumps [com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle) from 8.2 to 10.17.0. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases";>co

Re: [PR] STORM-4069 - java.lang.ClassCastException for Trident-based Topology (storm)

rzo1 commented on PR #3676: URL: https://github.com/apache/storm/pull/3676#issuecomment-2278474821 > thanks @rzo1 . Are there any unit tests we can add for this? I fear, that the whole trident part of Storm (on the client side) isn't well tested at all (otherwise, we would have caught

Re: [PR] STORM-4069 - java.lang.ClassCastException for Trident-based Topology (storm)

reiabreu commented on PR #3676: URL: https://github.com/apache/storm/pull/3676#issuecomment-2278459799 thanks @rzo1 . Are there any unit tests we can add for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] STORM-4069 - java.lang.ClassCastException for Trident-based Topology (storm)

abreur commented on PR #3676: URL: https://github.com/apache/storm/pull/3676#issuecomment-2278458601 thanks @rzo1 . Are there any unit tests we can add for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump jakarta-activation-version from 1.2.1 to 2.0.1 (storm)

dependabot[bot] commented on PR #3661: URL: https://github.com/apache/storm/pull/3661#issuecomment-2278452423 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by a

Re: [PR] Bump jakarta-activation-version from 1.2.1 to 2.0.1 (storm)

rzo1 closed pull request #3661: Bump jakarta-activation-version from 1.2.1 to 2.0.1 URL: https://github.com/apache/storm/pull/3661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] STORM-4069 - java.lang.ClassCastException for Trident-based Topology (storm)

rzo1 opened a new pull request, #3676: URL: https://github.com/apache/storm/pull/3676 ## What is the purpose of the change see https://issues.apache.org/jira/projects/STORM/issues/STORM-4069 (or mailing list) ## How was the change tested - CI -- This is an automated m

Re: [PR] Deleted ubuntu default user and its group (storm-docker)

rzo1 merged PR #1: URL: https://github.com/apache/storm-docker/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

[PR] Deleted ubuntu default user and its group (storm-docker)

mayankshakya31 opened a new pull request, #1: URL: https://github.com/apache/storm-docker/pull/1 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Update release procedure documentation (storm)

reiabreu merged PR #3675: URL: https://github.com/apache/storm/pull/3675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.or

[PR] Update release procedure documentation (storm)

reiabreu opened a new pull request, #3675: URL: https://github.com/apache/storm/pull/3675 ## What is the purpose of the change Updating procedure for the generation of sha512 digests -- This is an automated message from the Apache Git Service. To respond to the message, please l

  1   2   3   4   5   6   7   8   >