[GitHub] [storm-site] avermeer commented on pull request #45: STORM-3957: People page now links to ASF's https://projects.apache.or…

2023-08-24 Thread via GitHub
avermeer commented on PR #45: URL: https://github.com/apache/storm-site/pull/45#issuecomment-1691812398 I have git pushed the changes from `bundle exec jekyll build -d content`, can I merge this pull request, or should I wait 2/3 days to leave others time to comment? -- This is an

Re: [PR] [STORM-3954] Remove Logback pulled in by Zookeeper (storm)

2023-08-24 Thread via GitHub
bipinprasad merged PR #3569: URL: https://github.com/apache/storm/pull/3569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm-site] rzo1 commented on pull request #45: STORM-3957: People page now links to ASF's https://projects.apache.or…

2023-08-24 Thread via GitHub
rzo1 commented on PR #45: URL: https://github.com/apache/storm-site/pull/45#issuecomment-1691776984 > I must confess all this stuff for making minor changes to storm-site seems to me like a gas factory. I have the feeling that using LaTeX for Storm documentation would have been even

[GitHub] [storm-site] avermeer commented on pull request #45: STORM-3957: People page now links to ASF's https://projects.apache.or…

2023-08-24 Thread via GitHub
avermeer commented on PR #45: URL: https://github.com/apache/storm-site/pull/45#issuecomment-1691769956 > Another idea would be to use the ASF Jenkins CI to build from a different branch and automatically push the content changes to `asf-site`. So we only need to deal with the `.md` files

[GitHub] [storm-site] rzo1 commented on pull request #45: STORM-3957: People page now links to ASF's https://projects.apache.or…

2023-08-24 Thread via GitHub
rzo1 commented on PR #45: URL: https://github.com/apache/storm-site/pull/45#issuecomment-1691718993 Another idea would be to use the ASF Jenkins CI to build from a different branch and automatically push the content changes to `asf-site`. So we only need to deal with the `.md` files and

[GitHub] [storm-site] rzo1 commented on pull request #45: STORM-3957: People page now links to ASF's https://projects.apache.or…

2023-08-24 Thread via GitHub
rzo1 commented on PR #45: URL: https://github.com/apache/storm-site/pull/45#issuecomment-1691635335 I think you could manually create a "hardlink" in Windows (don't using Windows for a few years now). +1 for adding some warning. -- This is an automated message from the Apache Git

[GitHub] [storm-site] avermeer commented on pull request #45: STORM-3957: People page now links to ASF's https://projects.apache.or…

2023-08-24 Thread via GitHub
avermeer commented on PR #45: URL: https://github.com/apache/storm-site/pull/45#issuecomment-1691596996 > Looks like the symlink to current is missing :-) Okay so I think have understood the reason for my mistake: I tried to use Windows operating system to work on this change on

[GitHub] [storm-site] rzo1 commented on pull request #45: STORM-3957: People page now links to ASF's https://projects.apache.or…

2023-08-23 Thread via GitHub
rzo1 commented on PR #45: URL: https://github.com/apache/storm-site/pull/45#issuecomment-1690993248 Looks like the symlink to current is missing :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [storm-site] avermeer commented on pull request #45: STORM-3957: People page now links to ASF's https://projects.apache.or…

2023-08-23 Thread via GitHub
avermeer commented on PR #45: URL: https://github.com/apache/storm-site/pull/45#issuecomment-1690892326 > @avermeer I think you need to run `bundle exec jekyll build -d content` to update the `content` directory. Hello Richard, Thanks for suggesting me to run `bundle exec

[GitHub] [storm-site] dependabot[bot] opened a new pull request, #48: Bump activesupport from 7.0.6 to 7.0.7.2 in /content

2023-08-23 Thread via GitHub
dependabot[bot] opened a new pull request, #48: URL: https://github.com/apache/storm-site/pull/48 Bumps [activesupport](https://github.com/rails/rails) from 7.0.6 to 7.0.7.2. Release notes Sourced from https://github.com/rails/rails/releases;>activesupport's releases.

[GitHub] [storm-site] dependabot[bot] opened a new pull request, #47: Bump activesupport from 7.0.6 to 7.0.7.2

2023-08-23 Thread via GitHub
dependabot[bot] opened a new pull request, #47: URL: https://github.com/apache/storm-site/pull/47 Bumps [activesupport](https://github.com/rails/rails) from 7.0.6 to 7.0.7.2. Release notes Sourced from https://github.com/rails/rails/releases;>activesupport's releases.

[GitHub] [storm-site] rzo1 commented on pull request #46: STORM-3959 - Add Matomo Tracking

2023-08-22 Thread via GitHub
rzo1 commented on PR #46: URL: https://github.com/apache/storm-site/pull/46#issuecomment-1687648177 Actual change is in `_includes/footer.html`. The rest is re-generated content. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [storm-site] rzo1 opened a new pull request, #46: STORM-3959 - Add Matomo Tracking

2023-08-22 Thread via GitHub
rzo1 opened a new pull request, #46: URL: https://github.com/apache/storm-site/pull/46 as the title says -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [storm-site] rzo1 commented on pull request #45: STORM-3957: People page now links to ASF's https://projects.apache.or…

2023-08-22 Thread via GitHub
rzo1 commented on PR #45: URL: https://github.com/apache/storm-site/pull/45#issuecomment-1687644204 @avermeer I think you need to run `bundle exec jekyll build -d content` to update the `content` directory. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [STORM-3924] Support for declaring WorkerHook in Flux topology definitions (storm)

2023-08-19 Thread via GitHub
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1685175658 @rzo1 thanks a lot for rebasing it. Had been busy at ofc for the past couple of weeks, so couldn't do it earlier as planned. Let me know if anything else is required here. -- This is an

[GitHub] [storm-site] avermeer opened a new pull request, #45: STORM-3957: People page now links to ASF's https://projects.apache.or…

2023-08-19 Thread via GitHub
avermeer opened a new pull request, #45: URL: https://github.com/apache/storm-site/pull/45 …g/committee.html?storm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] bump log4j 2.16.0 and disruptor 3.4.4 (storm)

2023-08-17 Thread via GitHub
rzo1 commented on PR #3426: URL: https://github.com/apache/storm/pull/3426#issuecomment-1682102569 Given the recent discussions to move Storm to the attic, I don't think, that there is much man power to maintain 1.x, I will close it (feel free to re-open). Most work currently focussed on

Re: [PR] bump log4j 2.16.0 and disruptor 3.4.4 (storm)

2023-08-17 Thread via GitHub
rzo1 closed pull request #3426: bump log4j 2.16.0 and disruptor 3.4.4 URL: https://github.com/apache/storm/pull/3426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] 0.9.x branch (storm)

2023-08-17 Thread via GitHub
rzo1 closed pull request #2994: 0.9.x branch URL: https://github.com/apache/storm/pull/2994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [STORM-3401] Add OpenLab CI configuration for ARM64 build (storm)

2023-08-17 Thread via GitHub
rzo1 commented on PR #3023: URL: https://github.com/apache/storm/pull/3023#issuecomment-1682077378 @Yikun Is this still a thing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [STORM-3956] Fix cli monitor component's argument type (storm)

2023-08-17 Thread via GitHub
rzo1 commented on PR #3423: URL: https://github.com/apache/storm/pull/3423#issuecomment-1682030358 lgtm and is still an issue in 2.5.0. Thx @dekimsey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [STORM-3956] Fix cli monitor component's argument type (storm)

2023-08-17 Thread via GitHub
rzo1 commented on PR #3423: URL: https://github.com/apache/storm/pull/3423#issuecomment-1682029667 ```bash user@node-147:~/Downloads/apache-storm-2.5.0/bin$ ./storm monitor -m wordGenerator production-topology usage: storm monitor [-h] [-i INTERVAL] [-m COMPONENT] [-s STREAM] [-w

Re: [PR] [STORM-3949] libthrift 0.18.1 (storm)

2023-08-17 Thread via GitHub
rzo1 merged PR #3564: URL: https://github.com/apache/storm/pull/3564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] [STORM-3953] Update releasing document. (storm)

2023-08-17 Thread via GitHub
rzo1 merged PR #3568: URL: https://github.com/apache/storm/pull/3568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] [STORM-3953] Update releasing document. (storm)

2023-08-16 Thread via GitHub
rzo1 commented on code in PR #3568: URL: https://github.com/apache/storm/pull/3568#discussion_r1295874199 ## RELEASING.md: ## @@ -66,10 +66,73 @@ sha512sum RELEASE_NOTES.html > RELEASE_NOTES.html.sha512 7. Move the release files from Step 4 and 6 to the svn directory from Step

Re: [PR] [STORM-3954] Remove Logback pulled in by Zookeeper (storm)

2023-08-16 Thread via GitHub
rzo1 commented on PR #3569: URL: https://github.com/apache/storm/pull/3569#issuecomment-1680575973 At least we will run into issues if we have logback and log4j2 in the classpath and slf4j tries to resolve it's binding. -- This is an automated message from the Apache Git Service. To

Re: [PR] [STORM-3954] Remove Logback pulled in by Zookeeper (storm)

2023-08-16 Thread via GitHub
rzo1 commented on PR #3569: URL: https://github.com/apache/storm/pull/3569#issuecomment-1680562718 I think they are still relying on slf4j or at least we can bridge (at least judging from the mailing list and the issue tracker some people switched to log4j2). If this doesn't work out well,

Re: [PR] [STORM-3953] Update releasing document. (storm)

2023-08-16 Thread via GitHub
bipinprasad commented on code in PR #3568: URL: https://github.com/apache/storm/pull/3568#discussion_r1295704590 ## RELEASING.md: ## @@ -21,41 +21,50 @@ Install an svn client, and ensure you can access the https://dist.apache.org/rep Ensure you have a signed GPG key, and

Re: [PR] [STORM-3955] Bump org.apache.maven:maven-core from 3.6.0 to 3.8.1 in /storm-buildtools/storm-maven-plugins (storm)

2023-08-16 Thread via GitHub
rzo1 merged PR #3567: URL: https://github.com/apache/storm/pull/3567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] [STORM-3950] Modernize storm-jdbc (storm)

2023-08-16 Thread via GitHub
rzo1 merged PR #3566: URL: https://github.com/apache/storm/pull/3566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] [STORM-3914] Several External Modules as not being tested for JDK 11 (storm)

2023-08-15 Thread via GitHub
bipinprasad merged PR #3561: URL: https://github.com/apache/storm/pull/3561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [STORM-3949] libthrift 0.18.1 (storm)

2023-08-15 Thread via GitHub
rzo1 commented on code in PR #3564: URL: https://github.com/apache/storm/pull/3564#discussion_r1295067635 ## DEPENDENCY-LICENSES: ## @@ -114,6 +114,7 @@ List of third-party dependencies grouped by their license type. * Apache HttpCore

[PR] [STORM-3954] Remove Logback pulled in by Zookeeper (storm)

2023-08-15 Thread via GitHub
rzo1 opened a new pull request, #3569: URL: https://github.com/apache/storm/pull/3569 ## What is the purpose of the change Zookeeper 3.9.0 pulls in logback. However, we are using slf4j + log4j2, so we can remove that dependency. Note: Some of our tests already complained about

Re: [PR] [STORM-3953] Update releasing document. (storm)

2023-08-15 Thread via GitHub
rzo1 commented on code in PR #3568: URL: https://github.com/apache/storm/pull/3568#discussion_r1295071893 ## RELEASING.md: ## @@ -21,41 +21,50 @@ Install an svn client, and ensure you can access the https://dist.apache.org/rep Ensure you have a signed GPG key, and that the

Re: [PR] [STORM-3953] Update releasing document. (storm)

2023-08-15 Thread via GitHub
rzo1 commented on code in PR #3568: URL: https://github.com/apache/storm/pull/3568#discussion_r1295074539 ## RELEASING.md: ## @@ -21,41 +21,50 @@ Install an svn client, and ensure you can access the https://dist.apache.org/rep Ensure you have a signed GPG key, and that the

[PR] [STORM-3953] Update releasing document. (storm)

2023-08-15 Thread via GitHub
bipinprasad opened a new pull request, #3568: URL: https://github.com/apache/storm/pull/3568 ## What is the purpose of the change *Update for version 2.6.0* ## How was the change tested *No code change. Very document change by viewing trasnsformed document in IntelliJ*

Re: [PR] [STORM-3949] libthrift 0.18.1 (storm)

2023-08-15 Thread via GitHub
bipinprasad commented on code in PR #3564: URL: https://github.com/apache/storm/pull/3564#discussion_r1294952064 ## DEPENDENCY-LICENSES: ## @@ -114,6 +114,7 @@ List of third-party dependencies grouped by their license type. * Apache HttpCore

[PR] Bump org.apache.maven:maven-core from 3.6.0 to 3.8.1 in /storm-buildtools/storm-maven-plugins (storm)

2023-08-15 Thread via GitHub
dependabot[bot] opened a new pull request, #3567: URL: https://github.com/apache/storm/pull/3567 Bumps [org.apache.maven:maven-core](https://github.com/apache/maven) from 3.6.0 to 3.8.1. Commits

[PR] STORM-3950 - Modernize storm-jdbc (storm)

2023-08-15 Thread via GitHub
rzo1 opened a new pull request, #3566: URL: https://github.com/apache/storm/pull/3566 ## What is the purpose of the change - Modernize external module storm-jdbc with newer dependency versions ## How was the change tested - Local test run with Maven - GH actions

Re: [PR] Update README.markdown (storm)

2023-08-15 Thread via GitHub
ddl-portal-tester closed pull request #3565: Update README.markdown URL: https://github.com/apache/storm/pull/3565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Update README.markdown (storm)

2023-08-15 Thread via GitHub
ddl-portal-tester opened a new pull request, #3565: URL: https://github.com/apache/storm/pull/3565 Some changes to make it clear that this is a test ## What is the purpose of the change *(Explain why we should have this change)* ## How was the change tested

Re: [PR] fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0 (storm)

2023-08-15 Thread via GitHub
rzo1 closed pull request #3496: fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0 URL: https://github.com/apache/storm/pull/3496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0 (storm)

2023-08-15 Thread via GitHub
rzo1 commented on PR #3496: URL: https://github.com/apache/storm/pull/3496#issuecomment-1678966913 superseeded by https://github.com/apache/storm/pull/3564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] STORM-3949 - libthrift 0.18.1 (storm)

2023-08-15 Thread via GitHub
rzo1 opened a new pull request, #3564: URL: https://github.com/apache/storm/pull/3564 ## What is the purpose of the change - Upgrade `libthrift` to 0.18.1 ## How was the change tested - Run tests locally similar to GH actions - GH actions -- This is an automated

Re: [PR] [STORM-3782] Refactor KafkaOffsetMetric to use V2 metrics (storm)

2023-08-15 Thread via GitHub
rzo1 merged PR #3404: URL: https://github.com/apache/storm/pull/3404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] [STORM-3771] Execute doCleanup in its own timer thread without lock. (storm)

2023-08-15 Thread via GitHub
rzo1 merged PR #3397: URL: https://github.com/apache/storm/pull/3397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] [STORM-3762] Set a default character set in InputStreamReader to solv… (storm)

2023-08-15 Thread via GitHub
rzo1 merged PR #3393: URL: https://github.com/apache/storm/pull/3393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15 (storm)

2023-08-15 Thread via GitHub
rzo1 closed pull request #3495: fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15 URL: https://github.com/apache/storm/pull/3495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15 (storm)

2023-08-15 Thread via GitHub
rzo1 commented on PR #3495: URL: https://github.com/apache/storm/pull/3495#issuecomment-1678554251 Included in Included in https://github.com/apache/storm/pull/3463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15 (storm)

2023-08-15 Thread via GitHub
rzo1 closed pull request #3497: fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15 URL: https://github.com/apache/storm/pull/3497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15 (storm)

2023-08-15 Thread via GitHub
rzo1 commented on PR #3497: URL: https://github.com/apache/storm/pull/3497#issuecomment-1678554142 Included in https://github.com/apache/storm/pull/3463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [STORM-3792] Change forkCount from 1 to 1.0C and reuseForks=false (storm)

2023-08-15 Thread via GitHub
rzo1 merged PR #3410: URL: https://github.com/apache/storm/pull/3410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] [STORM-3845] Update Active MQ version to 5.18.2 (storm)

2023-08-15 Thread via GitHub
rzo1 merged PR #3463: URL: https://github.com/apache/storm/pull/3463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] exclude org.glassfish.web:javax.servlet.jsp from storm-autocreds hbase-server dependency (storm)

2023-08-15 Thread via GitHub
rzo1 closed pull request #3381: exclude org.glassfish.web:javax.servlet.jsp from storm-autocreds hbase-server dependency URL: https://github.com/apache/storm/pull/3381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] exclude org.glassfish.web:javax.servlet.jsp from storm-autocreds hbase-server dependency (storm)

2023-08-15 Thread via GitHub
rzo1 commented on PR #3381: URL: https://github.com/apache/storm/pull/3381#issuecomment-1678484267 Does not happen anymore. Perhaps because the version range syntax now references an available artifact or the related transient dependency was removed due to an dependency upgrade. Closing

Re: [PR] Bump elasticsearch from 2.4.4 to 6.8.17 in /examples/storm-elasticsearch-examples (storm)

2023-08-15 Thread via GitHub
dependabot[bot] commented on PR #3483: URL: https://github.com/apache/storm/pull/3483#issuecomment-1678470608 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump elasticsearch from 2.4.4 to 6.8.17 in /examples/storm-elasticsearch-examples (storm)

2023-08-15 Thread via GitHub
rzo1 closed pull request #3483: Bump elasticsearch from 2.4.4 to 6.8.17 in /examples/storm-elasticsearch-examples URL: https://github.com/apache/storm/pull/3483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump elasticsearch from 2.4.4 to 6.8.17 in /examples/storm-elasticsearch-examples (storm)

2023-08-15 Thread via GitHub
rzo1 commented on PR #3483: URL: https://github.com/apache/storm/pull/3483#issuecomment-1678470569 duplicate, see https://github.com/apache/storm/pull/3483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [STORM-3884] Bump calcite-core from 1.14.0 to 1.32.0 (storm)

2023-08-15 Thread via GitHub
dependabot[bot] commented on PR #3491: URL: https://github.com/apache/storm/pull/3491#issuecomment-1678469878 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] [STORM-3884] Bump calcite-core from 1.14.0 to 1.32.0 (storm)

2023-08-15 Thread via GitHub
rzo1 closed pull request #3491: [STORM-3884] Bump calcite-core from 1.14.0 to 1.32.0 URL: https://github.com/apache/storm/pull/3491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [STORM-3884] Bump calcite-core from 1.14.0 to 1.32.0 (storm)

2023-08-15 Thread via GitHub
rzo1 commented on PR #3491: URL: https://github.com/apache/storm/pull/3491#issuecomment-1678469858 similar to https://github.com/apache/storm/pull/3509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [STORM-3947] Align Netty with version used in Zookeeper (storm)

2023-08-14 Thread via GitHub
rzo1 merged PR #3562: URL: https://github.com/apache/storm/pull/3562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] [STORM-3948] Hive 2.3.9 declares an offline / unmaintained maven repository (storm)

2023-08-14 Thread via GitHub
rzo1 merged PR #3563: URL: https://github.com/apache/storm/pull/3563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] [STORM-3900] Upgrade Cassandra version and Datastax to latest version 4. (storm)

2023-08-14 Thread via GitHub
bipinprasad commented on PR #3525: URL: https://github.com/apache/storm/pull/3525#issuecomment-1678275751 jvm option `-Djava.security.manager=allow` fixes the `java.lang.System.setSecurityManager` exception. There is still the error

Re: [PR] [STORM-3900] Upgrade Cassandra version and Datastax to latest version 4. (storm)

2023-08-14 Thread via GitHub
bipinprasad commented on PR #3525: URL: https://github.com/apache/storm/pull/3525#issuecomment-1678000921 I tried a few things to get the Cassandra running (like application an application.conf file) with content: `datastax-java-driver { basic.load-balancing-policy {

[PR] [STORM-3948] Hive 2.3.9 declares an offline / unmaintained maven repository (storm)

2023-08-14 Thread via GitHub
rzo1 opened a new pull request, #3563: URL: https://github.com/apache/storm/pull/3563 ## What is the purpose of the change Hive 2.3.9 declares an offline repository in its parent pom. Leading to timeouts resolving that repository during a local build. We can work around by

[PR] [STORM-3947] Align Netty with version used in Zookeeper (storm)

2023-08-14 Thread via GitHub
rzo1 opened a new pull request, #3562: URL: https://github.com/apache/storm/pull/3562 ## What is the purpose of the change - Aligns netty with version provided by Zookeeper ## How was the change tested - GH actions -- This is an automated message from the Apache Git

Re: [PR] [STORM-3900] Upgrade Cassandra version and Datastax to latest version 4. (storm)

2023-08-14 Thread via GitHub
rzo1 commented on PR #3525: URL: https://github.com/apache/storm/pull/3525#issuecomment-1677002385 @jnioche Maybe you can also have a look here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [STORM-3900] Upgrade Cassandra version and Datastax to latest version 4. (storm)

2023-08-14 Thread via GitHub
rzo1 commented on PR #3525: URL: https://github.com/apache/storm/pull/3525#issuecomment-1676955659 After some more digging: It seems, that our current driver configuration in the main code isn't fully complete, so the tests are failing subsequently. However, the test setup should now be

Re: [PR] [STORM-3900] Upgrade Cassandra version and Datastax to latest version 4. (storm)

2023-08-14 Thread via GitHub
rzo1 commented on PR #3525: URL: https://github.com/apache/storm/pull/3525#issuecomment-1676845468 I did some additional modifications. The current tests are executable on that branch but will crash as the cassandra driver cannot connect to the local cassandra instance ```bash

Re: [PR] [STORM-3900] Upgrade Cassandra version and Datastax to latest version 4. (storm)

2023-08-14 Thread via GitHub
rzo1 commented on PR #3525: URL: https://github.com/apache/storm/pull/3525#issuecomment-1676753588 It works in Java 11 because we [excluded](https://issues.apache.org/jira/browse/STORM-3914) the related tests from being run in Java 11. I am having a look now. -- This is an automated

[PR] [STORM-3914] Several External Modules as not being tested for JDK 11 (storm)

2023-08-14 Thread via GitHub
rzo1 opened a new pull request, #3561: URL: https://github.com/apache/storm/pull/3561 ## What is the purpose of the change - We are testing everything for Java 17, so we should also test everything with Java 11 ## How was the change tested - Run GH actions -- This is

Re: [PR] [STORM-3900] Upgrade Cassandra version and Datastax to latest version 4. (storm)

2023-08-10 Thread via GitHub
rzo1 commented on PR #3525: URL: https://github.com/apache/storm/pull/3525#issuecomment-1673165667 Hey @bipinprasad it seems, that the Cassandra update has some problems with Java 17 as the related tests are crashing (multple runs). Do you want to have a look yourself or shall I

Re: [PR] [STORM-3924] Support for declaring WorkerHook in Flux topology definitions (storm)

2023-08-10 Thread via GitHub
rzo1 commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1673129538 I did the rebase / merge, so we get new CI results. Your changes shouldn't affect the license files, so we are good to move forwards soon. Thanks for this contribution! -- This is an

Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)

2023-08-10 Thread via GitHub
rzo1 commented on code in PR #3554: URL: https://github.com/apache/storm/pull/3554#discussion_r1290048620 ## storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java: ## Review Comment: Exception needs to be removed from `throws` -- This is an

Re: [PR] [STORM-3901] Upgrade Kryo to version 5.4.0 and remove reflectasm-shaded (storm)

2023-08-10 Thread via GitHub
rzo1 commented on PR #3526: URL: https://github.com/apache/storm/pull/3526#issuecomment-1673071586 Short update on kryo5 (lib variant): We can not simply switch because of packaging changes impacting carbonite and chill-java (method signatures won't match), so not a thing as of today to

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.9.0 & Curator 5.5.0 (storm)

2023-08-10 Thread via GitHub
rzo1 merged PR #3560: URL: https://github.com/apache/storm/pull/3560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] [STORM-3924] Support for declaring WorkerHook in Flux topology definitions (storm)

2023-08-10 Thread via GitHub
rzo1 commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1672873056 Any chance you can rebase @6harat ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [STORM-3800] fix resource leak due to Files.walk Files.list (storm)

2023-08-10 Thread via GitHub
rzo1 merged PR #3416: URL: https://github.com/apache/storm/pull/3416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] [STORM-3800] fix resource leak due to Files.walk Files.list (storm)

2023-08-10 Thread via GitHub
jnioche commented on PR #3416: URL: https://github.com/apache/storm/pull/3416#issuecomment-1672759233 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks (storm)

2023-08-10 Thread via GitHub
jnioche commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1672749176 Thanks @6harat, this is a great contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks (storm)

2023-08-10 Thread via GitHub
jnioche merged PR #3547: URL: https://github.com/apache/storm/pull/3547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-10 Thread via GitHub
rzo1 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1289613565 ## storm-client/src/jvm/org/apache/storm/utils/CuratorUtils.java: ## @@ -75,29 +72,7 @@ public List getAclForPath(String s) { protected static void

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-10 Thread via GitHub
rzo1 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1289613346 ## pom.xml: ## @@ -319,7 +319,8 @@ 1.7.36 3.2.6 4.11.0 -3.5.9 +3.8.2 Review Comment: I updated to 3.9.0 - let's see, if the

Re: [PR] [STORM-3901] Upgrade Kryo to version 5.4.0 and remove reflectasm-shaded (storm)

2023-08-09 Thread via GitHub
bipinprasad commented on PR #3526: URL: https://github.com/apache/storm/pull/3526#issuecomment-1671733875 Thanks. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [STORM-3901] Upgrade Kryo to version 5.4.0 and remove reflectasm-shaded (storm)

2023-08-09 Thread via GitHub
bipinprasad merged PR #3526: URL: https://github.com/apache/storm/pull/3526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [STORM-3901] Upgrade Kryo to version 5.4.0 and remove reflectasm-shaded (storm)

2023-08-09 Thread via GitHub
rzo1 commented on PR #3526: URL: https://github.com/apache/storm/pull/3526#issuecomment-1671693360 I cleaned it up, so we are mergable again. However, I want to check if we better use the kyro5 artifact as shade replacement: https://groups.google.com/g/kryo-users/c/hVlwHmBE_-s

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
rzo1 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288790275 ## storm-client/src/jvm/org/apache/storm/utils/CuratorUtils.java: ## @@ -75,29 +72,7 @@ public List getAclForPath(String s) { protected static void

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
rzo1 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288789046 ## storm-client/src/jvm/org/apache/storm/utils/CuratorUtils.java: ## @@ -75,29 +72,7 @@ public List getAclForPath(String s) { protected static void

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
agresch commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288728408 ## storm-client/src/jvm/org/apache/storm/utils/CuratorUtils.java: ## @@ -75,29 +72,7 @@ public List getAclForPath(String s) { protected static void

Re: [PR] [STORM-3884] Update calcite to 1.16.0 (storm)

2023-08-09 Thread via GitHub
rzo1 merged PR #3510: URL: https://github.com/apache/storm/pull/3510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
rzo1 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288249155 ## pom.xml: ## @@ -319,7 +319,8 @@ 1.7.36 3.2.6 4.11.0 -3.5.9 +3.8.2 Review Comment: Curator still builds against 3.7.x but I

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
rzo1 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288249155 ## pom.xml: ## @@ -319,7 +319,8 @@ 1.7.36 3.2.6 4.11.0 -3.5.9 +3.8.2 Review Comment: Curator still builds against 3.7.x --

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
rzo1 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288249155 ## pom.xml: ## @@ -319,7 +319,8 @@ 1.7.36 3.2.6 4.11.0 -3.5.9 +3.8.2 Review Comment: Curator still builds against 3.8.x --

Re: [PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
aishwaryasoni1991 commented on code in PR #3560: URL: https://github.com/apache/storm/pull/3560#discussion_r1288246796 ## pom.xml: ## @@ -319,7 +319,8 @@ 1.7.36 3.2.6 4.11.0 -3.5.9 +3.8.2 Review Comment: The Zookeeper community has

[PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)

2023-08-09 Thread via GitHub
rzo1 opened a new pull request, #3560: URL: https://github.com/apache/storm/pull/3560 ## What is the purpose of the change - Replace EOL Zookeeper with modern Zookeeper version. - Updates Curator - Note: Exhibitor support is dropped in modern curator -- This is an automated

Re: [PR] [STORM-3944] Synchronize access to map in Multi*Metric (storm)

2023-08-08 Thread via GitHub
jnioche merged PR #3559: URL: https://github.com/apache/storm/pull/3559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [STORM-3944] Synchronize access to map in Multi*Metric (storm)

2023-08-08 Thread via GitHub
jnioche commented on PR #3559: URL: https://github.com/apache/storm/pull/3559#issuecomment-1669688708 > If the title is changed to this format then the release tools can properly detect the linkage between Jira and PR (at release time): > > [STORM-3944] Synchronize access to map in

Re: [PR] Test (storm)

2023-08-08 Thread via GitHub
rzo1 closed pull request #3489: Test URL: https://github.com/apache/storm/pull/3489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Synchronize access to map in Multi*Metric; fixes STORM-3944 (storm)

2023-08-08 Thread via GitHub
jnioche opened a new pull request, #3559: URL: https://github.com/apache/storm/pull/3559 See https://issues.apache.org/jira/browse/STORM-3944 Also marks fields as final -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

<    1   2   3   4   5   6   7   >