Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)

2023-08-07 Thread via GitHub
rzo1 commented on PR #3554: URL: https://github.com/apache/storm/pull/3554#issuecomment-1667646679 Can you rebase @LoggingResearch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [STORM-3939] Remove gitact build for JDK 8, set class format to JDK11 and allow introspection in test (storm)

2023-08-07 Thread via GitHub
rzo1 merged PR #3558: URL: https://github.com/apache/storm/pull/3558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

[GitHub] [storm-site] dependabot[bot] closed pull request #43: Bump tzinfo from 1.2.4 to 1.2.11 in /content

2023-08-04 Thread via GitHub
dependabot[bot] closed pull request #43: Bump tzinfo from 1.2.4 to 1.2.11 in /content URL: https://github.com/apache/storm-site/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [storm-site] dependabot[bot] commented on pull request #43: Bump tzinfo from 1.2.4 to 1.2.11 in /content

2023-08-04 Thread via GitHub
dependabot[bot] commented on PR #43: URL: https://github.com/apache/storm-site/pull/43#issuecomment-1666166315 Looks like tzinfo is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [storm-site] dependabot[bot] closed pull request #44: Bump nokogiri from 1.13.3 to 1.15.3 in /content

2023-08-04 Thread via GitHub
dependabot[bot] closed pull request #44: Bump nokogiri from 1.13.3 to 1.15.3 in /content URL: https://github.com/apache/storm-site/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [storm-site] dependabot[bot] commented on pull request #44: Bump nokogiri from 1.13.3 to 1.15.3 in /content

2023-08-04 Thread via GitHub
dependabot[bot] commented on PR #44: URL: https://github.com/apache/storm-site/pull/44#issuecomment-1666166117 Looks like nokogiri is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [storm-site] rzo1 merged pull request #40: Remove 3rd party hosted content from storm.apache.org

2023-08-04 Thread via GitHub
rzo1 merged PR #40: URL: https://github.com/apache/storm-site/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

[GitHub] [storm-site] bipinprasad merged pull request #42: Storm 2.5.0 release - generate and add documents

2023-08-04 Thread via GitHub
bipinprasad merged PR #42: URL: https://github.com/apache/storm-site/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm-site] rzo1 merged pull request #35: Update meetups.yml

2023-08-04 Thread via GitHub
rzo1 merged PR #35: URL: https://github.com/apache/storm-site/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

[GitHub] [storm] rzo1 merged pull request #3557: STORM-3941 - Add .asf.yaml to GitHub repository

2023-08-04 Thread via GitHub
rzo1 merged PR #3557: URL: https://github.com/apache/storm/pull/3557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

[GitHub] [storm-site] rzo1 commented on pull request #40: Remove 3rd party hosted content from storm.apache.org

2023-08-04 Thread via GitHub
rzo1 commented on PR #40: URL: https://github.com/apache/storm-site/pull/40#issuecomment-1666083450 Resolved conflicts after dependency updates from #41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [storm-site] dependabot[bot] closed pull request #38: Bump nokogiri from 1.13.3 to 1.14.3 in /content

2023-08-04 Thread via GitHub
dependabot[bot] closed pull request #38: Bump nokogiri from 1.13.3 to 1.14.3 in /content URL: https://github.com/apache/storm-site/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [storm-site] dependabot[bot] opened a new pull request, #44: Bump nokogiri from 1.13.3 to 1.15.3 in /content

2023-08-04 Thread via GitHub
dependabot[bot] opened a new pull request, #44: URL: https://github.com/apache/storm-site/pull/44 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.3 to 1.15.3. Release notes Sourced from https://github.com/sparklemotion/nokogiri/releases;>nokogiri's releases.

[GitHub] [storm-site] dependabot[bot] commented on pull request #38: Bump nokogiri from 1.13.3 to 1.14.3 in /content

2023-08-04 Thread via GitHub
dependabot[bot] commented on PR #38: URL: https://github.com/apache/storm-site/pull/38#issuecomment-1666028716 Superseded by #44. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [storm-site] dependabot[bot] closed pull request #34: Bump tzinfo from 1.2.4 to 1.2.10 in /content

2023-08-04 Thread via GitHub
dependabot[bot] closed pull request #34: Bump tzinfo from 1.2.4 to 1.2.10 in /content URL: https://github.com/apache/storm-site/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [storm-site] dependabot[bot] commented on pull request #34: Bump tzinfo from 1.2.4 to 1.2.10 in /content

2023-08-04 Thread via GitHub
dependabot[bot] commented on PR #34: URL: https://github.com/apache/storm-site/pull/34#issuecomment-1666025538 Superseded by #43. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [storm-site] dependabot[bot] opened a new pull request, #43: Bump tzinfo from 1.2.4 to 1.2.11 in /content

2023-08-04 Thread via GitHub
dependabot[bot] opened a new pull request, #43: URL: https://github.com/apache/storm-site/pull/43 Bumps [tzinfo](https://github.com/tzinfo/tzinfo) from 1.2.4 to 1.2.11. Release notes Sourced from https://github.com/tzinfo/tzinfo/releases;>tzinfo's releases. v1.2.11

[GitHub] [storm-site] dependabot[bot] closed pull request #39: Bump nokogiri from 1.13.3 to 1.14.3

2023-08-04 Thread via GitHub
dependabot[bot] closed pull request #39: Bump nokogiri from 1.13.3 to 1.14.3 URL: https://github.com/apache/storm-site/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [storm-site] dependabot[bot] commented on pull request #39: Bump nokogiri from 1.13.3 to 1.14.3

2023-08-04 Thread via GitHub
dependabot[bot] commented on PR #39: URL: https://github.com/apache/storm-site/pull/39#issuecomment-1666023600 Looks like nokogiri is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [storm-site] bipinprasad commented on pull request #39: Bump nokogiri from 1.13.3 to 1.14.3

2023-08-04 Thread via GitHub
bipinprasad commented on PR #39: URL: https://github.com/apache/storm-site/pull/39#issuecomment-1666023309 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [storm-site] dependabot[bot] closed pull request #33: Bump tzinfo from 1.2.4 to 1.2.10

2023-08-04 Thread via GitHub
dependabot[bot] closed pull request #33: Bump tzinfo from 1.2.4 to 1.2.10 URL: https://github.com/apache/storm-site/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [storm-site] dependabot[bot] commented on pull request #33: Bump tzinfo from 1.2.4 to 1.2.10

2023-08-04 Thread via GitHub
dependabot[bot] commented on PR #33: URL: https://github.com/apache/storm-site/pull/33#issuecomment-1666022821 Looks like tzinfo is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [storm-site] bipinprasad commented on pull request #33: Bump tzinfo from 1.2.4 to 1.2.10

2023-08-04 Thread via GitHub
bipinprasad commented on PR #33: URL: https://github.com/apache/storm-site/pull/33#issuecomment-1666022510 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [storm-site] bipinprasad opened a new pull request, #42: Storm 2.5.0 release - generate and add documents

2023-08-04 Thread via GitHub
bipinprasad opened a new pull request, #42: URL: https://github.com/apache/storm-site/pull/42 Also move current symbolic link -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [storm-site] bipinprasad merged pull request #41: Upgrade ruby, bundler, github-pages, jekyll, add webrick dependency.

2023-08-04 Thread via GitHub
bipinprasad merged PR #41: URL: https://github.com/apache/storm-site/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm-site] bipinprasad opened a new pull request, #41: Upgrade ruby, bundler, github-pages, jekyll, add webrick dependency.

2023-08-04 Thread via GitHub
bipinprasad opened a new pull request, #41: URL: https://github.com/apache/storm-site/pull/41 In order to use ruby3, jekyll, github-pages and webrick. Tested by running "bundle exec jekyll serve -w --incremental" -- This is an automated message from the Apache Git Service. To

[GitHub] [storm] 6harat commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions

2023-08-04 Thread via GitHub
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1665297205 will rebase and check it out over the weekend -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [storm] rzo1 commented on pull request #3558: [STORM-3939] Remove gitact build for JDK 8, set class format to JDK11 and allow introspection in test

2023-08-03 Thread via GitHub
rzo1 commented on PR #3558: URL: https://github.com/apache/storm/pull/3558#issuecomment-166774 Aside from needed a rebase after release, it looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [storm] rzo1 commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions

2023-08-03 Thread via GitHub
rzo1 commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1664435945 @6harat Can you try a rebase? So we can find out why the license file checks fail on your branch? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [storm-site] rzo1 commented on pull request #40: Remove 3rd party hosted content from storm.apache.org

2023-08-03 Thread via GitHub
rzo1 commented on PR #40: URL: https://github.com/apache/storm-site/pull/40#issuecomment-1663948118 There are some other things, which can be improved in subsequent and better reviewable PRs: - Updating JS libs used - Unify asset folder (atm we have different locations, making it

[GitHub] [storm-site] rzo1 commented on a diff in pull request #40: Remove 3rd party hosted content from storm.apache.org

2023-08-03 Thread via GitHub
rzo1 commented on code in PR #40: URL: https://github.com/apache/storm-site/pull/40#discussion_r1283155075 ## content/about/scalable.html: ## @@ -16,7 +16,7 @@ -https://fortawesome.github.io/Font-Awesome/assets/font-awesome/css/font-awesome.css;> + Review

[GitHub] [storm] bipinprasad opened a new pull request, #3558: [STORM-3939] Remove gitact build for JDK 8, set class format to JDK11 and allow introspection in test

2023-08-02 Thread via GitHub
bipinprasad opened a new pull request, #3558: URL: https://github.com/apache/storm/pull/3558 ## What is the purpose of the change *Drop support for JDK8, set minimum JDK level to 11 - in order for new JDK and packaging features to be used* ## How was the change tested

[GitHub] [storm] jnioche merged pull request #3556: Missing dependency prevents Storm from being built, fixes #3940

2023-08-02 Thread via GitHub
jnioche merged PR #3556: URL: https://github.com/apache/storm/pull/3556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm-site] rzo1 opened a new pull request, #40: Remove 3rd party hosted content from storm.apache.org

2023-08-02 Thread via GitHub
rzo1 opened a new pull request, #40: URL: https://github.com/apache/storm-site/pull/40 # What does this PR do? - Removes Twitter assets - Doesn't work anymore anyway - Violates ASF Privacy Policy - Removes external loading of font-awesome 4 from non-existing sources

[GitHub] [storm] rzo1 opened a new pull request, #3557: STORM-3941 - Add .asf.yaml to GitHub repository

2023-08-02 Thread via GitHub
rzo1 opened a new pull request, #3557: URL: https://github.com/apache/storm/pull/3557 ## What is the purpose of the change - Adds an `.asf.yaml` for GitHub configuration. - Updates the titles of the auto generated messages from GitHub like described in

[GitHub] [storm] rzo1 commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-08-02 Thread via GitHub
rzo1 commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1661608128 Guess we can include this after 2.5.0 vote is over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [storm] rzo1 commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions

2023-08-02 Thread via GitHub
rzo1 commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1661607392 @6harat triggered the workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [storm] bipinprasad commented on pull request #3556: Missing dependency prevents Storm from being built, fixes #3940

2023-08-01 Thread via GitHub
bipinprasad commented on PR #3556: URL: https://github.com/apache/storm/pull/3556#issuecomment-1660768551 storm builds on all pull requests under github actions currently. However, I think it is better to consistent in excluding this dependency. -- This is an automated message from the

[GitHub] [storm] rzo1 commented on pull request #3556: Missing dependency prevents Storm from being built, fixes #3940

2023-08-01 Thread via GitHub
rzo1 commented on PR #3556: URL: https://github.com/apache/storm/pull/3556#issuecomment-1660648311 > This artifact is available on maven central. Is there a need to exclude it? https://mvnrepository.com/artifact/org.pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde I think, that the

[GitHub] [storm] bipinprasad commented on pull request #3556: Missing dependency prevents Storm from being built, fixes #3940

2023-08-01 Thread via GitHub
bipinprasad commented on PR #3556: URL: https://github.com/apache/storm/pull/3556#issuecomment-1660419649 This artifact is available on maven central. Is there a need to exclude it? https://mvnrepository.com/artifact/org.pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde -- This is an

[GitHub] [storm] jnioche opened a new pull request, #3556: Missing dependency prevents Storm from being built, fixes #3940

2023-08-01 Thread via GitHub
jnioche opened a new pull request, #3556: URL: https://github.com/apache/storm/pull/3556 ## What is the purpose of the change Storm can't be built because the dependency pentaho-aggdesigner-algorithm is not available.  This dependency is excluded in some places of the poms but

[GitHub] [storm] bipinprasad merged pull request #3555: [STORM-3895] Add JDK-17 build

2023-07-31 Thread via GitHub
bipinprasad merged PR #3555: URL: https://github.com/apache/storm/pull/3555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] bipinprasad commented on pull request #3555: [STORM-3895] Add JDK-17 build

2023-07-27 Thread via GitHub
bipinprasad commented on PR #3555: URL: https://github.com/apache/storm/pull/3555#issuecomment-1654447554 For some reason, under openjdk-17, the license file is much smaller (and different) from that generated under jdk8 and jdk11. Wondering is this is related to strict isolation of

[GitHub] [storm] agresch commented on a diff in pull request #3555: [STORM-3895] Add JDK-17 build

2023-07-27 Thread via GitHub
agresch commented on code in PR #3555: URL: https://github.com/apache/storm/pull/3555#discussion_r1276602250 ## storm-server/pom.xml: ## @@ -169,6 +169,8 @@ maven-surefire-plugin 1 + Review Comment:

[GitHub] [storm] avermeer commented on pull request #3555: [STORM-3895] Add JDK-17 build

2023-07-27 Thread via GitHub
avermeer commented on PR #3555: URL: https://github.com/apache/storm/pull/3555#issuecomment-1653001618 Very good initiative, thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [storm] bipinprasad opened a new pull request, #3555: [STORM-3895] Add JDK-17 build

2023-07-26 Thread via GitHub
bipinprasad opened a new pull request, #3555: URL: https://github.com/apache/storm/pull/3555 ## What is the purpose of the change *Add JDK-17 Build* ## How was the change tested *Let the github actions run* -- This is an automated message from the Apache Git Service.

[GitHub] [storm] 6harat commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions

2023-07-23 Thread via GitHub
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1647188305 @bipinprasad just pushed a README update commit, the prev workflow was already successful, so triggering it again might not be reqd. Please let me know if anything else is required from my

[GitHub] [storm] 6harat commented on a diff in pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions

2023-07-23 Thread via GitHub
6harat commented on code in PR #3546: URL: https://github.com/apache/storm/pull/3546#discussion_r1271728650 ## docs/flux.md: ## @@ -765,6 +770,16 @@ The `override` property controls how includes affect the values defined in the c **N.B.:** Includes are not yet recursive.

[GitHub] [storm] 6harat commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-07-23 Thread via GitHub
6harat commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1647184755 @bipinprasad please let me know if anything else is required for going ahead with merge -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [storm] LoggingResearch opened a new pull request, #3554: [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(…

2023-07-22 Thread via GitHub
LoggingResearch opened a new pull request, #3554: URL: https://github.com/apache/storm/pull/3554 ## What is the purpose of the change This PR addresses the handling of InterruptedException in the close() method of the Supervisor class. The changes include: Adding a separate

[GitHub] [storm] LoggingResearch closed pull request #3553: Handle InterruptedException in Supervisor close() method.

2023-07-22 Thread via GitHub
LoggingResearch closed pull request #3553: Handle InterruptedException in Supervisor close() method. URL: https://github.com/apache/storm/pull/3553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [storm] LoggingResearch opened a new pull request, #3553: Handle InterruptedException in Supervisor close() method.

2023-07-17 Thread via GitHub
LoggingResearch opened a new pull request, #3553: URL: https://github.com/apache/storm/pull/3553 ## What is the purpose of the change This PR addresses the handling of InterruptedException in the close() method of the Supervisor class. The changes include: 1. Adding a separate

[GitHub] [storm] bipinprasad merged pull request #3552: [STORM-3930] Change the source code control URI

2023-07-06 Thread via GitHub
bipinprasad merged PR #3552: URL: https://github.com/apache/storm/pull/3552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] bipinprasad opened a new pull request, #3552: [STORM-3930] Change the source code control URI

2023-07-06 Thread via GitHub
bipinprasad opened a new pull request, #3552: URL: https://github.com/apache/storm/pull/3552 …d update the uri from gitbox to github ## What is the purpose of the change *While doing "mvm perform", the checkout times out at the end when using the https connection. Also the url

[GitHub] [storm] bipinprasad merged pull request #3549: [STORM-3927] Change python to python3 in examples

2023-07-01 Thread via GitHub
bipinprasad merged PR #3549: URL: https://github.com/apache/storm/pull/3549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] bipinprasad commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-06-30 Thread via GitHub
bipinprasad commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1614815685 Triggered workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [storm] bipinprasad merged pull request #3550: [STORM-3928] Use python3 in flux test, examples and wrappers

2023-06-30 Thread via GitHub
bipinprasad merged PR #3550: URL: https://github.com/apache/storm/pull/3550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] bipinprasad merged pull request #3551: [STORM-3929] Update documentation to refer to python3

2023-06-30 Thread via GitHub
bipinprasad merged PR #3551: URL: https://github.com/apache/storm/pull/3551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] bipinprasad merged pull request #3548: [STORM-3926] Require python3 for bin/storm

2023-06-30 Thread via GitHub
bipinprasad merged PR #3548: URL: https://github.com/apache/storm/pull/3548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] bipinprasad opened a new pull request, #3551: [STORM-3929] Update documentation to refer to python3

2023-06-29 Thread via GitHub
bipinprasad opened a new pull request, #3551: URL: https://github.com/apache/storm/pull/3551 ## What is the purpose of the change *Python2 has been deprecated and removed Storm 2.5.0. Update documentation to reflect this change.* ## How was the change tested *Render

[GitHub] [storm] bipinprasad opened a new pull request, #3550: [STORM-3928] Use python3 in flux test, examples and wrappers

2023-06-29 Thread via GitHub
bipinprasad opened a new pull request, #3550: URL: https://github.com/apache/storm/pull/3550 ## What is the purpose of the change *Python2 has been deprecated. However many systems still activate python2 when only using python. Change it to python3 to ensure Python version 3 is

[GitHub] [storm] bipinprasad opened a new pull request, #3549: [STORM-3927] Change python to python3 in examples

2023-06-29 Thread via GitHub
bipinprasad opened a new pull request, #3549: URL: https://github.com/apache/storm/pull/3549 ## What is the purpose of the change *Python2 has been deprecated. However many systems still activate python2 when only using python. Change it to python3 to ensure Python version 3 is

[GitHub] [storm] rzo1 commented on a diff in pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions

2023-06-29 Thread via GitHub
rzo1 commented on code in PR #3546: URL: https://github.com/apache/storm/pull/3546#discussion_r1246591112 ## docs/flux.md: ## @@ -765,6 +770,16 @@ The `override` property controls how includes affect the values defined in the c **N.B.:** Includes are not yet recursive.

[GitHub] [storm] rzo1 commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-06-25 Thread via GitHub
rzo1 commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1605965102 @6harat i am no committer on Storm, so nö karma to do so ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [storm] 6harat commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-06-25 Thread via GitHub
6harat commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1605948131 @bipinprasad @rzo1 could you please help trigger the workflow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [storm] 6harat commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions

2023-06-25 Thread via GitHub
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1605932509 > I was going through other parts of the code and found this TODO. Seems like it was intended to be connected to WorkerHooks when those were first introduced. > > ``` >

[GitHub] [storm] bipinprasad merged pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-20 Thread via GitHub
bipinprasad merged PR #3540: URL: https://github.com/apache/storm/pull/3540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] 6harat commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-06-20 Thread via GitHub
6harat commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1599002790 Pending tasks: 1. Add feature tests 2. Update documentation / comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [storm] bipinprasad commented on pull request #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions

2023-06-19 Thread via GitHub
bipinprasad commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1597358946 Activated the checks. There may be some PMD exceptions - that can be checked locally as "mvn pmd:check" -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [storm] bipinprasad merged pull request #3545: [STORM-3923] Increase MAVEN_OPTS max memory setting to 2gb

2023-06-19 Thread via GitHub
bipinprasad merged PR #3545: URL: https://github.com/apache/storm/pull/3545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] 6harat commented on pull request #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions

2023-06-18 Thread via GitHub
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1596224842 I was going through other parts of the code and found this TODO. Seems like it was intended to be connected to WorkerHooks when those were first introduced. ``` private Map

[GitHub] [storm] 6harat commented on pull request #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions

2023-06-17 Thread via GitHub
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1595677853 Please note the following observations / callouts: 1. have not added workerHoosk to executioncontext. AFAIS constructed spouts and bolts are being stored here so as to allow creation

[GitHub] [storm] 6harat opened a new pull request, #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions

2023-06-17 Thread via GitHub
6harat opened a new pull request, #3546: URL: https://github.com/apache/storm/pull/3546 ## What is the purpose of the change A while back the support for declaring WorkerHook in TopologyBuilder was added. Related JIRA: https://issues.apache.org/jira/browse/STORM-126. This change

[GitHub] [storm] bipinprasad opened a new pull request, #3545: [STORM-3923] Increase MAVEN_OPTS max memory setting to 2gb

2023-06-16 Thread via GitHub
bipinprasad opened a new pull request, #3545: URL: https://github.com/apache/storm/pull/3545 ## What is the purpose of the change *Storm Cassandra (external/storm-cassandra) test fail because OOM* ## How was the code tested *Git Actions build and test run as part of this

[GitHub] [storm] bipinprasad merged pull request #3544: [STORM-3922] Acker scheduling changes.

2023-06-13 Thread via GitHub
bipinprasad merged PR #3544: URL: https://github.com/apache/storm/pull/3544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] bipinprasad opened a new pull request, #3544: [STORM-3922] Acker scheduling changes.

2023-06-12 Thread via GitHub
bipinprasad opened a new pull request, #3544: URL: https://github.com/apache/storm/pull/3544 ## What is the purpose of the change *Acker executors are sorted in a specific order that backtracking needs to account for.* ## How was the change tested *This code has been

[GitHub] [storm] agresch commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-07 Thread via GitHub
agresch commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1221809229 ## storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java: ## @@ -527,13 +538,13 @@ protected

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1220355853 ## storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java: ## @@ -527,13 +538,13 @@ protected

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1220322597 ## storm-client/src/jvm/org/apache/storm/Config.java: ## @@ -859,9 +859,11 @@ public class Config extends HashMap { @IsString public static final String

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1220291317 ## storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java: ## @@ -164,6 +168,7 @@ public

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1220277226 ## storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java: ## @@ -123,6 +123,10 @@ public

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1219931053 ## storm-client/src/jvm/org/apache/storm/Config.java: ## @@ -859,9 +859,11 @@ public class Config extends HashMap { @IsString public static final String

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1219927539 ## storm-client/src/jvm/org/apache/storm/Config.java: ## @@ -859,9 +859,11 @@ public class Config extends HashMap { @IsString public static final String

[GitHub] [storm] agresch commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-05 Thread via GitHub
agresch commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1218307249 ## storm-client/src/jvm/org/apache/storm/Config.java: ## @@ -859,9 +859,11 @@ public class Config extends HashMap { @IsString public static final String

[GitHub] [storm] bipinprasad merged pull request #3538: [STORM-3921] Bump spring-core from 5.3.26 to 5.3.27 in /examples/storm-jms-examples

2023-06-02 Thread via GitHub
bipinprasad merged PR #3538: URL: https://github.com/apache/storm/pull/3538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] bipinprasad commented on a diff in pull request #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced

2023-06-01 Thread via GitHub
bipinprasad commented on code in PR #3536: URL: https://github.com/apache/storm/pull/3536#discussion_r1213687480 ## storm-core/pom.xml: ## @@ -137,6 +137,7 @@ org.mockito mockito-core +${mockito.version} Review Comment:

[GitHub] [storm] agresch commented on a diff in pull request #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced

2023-06-01 Thread via GitHub
agresch commented on code in PR #3536: URL: https://github.com/apache/storm/pull/3536#discussion_r1213655650 ## storm-core/pom.xml: ## @@ -137,6 +137,7 @@ org.mockito mockito-core +${mockito.version} Review Comment: why was

[GitHub] [storm] bipinprasad merged pull request #3535: [STORM-3910] Enhanced logging for rocksdb metrics store.

2023-06-01 Thread via GitHub
bipinprasad merged PR #3535: URL: https://github.com/apache/storm/pull/3535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm-site] ScottBrenner commented on pull request #35: Update meetups.yml

2023-05-26 Thread via GitHub
ScottBrenner commented on PR #35: URL: https://github.com/apache/storm-site/pull/35#issuecomment-1565183279 @bipinprasad please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [storm] vesense commented on pull request #3543: STORM-3920 Update security document

2023-05-22 Thread via GitHub
vesense commented on PR #3543: URL: https://github.com/apache/storm/pull/3543#issuecomment-1557058816 Thanks @snikhil5 Merged into master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [storm] vesense merged pull request #3543: STORM-3920 Update security document

2023-05-22 Thread via GitHub
vesense merged PR #3543: URL: https://github.com/apache/storm/pull/3543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] snikhil5 opened a new pull request, #3543: STORM-3920 Update security document

2023-05-18 Thread via GitHub
snikhil5 opened a new pull request, #3543: URL: https://github.com/apache/storm/pull/3543 ## What is the purpose of the change Update the document for setting up secure cluster ## How was the change tested Tested on a secure cluster -- This is an automated message from

[GitHub] [storm] vesense commented on pull request #3542: [STORM-3917] Remove explicit worker heap size in ThroughputVsLatency

2023-05-12 Thread via GitHub
vesense commented on PR #3542: URL: https://github.com/apache/storm/pull/3542#issuecomment-1545705349 Thanks @jmartell7 Merged into master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [storm] vesense merged pull request #3542: [STORM-3917] Remove explicit worker heap size in ThroughputVsLatency

2023-05-12 Thread via GitHub
vesense merged PR #3542: URL: https://github.com/apache/storm/pull/3542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] jmartell7 opened a new pull request, #3542: Remove explicit worker heap size in ThroughputVsLatency

2023-05-08 Thread via GitHub
jmartell7 opened a new pull request, #3542: URL: https://github.com/apache/storm/pull/3542 Allow users to change worker heap size in ThroughputVsLatency example topo. ## What is the purpose of the change ThroughputVsLatency adds an explicit 2GB worker heapsize overriding the

[GitHub] [storm] agresch merged pull request #3541: Fix infinite loop when no files are left to remove

2023-05-04 Thread via GitHub
agresch merged PR #3541: URL: https://github.com/apache/storm/pull/3541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] jmartell7 opened a new pull request, #3541: Fix infinite loop when no files are left to remove

2023-05-03 Thread via GitHub
jmartell7 opened a new pull request, #3541: URL: https://github.com/apache/storm/pull/3541 ## What is the purpose of the change An infinite loop can occur when the worker directory takes too much space, but no files are found to remove. ## How was the change tested I have not

[GitHub] [storm] bipinprasad opened a new pull request, #3540: [STORM-3916] Add Round Robin Scheduling stretgy with optional node li…

2023-05-03 Thread via GitHub
bipinprasad opened a new pull request, #3540: URL: https://github.com/apache/storm/pull/3540 …mit. ## What is the purpose of the change *Round Robin strategy will distribute components evenly across nodes. Default behavior will be to spread across all nodes. But can be limited

[GitHub] [storm] bipinprasad merged pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-05-01 Thread via GitHub
bipinprasad merged PR #3539: URL: https://github.com/apache/storm/pull/3539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [storm] bipinprasad commented on pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-05-01 Thread via GitHub
bipinprasad commented on PR #3539: URL: https://github.com/apache/storm/pull/3539#issuecomment-1529862186 storm-cassandra test failure will be fixed in a separate Jira https://issues.apache.org/jira/browse/STORM-3915 -- This is an automated message from the Apache Git Service. To respond

<    1   2   3   4   5   6   7   >