Re: [DISCUSS] Adopt pull request template

Sorry I got lost this thread. I think we agree abort guiding PR title. I have some more suggestions: - target branch: it should be 'master' unless the patch is only affect on that branch version line - link to DEVELOPER.md: to remind how to contribute - tests (build passed on local? tested

Re: [DISCUSS] Adopt pull request template

Agree! My suggestions are not all or nothing. They are a set of ideas of which we can pick some. In the cases of multiple commits, I would suggest that we try to make it that all of them start with the same title STORM-XXX, such that it’s easily eye catching. That’s what lead to my suggestion

Re: [DISCUSS] Adopt pull request template

I am ok with adopting templates but lets keep this process simpler. We've new contributors coming in and they probably didn't have chance to go through process. We can guide them through the process or have strict template that everyone needs to adopt to. I don't think having

Re: [DISCUSS] Adopt pull request template

I am strongly +1. In addition to the templates suggested by Jungtaek, in the past I suggested the template bellow to a different project. It is a bit simpler than the ones listed, as I think it may be too demanding to ask people to categorize in the git message the type of contribution the

Re: [DISCUSS] Adopt pull request template

+1 for adopting a template. Not sure if it is possible, but I wouldn't mind eyeing the same for JIRA. -Taylor > On Jan 18, 2017, at 9:10 PM, Jungtaek Lim wrote: > > Hi devs, > > I have seen some pull requests which are not having JIRA issue, or bad > title, or no

[DISCUSS] Adopt pull request template

Hi devs, I have seen some pull requests which are not having JIRA issue, or bad title, or no description for rationale on pull request and issue. We already have DEVELOPER.md but this document covers more than contribution and also not shown while opening pull request. I think we should add