[GitHub] [storm] bipinprasad commented on a change in pull request #3284: [STORM-3271] Refactor ResourceIsolationInterface in preparation for container support

2020-06-09 Thread GitBox
bipinprasad commented on a change in pull request #3284: URL: https://github.com/apache/storm/pull/3284#discussion_r437750333 ## File path: storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java ## @@ -130,14 +130,15 @@ public

[GitHub] [storm] bipinprasad commented on a change in pull request #3284: [STORM-3271] Refactor ResourceIsolationInterface in preparation for container support

2020-06-09 Thread GitBox
bipinprasad commented on a change in pull request #3284: URL: https://github.com/apache/storm/pull/3284#discussion_r437632606 ## File path: storm-server/src/test/java/org/apache/storm/utils/ServerUtilsTest.java ## @@ -71,4 +80,88 @@ public void

[GitHub] [storm] bipinprasad commented on a change in pull request #3284: [STORM-3271] Refactor ResourceIsolationInterface in preparation for container support

2020-06-09 Thread GitBox
bipinprasad commented on a change in pull request #3284: URL: https://github.com/apache/storm/pull/3284#discussion_r437628463 ## File path: storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java ## @@ -130,14 +130,15 @@ public

[GitHub] [storm] bipinprasad commented on a change in pull request #3284: [STORM-3271] Refactor ResourceIsolationInterface in preparation for container support

2020-06-09 Thread GitBox
bipinprasad commented on a change in pull request #3284: URL: https://github.com/apache/storm/pull/3284#discussion_r437626357 ## File path: storm-server/src/main/java/org/apache/storm/container/cgroup/CgroupManager.java ## @@ -305,8 +302,7 @@ private void