[GitHub] storm issue #1352: STORM-1723 (1.x) Introduce ClusterMetricsConsumer

2016-06-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1352 Never mind. Pull request for master is here: #1460. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] storm issue #1352: STORM-1723 (1.x) Introduce ClusterMetricsConsumer

2016-06-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1352 @harshach @hmcl Addressed review comments, and rebased with commits squashed. I feel applying this to 1.0.x seems to be against semantic versioning, so I would not address it. Do we want

[GitHub] storm issue #1352: STORM-1723 (1.x) Introduce ClusterMetricsConsumer

2016-06-02 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1352 +1. I am also in favor of making cluster summary modular. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] storm issue #1352: STORM-1723 (1.x) Introduce ClusterMetricsConsumer

2016-06-02 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1352 +1 . If possible we should move extracting cluster summary to a common file and use that in ui and nimbus --- If your project is set up for it, you can reply to this email and have your reply appea