Github user sakanaou commented on the issue:
https://github.com/apache/storm/pull/1480
Closed as requested due to STORM-2016.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1480
@sakanaou
Since STORM-2016 is merged into master and 1.x-branch, so I think we can
close this.
Could you please doing it? Thanks in advance!
---
If your project is set up for it, you c
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1480
STORM-2016 is on reviewing, and it should help this get resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1480
Sorry for long delay, say, 1 month.
I've met similar issue on Storm SQL, so I've initiate discussion to dev@
list.
Along with discussion, I'm trying to see how Spark handles dependencies a
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1480
Getting rid of Guava seems easy since storm-redis uses Precondition,
ImmutableMap, Maps, Lists.
Getting rid of Jackson seems not easy since we take StateConfig to JSON
format so we need JSON
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1480
Let me have a look. I guess storm-redis doesn't need to depend on other
than storm-core and Jedis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user abhishekagarwal87 commented on the issue:
https://github.com/apache/storm/pull/1480
If you use already relocated classes, you make storm-redis module dependent
on a particular version of storm-core. relocation pattern is subject to changes
in storm-core (since it is intern
Github user sakanaou commented on the issue:
https://github.com/apache/storm/pull/1480
@abhishekagarwal87: Ok, didn't spot that. Was only looking for "guava"
relocations.
So, the dependency could be additionally included relocated into
storm-redis. Or is it possible to use th
Github user abhishekagarwal87 commented on the issue:
https://github.com/apache/storm/pull/1480
guava dependency is relocated in storm-core.
https://github.com/apache/storm/blob/2a435b0289d43494eb2f834e94ed61c175f9eea6/storm-core/pom.xml#L593
---
If your project is set up for it,
Github user sakanaou commented on the issue:
https://github.com/apache/storm/pull/1480
@HeartSaVioR: `storm-core/pom.xml` includes a `maven-shade-plugin` step
that lists both guava and jackson as artifactSet-includes without relocations.
Why should they then not be provided via storm-
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1480
We're shading the libraries which you're changing scope to `provided` in
storm-core, so it will not be provided at runtime.
Since storm-redis depends on Guava, placing uber storm-redis jar to
Github user abhishekagarwal87 commented on the issue:
https://github.com/apache/storm/pull/1480
Thanks @sakanaou
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user sakanaou commented on the issue:
https://github.com/apache/storm/pull/1480
@abhishekagarwal87: Original jar is 65K, shaded jar is 709K. guava and
jackson are already contained in storm-core so those can be ignored, luckily.
---
If your project is set up for it, you can re
Github user abhishekagarwal87 commented on the issue:
https://github.com/apache/storm/pull/1480
just curious, how much is the size of fat jar?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
14 matches
Mail list logo
