[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1493 @HeartSaVioR OK Close it :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1493 @darionyaphet Let's close for now. We can enrich description to README how to pass ZK properties when we think it would be better to guide passing ZK properties. --- If your project is set

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1493 @HeartSaVioR Yes I know . Because Zookeeper properties is very useful , so I wish to open a new API to support it :) . If you think it's unnecessarily , I will close this PR . --- If your

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1493 @darionyaphet You can set properties which we can pass to hbase-*.xml into Storm configuration Map (under specific key for hbase), and storm-hbase merges (override) that configuration with

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1493 @HeartSaVioR I got we can set config using `Config` and don't have to support new API ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1493 @darionyaphet I mean we already support the thing what TODO describes. Please refer

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1493 @HariSekhon Yep So sorry ~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

Github user HariSekhon commented on the issue: https://github.com/apache/storm/pull/1493 @darionyaphet wrong @ person? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1493 @HariSekhon what you mean is should remove `TODO` when all HBase options have provided ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1493 Since we override all options being provided from HBase config, these three parameters can be fed as well. I think just removing TODO would be fine. --- If your project is set up for it, you