[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-08-08 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1583 Thanks @omkreddy , pushed this change to master and 1.x-branch, added you as a contributor. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-08-08 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1583 @omkreddy I will merge it in tomorrow w.r.t 24hrs wait policy after last commit. Thanks for your work. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-08-05 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1583 +1 after addressing minor comment in README doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-08-05 Thread omkreddy
Github user omkreddy commented on the issue: https://github.com/apache/storm/pull/1583 @satishd Thanks for the review. addressed review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-08-05 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1583 @omkreddy Let me know once the comments are addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-08-05 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1583 missed @satishd suggestions above. Once those addressed I am +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-08-05 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1583 +1. Nice work @omkreddy . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-08-04 Thread omkreddy
Github user omkreddy commented on the issue: https://github.com/apache/storm/pull/1583 @satishd added you as committer sponsor. also addressed review comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-08-04 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1583 @omkreddy You can add me as committer sponsor for this module. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-08-04 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1583 @omkreddy you need to upmerge the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-08-04 Thread omkreddy
Github user omkreddy commented on the issue: https://github.com/apache/storm/pull/1583 @harshach @satishd I have addressed review comments. Pl review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-25 Thread omkreddy
Github user omkreddy commented on the issue: https://github.com/apache/storm/pull/1583 @ptgoetz Thanks. I added you as committer sponsor. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-21 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1583 @omkreddy I haven't had a chance to review it fully yet, but you can add me as a committer sponsor. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-21 Thread omkreddy
Github user omkreddy commented on the issue: https://github.com/apache/storm/pull/1583 This implementation uses Druid's Tranquility library (https://github.com/druid-io/tranquility) to send to druid store. Some of the concepts are borrowed from Tranquility storm connector