Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1627
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user zhuoliu commented on the issue:
https://github.com/apache/storm/pull/1627
Since with the refactoring we directly access the disruptor queue to get
the backpressure status rather than having an additional flag in executor data
which is error-prone when flipping (which is ve
Github user zhuoliu commented on the issue:
https://github.com/apache/storm/pull/1627
sure, Alex. Really appreciate if you can submit a separate PR for 1949.
+1 to this one!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user abellina commented on the issue:
https://github.com/apache/storm/pull/1627
@zhuoliu thanks for the comment. I am taking a look at STORM-1949 to try
and reproduce it, and will comment there. I think that is a separate issue from
this PR so we should see a potential fix to S
Github user zhuoliu commented on the issue:
https://github.com/apache/storm/pull/1627
@abellina looks good to me, just one extra suggestion:
In
https://github.com/apache/storm/blob/master/storm-core/src/clj/org/apache/storm/daemon/worker.clj#L156
To reduce the traffic to ZK
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1627
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user abellina commented on the issue:
https://github.com/apache/storm/pull/1627
@knusbaum I made the changes suggested. Also removed an extra fn wrapper on
that function triggered by the timer.
---
If your project is set up for it, you can reply to this email and have your
re
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1627
+1 for the changes. My comments are suggestions for a couple more.
The travis failures look unrelated. Storm Core passes.
---
If your project is set up for it, you can reply to this email and ha
