[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1697 OK. Unit and integration tests, and manual tests passed on recent commits. I'm +1 and will merge this now since there's no more reviewer and this was open for fairly long, more than 1 month

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 @srdo sounds good. I filed https://issues.apache.org/jira/browse/STORM-2175 to address the race condition. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user srdo commented on the issue: https://github.com/apache/storm/pull/1697 @revans2 I can't share our actual test code since it depends on pretty large chunks of our codebase. I'll try reproducing with an example topology. I'd be fine with filing a separate issue to

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1697 @revans2 @srdo I'm even OK if we file an issue regarding intermittent race condition for local cluster and merge this now, since the race condition of Supervisor in 1.x is much critical. It

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 OK so going through the code in both cases it looks like the only way that can happen is if the workers is somehow being shut down multiple times. My guess is that because the slots are on

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user srdo commented on the issue: https://github.com/apache/storm/pull/1697 I seem to be getting a few new errors when running some of our own unit tests with this branch. The exceptions are intermittent. ``` java.lang.NullPointerException at

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 @HeartSaVioR good catch, I thought I had deleted it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1697 @revans2 Shouldn't healthcheck.clj be deleted? At least for me HealthCheck.java clashes with healthcheck.clj. I can't clearly say why, might be specific issue with OSX, but anyway there's an

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 Merged in #1724 now too (it was a trivial cherry pick). @HeartSaVioR if you want to take a look this should be good for merging in. Just as an FYI we have been running with a

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 Just pushed the upmerged code. Will look into pulling in #1724 too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1697 @revans2 Do you have any updates on this? I'm occasionally seeing Supervisor failures so would like to get this merged to 1.x, and even 1.0.x. --- If your project is set up for it, you can

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1697 @revans2 It would be better to address STORM-2131 here as well. Please pull #1724 here. And could you update the pull request according to the review comments? Supervisor V2 is the one

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1697 I found two issues, but other than that manual tests passed. Code review is already done from PR for master branch. +1 once these are resolved. --- If your project is set up for it, you can

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1697 While running build in storm-core I found that null/storm-local directory is created in storm-core. Maybe there's a case base path is set to null. --- If your project is set up for it, you can

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1697 I just cherry-picked commit which excludes logs from RAT. It's merged to master but was part of port work so didn't port back. --- If your project is set up for it, you can reply to this email

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 The test failures look unrelated. Some are rat failures caused by test logs not being excluded. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 Just pulled in the latest set of bug fixes from master. All known issues have been addressed and we have been running in staging with various versions of this patch for over a week now. Expect to

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1697 @revans2 Relevant PRs (#1699 #1700 #1705 #1712) are all merged to master. Please pull them here. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 Still have #1699 and #1712 to backport before this is ready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: [GitHub] storm issue #1697: STORM-2018: Supervisor V2

Can you please let me know how to unsubscribe I have followed instructions without success On Sep 21, 2016 11:08 AM, "revans2" wrote: > Github user revans2 commented on the issue: > > https://github.com/apache/storm/pull/1697 > > I ran the same set of manual tests

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 We also found #1700 so once that goes in I'll pull it in here too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1697: STORM-2018: Supervisor V2

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1697 I ran the same set of manual tests as before, but I now want to wait on #1699 to go into master, and then I will pull it in here. We are in the process of rolling essentially what is this same