Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
@hmcl
We applied opposite approach for this. Could you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
Before:
-rw-r--r-- 1 jlim staff 3.3K 3 2 19:41
apache-storm-2.0.0-SNAPSHOT.pom
-rw-r--r-- 1 jlim staff 473B 3 2 19:41
apache-storm-2.0.0-SNAPSHOT.pom.asc
-rw-r--r-- 1
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
Also could you check how big binary dist (tar.gz / zip) will be? It's
already over 200MB so IMHO it would be better to reduce/restrict the size of
binary dist.
---
If your project is set up
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
@hmcl
Right. But I changed my mind that all examples should contain the code,
like storm-starter in binary dist. We're extracting examples to show example
**codes** for each modules, so the
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1831
@HeartSaVioR do you mean each README of each module should have a section
on how to run the JAR, and the main for that JAR? I agree with that. Perhaps I
could file a follow-up JIRA for that.
---
If
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
@harshach @hmcl
Then we should add available topologies in README for each modules to since
users don't know which topologies are available.
---
If your project is set up for it, you can
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1831
@HeartSaVioR I think it makes sense to have the shaded jars. It will be
easier to run the code for the users who not familiar with storm packaging and
gives insight into building a topology jar as
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
@hmcl
The change looks great, but we need to think why shaded jar of examples are
necessary to be included to binary distribution.
AFAIK the examples modules (except storm-starter) are
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1831
Whit these changes the examples distribution looks like this:
