Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
Thanks for merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1939
@pasalkarsachin1
Merged into master via 313e960bedde3b2c47520a74c391425d79271727, and 1.x
branch via 4fc55b33504d446ef192a25e5164f861e1495291.
Could you close this PR? Thanks in advance.
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR Can you merge this so I will close this PR :) Thanks in
advance
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR Squashed into one commit. Commit sha is
7cc1bdbea562a48aa09cc6dc7fd29edd5bd4eb10
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1939
+1
@pasalkarsachin1 Could you squash commits into one? Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR I have updated code as per your comment :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR Can you take a look at it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
Can someone take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR I did my best. Can you take a look at it now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1939
@pasalkarsachin1
Indentation is still off. Could you please check the diff on PR?
https://github.com/apache/storm/pull/1939/files
---
If your project is set up for it, you can reply to
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1939
@pasalkarsachin1
We don't use 8 spaces for indentation from other java files. If the
indentation spaces was 4, it should be 4 unless we set brand new style guide.
Code style is important as
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
I haven't changed anything it was I guess previous one had style. You can
ignore white space by appending ?w=1 to url. e.g.
https://github.com/apache/storm/pull/1939/files?w=1 This shows
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1939
@pasalkarsachin1 Could you preserve the style? I'm sorry we don't have
clear style guide but most of changeset is from spaces.
---
If your project is set up for it, you can reply to this email
14 matches
Mail list logo
