[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @revans2 You are right.I created several PRs which has been mergerd that is related to ACL. I will update SECURITY.md in a new PR with these changes later.Could you help me merge this PR fir

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2207 I do agree with @Ethanlm that updating SECURITY.md would probably be more helpful, but if you want this to be a first step then I am happy to merge it in. --- If your project is set up for it, you c

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @revans2 Could you help me review this PR，there are no committer to review it all the time. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @Ethanlm Ok,thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2207 Thanks. @liu-zhaokun . I was just thinking that adding some instructions on [SECURITY.md](https://github.com/apache/storm/blob/master/SECURITY.md#drpc-1) about DRPC is better than adding one more fil

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @Ethanlm Hi,could you help me review the new change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @Ethanlm Thanks for your reply.I will modify it follow your suggestion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @HeartSaVioR Do you have time to help me review this PR,it's about drpc acl? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @harshach I am so sorry to bother you.Do you have time to help me review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @vesense I am so sorry to bother you.Do you have time to help me review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @HeartSaVioR I am so sorry to bother you.Do you have time to help me review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well