[GitHub] storm issue #2248: STORM-2028: Fix for uprooting the JDBC client exceptions ...

2017-08-08 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2248 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] storm issue #2248: STORM-2028: Fix for uprooting the JDBC client exceptions ...

2017-08-03 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2248 To me it looks good, just one question about the test (and this is mostly for my own knowledge). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] storm issue #2248: STORM-2028: Fix for uprooting the JDBC client exceptions ...

2017-08-02 Thread rahuljain373
Github user rahuljain373 commented on the issue: https://github.com/apache/storm/pull/2248 @HeartSaVioR Squashed the commits and fixed the styling issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] storm issue #2248: STORM-2028: Fix for uprooting the JDBC client exceptions ...

2017-08-02 Thread RPCMoritz
Github user RPCMoritz commented on the issue: https://github.com/apache/storm/pull/2248 @HeartSaVioR since you helped out with this issue previously - can we get some committer attention to this PR? LGTM quickly. --- If your project is set up for it, you can reply to this email and h

[GitHub] storm issue #2248: STORM-2028: Fix for uprooting the JDBC client exceptions ...

2017-08-02 Thread rahuljain373
Github user rahuljain373 commented on the issue: https://github.com/apache/storm/pull/2248 @RPCMoritz Should i ask someone for merge?? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea