[GitHub] storm issue #2331: [STORM-2743] Add logging to monitor how long scheduling i...

2017-09-22 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2331 @Ethanlm I am fine with having 2 histograms, but quite honestly the number of topologies is not that interesting or helpful and I would rather drop it. The number of topologies has relatively

[GitHub] storm issue #2331: [STORM-2743] Add logging to monitor how long scheduling i...

2017-09-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2331 @Ethanlm I'm OK to have two metrics and IMO that is right way since we measure two different things, one for topology count, another one for topology schedule delay. ---

[GitHub] storm issue #2331: [STORM-2743] Add logging to monitor how long scheduling i...

2017-09-21 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2331 @jerrypeng @HeartSaVioR Thanks for the review. Just one question, do we use two Histograms one for the number of the topology and the other one for the time the scheduling takes? I didn't find any

[GitHub] storm issue #2331: [STORM-2743] Add logging to monitor how long scheduling i...

2017-09-21 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2331 +1 and agree @jerrypeng that better to 'also' record with histogram via StormMetricsRegistry.registerHistogram() like Nimbus records for other operations with Meter. ---

[GitHub] storm issue #2331: [STORM-2743] Add logging to monitor how long scheduling i...

2017-09-19 Thread jerrypeng
Github user jerrypeng commented on the issue: https://github.com/apache/storm/pull/2331 +1 but perhaps its work while looking into using something like dropwizard metrics: http://metrics.dropwizard.io/3.2.3/manual/core.html ---