Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2419
Thanks, happy to help :)
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2419
@srdo thanks for the review you found a lot of bugs and made this a lot
better.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2419
Thanks, +1
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2419
@srdo I have fixed the issues you called out
@Ethanlm I fixed the issue you saw.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2419
@srdo I think I have addressed all of your comments. I also found a few
places were an NPE could happen, and one where the TopologyBuilder was not
setting the resource configs correctly. I fixed