Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2537
@srdo
I've found some divergence between master and 1.x branch. Could you raise
pull request on 1.x-branch as well? I'm OK to raise a PR with two commits
(STORM-2914/STORM-2913).
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2537
+1. Let's squash and as far as I am concerned it is good to merge. Once
this is squash can you please rebase STORM-2913. Thanks.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2537
@hmcl Thanks for the review, caught a lot of oversights :)
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2537
@hmcl Addressed your comments. Also fixed the storm-kafka-client docs to
use release specific links, instead of linking to the 1.0.x branch. I've
removed some of the listings of enum values in favor of
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2537
@hmcl Updated to address your list at
https://issues.apache.org/jira/browse/STORM-2914?focusedCommentId=16351147=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16351147.
Let
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2537
@srdo I left the
[comment](https://issues.apache.org/jira/browse/STORM-2914?focusedCommentId=16346102=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16346102)
on the JIRA.
