Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2549
+1
Thanks @HeartSaVioR for working on this right away.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2549
@hmcl Addressed.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2549
@hmcl Got it. You're saying marking the origin commit offset. Makes sense.
I'll do it.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2549
+1
@HeartSaVioR I meant to say that you should add also to the commit log the
SHA of the 1.x-branch that you checked out and of which copied the entire
storm-kafka-client directory and the
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2549
@hmcl Just applied your review comment.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2549
@hmcl
Yes that's only `InterfaceStability` which was needed in storm-core for
1.1.x-branch. I was a bit confused between 1.1.x-branch and 1.0.x-branch, which
1.0.x-branch requires more
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2549
@HeartSaVioR I agree that your approach. Can please add to the commit
message the SHA from the 1.x-branch that was the base for this overwrite, such
that one can trace it down in case it is necessary.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2549
+1. Hope we can avoid something like this in the future. Thanks for the
quick PR Jungtaek.
---
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2549
+1
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2549
So the commit solely represents divergence between 1.x and 1.1.x in point
of storm-kafka-client's view, and there's no basis to separate commits for this.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2549
Such iteration would be much harder for 1.0.x, since there're more changes
on 'storm-core' applied in 1.1.x, hence storm-core is (surely) more diverged
for storm-kafka-client.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2549
@erikdw
"fix compilation issues due to storm-core" <== maybe my bad to explain
here, I don't fix something specific for compilation, but I was done
iterations: build -> found error -> found
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2549
Also can you please tell me how you "archived" the couple of items that you
did?
---
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2549
I know we've talked with @hmcl about the "to squash or not to squash?"
question -- IMNSHO this is a perfect example of where squashing is a bad idea.
i.e., I have *no* idea what "fix compilation
14 matches
Mail list logo
