[GitHub] storm issue #2700: [STORM-3093] Cache the storm id to executors mapping on m...

2018-06-04 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2700 The travis failure looks unrelated. ---

[GitHub] storm issue #2700: [STORM-3093] Cache the storm id to executors mapping on m...

2018-06-04 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2700 @danny0405 No it's fine. Thanks for the contribution. ---

[GitHub] storm issue #2700: [STORM-3093] Cache the storm id to executors mapping on m...

2018-06-04 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2700 @Ethanlm Sorry i have not did the benchmark test, but we can see the promotion through the storm-core module building time, it's about 10 seconds faster on my laptop. I can add in

[GitHub] storm issue #2700: [STORM-3093] Cache the storm id to executors mapping on m...

2018-06-04 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2700 Looks good. Do you have any performance test results to share so that we can have an idea how much performance gain this patch gets? It's fine if you don't have it ---